Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: netcdf-decoder Converts WMO GRIB products into NetCDF files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215445

Jochen@herr-schmitt.de changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@fedoraproject.org |Jochen@herr-schmitt.de OtherBugsDependingO|163776 |163778 nThis| |

------- Additional Comments From Jochen@herr-schmitt.de 2006-11-14 12:03 EST ------- God: + Rpmlint doesn't complaints source package. + Local build works fine. + rpmlint doesn't complaints binary package. + Mock build works fine. + Tarbar in source RPM matches with upstream. + RPM contains verbatin copy of the license text. + License text seem to be ok for free software

Bad: - Can't install becouse perlNetCDF) is required.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: netcdf-decoder Converts WMO GRIB products into NetCDF files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215445

Bug 215445 depends on bug 215444, which changed state.

Bug 215444 Summary: Review Request: netcdf-perl Perl extension module for scientific data access via the netCDF API https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215444

What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |NEXTRELEASE Status|ASSIGNED |CLOSED

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: netcdf-decoder Converts WMO GRIB products into NetCDF files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215445

------- Additional Comments From Jochen@herr-schmitt.de 2007-01-25 14:09 EST ------- Good: + Tarball in source RPM match with upstream. + rpmlint is quite on source rpm. + Local build works fine. + rpmlint is quite on binary rpm. + Local install and uninstalling works fine.

Bad: - The %makeinstall macro should not be used (wiki: PackagingGuidelines#MakeInstall)

Sorry, I have to interupt, becouse I have a install problem with mock on my new machine.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: netcdf-decoder Converts WMO GRIB products into NetCDF files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215445

------- Additional Comments From Jochen@herr-schmitt.de 2007-01-25 14:28 EST ------- I will cite:

Why the %makeinstall macro should not be used

Fedora's RPM includes a %makeinstall macro but it must NOT be used when make install DESTDIR=%{buildroot} will work. %makeinstall is a kludge that can work with Makefiles that don't make use of the DESTDIR variable but it has the following potential issues:

*

%makeinstall overrides a set of environment variables during "make install". I.e. it performs make prefix="..." includedir="..." ... *

It is error prone, and can have unexpected effects when run against less than perfect Makefiles. *

It can trigger unnecessary rebuilds when executing "make install" *

If a package contains libtool archives, it can cause broken *.la files to be installed.

Instead, Fedora packages should use: make DESTDIR=%{buildroot} install or make DESTDIR=$RPM_BUILD_ROOT install

Thsi is a list of reasons why %Makeinstall should not used.

Sory for any inconviniences.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: netcdf-decoder Converts WMO GRIB products into NetCDF files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215445

------- Additional Comments From orion@cora.nwra.com 2007-01-25 15:14 EST ------- (In reply to comment #6)

I will cite:

Why the %makeinstall macro should not be used

Fedora's RPM includes a %makeinstall macro but it must NOT be used when make install DESTDIR=%{buildroot} will work.

^^^^^^^^^

And I say again, DESTDIR does NOT work with this package, and %makeinstall does. If someone can show me a clean way to add DESTDIR support, that would be nice. But the configure system used in this package is very outdated and I don't think it's work spending time on it when a reasonable work around is available.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: netcdf-decoder Converts WMO GRIB products into NetCDF files

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=215445

------- Additional Comments From orion@cora.nwra.com 2007-01-29 12:59 EST ------- Thanks. Checked it and built. Added to owners.list. Requesting branches...

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: netcdf-decoder Converts WMO GRIB products into NetCDF files

https://bugzilla.redhat.com/show_bug.cgi?id=215445

bugzilla@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium Product|Fedora Extras |Fedora Version|devel |rawhide