[Bug 2277858] New: Review Request: rust-async_http_range_reader - Library for streaming reading of files over HTTP using range requests
1:06 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Bug ID: 2277858
Summary: Review Request: rust-async_http_range_reader - Library
for streaming reading of files over HTTP using range
requests
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Assignee: nobody(a)fedoraproject.org
Reporter: code(a)musicinmybrain.net
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Depends On: 2251680
Target Milestone: ---
Classification: Fedora
Spec URL: https://music.fedorapeople.org/rust-async_http_range_reader.spec
SRPM URL:
https://music.fedorapeople.org/rust-async_http_range_reader-0.7.1-1.fc39....
Description:
A library for streaming reading of files over HTTP using range requests.
Fedora Account System Username: music
This is a dependency for a future package of https://pypi.org/project/uv. It
requires rust-axum-0.7.5, bug 2251680.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2251680
[Bug 2251680] rust-axum-0.7.5 is available
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
1:08 p.m.
New subject: [Bug 2277858] Review Request: rust-async_http_range_reader - Library
for streaming reading of files over HTTP using range requests
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
--- Comment #1 from Ben Beasley <code(a)musicinmybrain.net> ---
Created attachment 2030064
--> https://bugzilla.redhat.com/attachment.cgi?id=2030064&action=edit
Configuration file for rust2rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
1:09 p.m.
New subject: [Bug 2277858] Review Request: rust-async_http_range_reader - Library
for streaming reading of files over HTTP using range requests
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Ben Beasley <code(a)musicinmybrain.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment|0 |1
#2030064 is| |
obsolete| |
--- Comment #2 from Ben Beasley <code(a)musicinmybrain.net> ---
Created attachment 2030065
--> https://bugzilla.redhat.com/attachment.cgi?id=2030065&action=edit
Configuration file for rust2rpm
Removed obsolete commented-out cruft
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
2:24 p.m.
New subject: [Bug 2277858] Review Request: rust-async_http_range_reader - Library
for streaming reading of files over HTTP using range requests
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Bug 2277858 depends on bug 2251680, which changed state.
Bug 2251680 Summary: rust-axum-0.7.5 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2251680
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |CLOSED
Resolution|--- |ERRATA
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
8:08 a.m.
New subject: [Bug 2277858] Review Request: rust-async_http_range_reader - Library
for streaming reading of files over HTTP using range requests
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Bug 2277858 depends on bug 2277397, which changed state.
Bug 2277397 Summary: Review Request: rust-http-content-range - HTTP Content Range response
header parser
https://bugzilla.redhat.com/show_bug.cgi?id=2277397
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |CLOSED
Resolution|--- |ERRATA
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
9:03 a.m.
New subject: [Bug 2277858] Review Request: rust-async_http_range_reader - Library
for streaming reading of files over HTTP using range requests
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Bug 2277858 depends on bug 2277389, which changed state.
Bug 2277389 Summary: Review Request: rust-bisection - Rust implementation of the Python
bisect module
https://bugzilla.redhat.com/show_bug.cgi?id=2277389
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |CLOSED
Resolution|--- |ERRATA
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
5:35 p.m.
New subject: [Bug 2277858] Review Request: rust-async_http_range_reader - Library
for streaming reading of files over HTTP using range requests
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Fabio Valentini <decathorpe(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags| |fedora-review+
Assignee|nobody(a)fedoraproject.org |decathorpe(a)gmail.com
--- Comment #4 from Fabio Valentini <decathorpe(a)gmail.com> ---
Having taken a look, I think I can confirm your analysis that the "andes" conda
package looks fine to distribute, and its contents are not included in the
built RPMs. I'm not sure why the project has decided to use such a weird thing
as test data, but oh well.
I'm slightly concerned about the amount of effort that's required to run the
test suite of this package though.
Most of the dev-dependencies are quite large (axum, tower, tokio, rstest) or
outdated and can't be easily patched (async_zip 0.0.15).
It's great that you went through the process of making it work, I'm just
worried whether it's going to be sustainable long-term.
Also note that a new version of this crate was released since you filed this
review - v0.8.0.
But It's fine to import the current version if that's what you need.
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
! latest version of the crate is packaged (v0.7.1 vs. v0.8.0)
- license matches upstream specification and is acceptable for Fedora
- license file is included with %license in %files
- package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- set up package on release-monitoring.org:
project: $crate
homepage: https://crates.io/crates/$crate
backend: crates.io
version scheme: semantic
version filter: alpha;beta;rc;pre
distro: Fedora
Package: rust-$crate
- add @rust-sig with "commit" access as package co-maintainer
(should happen automatically)
- set bugzilla assignee overrides to @rust-sig (optional)
- track package in koschei for all built branches
(should happen automatically once rust-sig is co-maintainer)
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
7:25 a.m.
New subject: [Bug 2277858] Review Request: rust-async_http_range_reader - Library
for streaming reading of files over HTTP using range requests
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
--- Comment #5 from Ben Beasley <code(a)musicinmybrain.net> ---
Thank you for the review!
(In reply to Fabio Valentini from comment #4)
Having taken a look, I think I can confirm your analysis that the
"andes"
conda package looks fine to distribute, and its contents are not included in
the built RPMs. I'm not sure why the project has decided to use such a weird
thing as test data, but oh well.
I'm slightly concerned about the amount of effort that's required to run the
test suite of this package though.
Most of the dev-dependencies are quite large (axum, tower, tokio, rstest) or
outdated and can't be easily patched (async_zip 0.0.15).
It's great that you went through the process of making it work, I'm just
worried whether it's going to be sustainable long-term.
The async_zip 0.0.15 dependency is a frustrating one. Unfortunately, that’s
also a build dependency, not just a test dependency, so we can’t get rid of it
by simply disabling the tests. (As previously mentioned, uv currently carries
its own forked async_zip that will have to be bundled as a git snapshot, but we
still can’t really package async_http_range_reader without its build
dependencies. At that point we might as well bundle it in uv too.)
For the large dev dependencies, I figured they are likely to be kept packaged
and working for other applications, and can probably be kept working here since
they’re used in a pretty straightforward way, API-wise. I do think it’s worth
trying to keep running the tests on a “best reasonable effort” basis. However,
if it gets to the point where this is untenable, or it looks like we would have
to start maintaining compat packages just for this package’s tests, I’m
perfectly willing to disable them again.
Also note that a new version of this crate was released since you filed this
review - v0.8.0.
But It's fine to import the current version if that's what you need.
Aha, so there is. It looks like the change in
https://github.com/prefix-dev/async_http_range_reader/compare/v0.7.1...v0...
is straightforward, and the current release of uv has already updated its
dependencies, so I’ll update to 0.8.0 right away, with no packaging changes
required other than the version number.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
7:26 a.m.
New subject: [Bug 2277858] Review Request: rust-async_http_range_reader - Library
for streaming reading of files over HTTP using range requests
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
--- Comment #6 from Ben Beasley <code(a)musicinmybrain.net> ---
https://release-monitoring.org/project/372390/
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
12:12 p.m.
New subject: [Bug 2277858] Review Request: rust-async_http_range_reader - Library
for streaming reading of files over HTTP using range requests
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |MODIFIED
--- Comment #7 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2024-0229d5f628 (rust-async_http_range_reader-0.8.0-1.fc41) has been
submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0229d5f628
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
12:53 p.m.
New subject: [Bug 2277858] Review Request: rust-async_http_range_reader - Library
for streaming reading of files over HTTP using range requests
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |ERRATA
Status|MODIFIED |CLOSED
Last Closed| |2024-05-16 17:53:31
--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2024-0229d5f628 (rust-async_http_range_reader-0.8.0-1.fc41) has been
pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
1:34 p.m.
New subject: [Bug 2277858] Review Request: rust-async_http_range_reader - Library
for streaming reading of files over HTTP using range requests
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2024-c2abca435e (rust-async_http_range_reader-0.8.0-1.fc40,
rust-bisection-0.1.0-2.fc40, and 5 more) has been submitted as an update to
Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c2abca435e
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
1:43 p.m.
New subject: [Bug 2277858] Review Request: rust-async_http_range_reader - Library
for streaming reading of files over HTTP using range requests
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
--- Comment #10 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2024-0bfd6dabc2 (rust-async_http_range_reader-0.8.0-1.fc39,
rust-bisection-0.1.0-2.fc39, and 5 more) has been submitted as an update to
Fedora 39.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0bfd6dabc2
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
8:36 p.m.
New subject: [Bug 2277858] Review Request: rust-async_http_range_reader - Library
for streaming reading of files over HTTP using range requests
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
--- Comment #11 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2024-0bfd6dabc2 has been pushed to the Fedora 39 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2024-0bfd6dabc2 \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-0bfd6dabc2
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
9:09 p.m.
New subject: [Bug 2277858] Review Request: rust-async_http_range_reader - Library
for streaming reading of files over HTTP using range requests
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
--- Comment #12 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2024-c2abca435e has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh
--advisory=FEDORA-2024-c2abca435e \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2024-c2abca435e
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2277858
Report this comment as SPAM:
https://bugzilla.redhat.com/enter_bug.cgi?product=Bugzilla&format=rep...
4
days inactive
22
days old
package-review@lists.fedoraproject.org
14 comments
1 participants
participants (1)
-
bugzilla＠redhat.com