https://bugzilla.redhat.com/show_bug.cgi?id=1353169
Neal Gompa ngompa13@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(ngompa13@gmail.co |needinfo?(jamatos@fc.up.pt) |m) |
--- Comment #43 from Neal Gompa ngompa13@gmail.com --- (In reply to José Matos from comment #42)
Hi Neal,
what is missing in this review?
FWIW in my todo list there is just a small issue, that can be done at ay time. According to nikola's source:
""" We ship some third-party things with Nikola. They live here, along with their licenses.
Packages:
- tzlocal by Lennart Regebro, CC0 license (modified)
- datecond by Chris Warrick (Nikola contributor), 3-clause BSD license (modified)
"""
The second is very small and from one of nikola's main contributors. I asked about tzlocal and it can be done, with just a small change, either by using the system tzlocal and by changing to pytz: https://groups.google.com/forum/#!topic/nikola-discuss/3vXZFJF_-h4
Please document the bundled dependencies and their versions and why, per the policy.
Cf. https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling Cf. https://fedoraproject.org/wiki/Bundled_Libraries#Requirement_if_you_bundle
I would prefer to see tzlocal unbundled, though I can accept this upstream preferring otherwise as long as it is documented properly.
package-review@lists.fedoraproject.org