https://bugzilla.redhat.com/show_bug.cgi?id=2217186
Bug ID: 2217186 Summary: Review Request: rust-gix-trace - To provide minimal tracing support that can be turned off to zero cost Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: h-k-81@hotmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://blinxen.fedorapeople.org/phase1/rust-gix-trace.spec SRPM URL: https://blinxen.fedorapeople.org/phase1/rust-gix-trace-0.1.1-1.fc39.src.rpm Description: A crate to provide minimal `tracing` support that can be turned off to zero cost. Fedora Account System Username: blinxen
https://bugzilla.redhat.com/show_bug.cgi?id=2217186
blinxen h-k-81@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |2216739 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2216739 [Bug 2216739] rust-gix-path-0.8.2 is available
https://bugzilla.redhat.com/show_bug.cgi?id=2217186
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |decathorpe@gmail.com CC| |decathorpe@gmail.com Flags| |fedora-review?
--- Comment #1 from Fabio Valentini decathorpe@gmail.com --- The rust-gix-trace+document-features-devel subpackage is not installable, since the document-features crate is not packaged for Fedora. Please remove this optional feature. It is only used upstream / on docs.rs when building documentation, which we don't do for Rust crates.
Other than that, package looks good to me.
https://bugzilla.redhat.com/show_bug.cgi?id=2217186
blinxen h-k-81@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |rust-gix-trace - To provide |rust-gix-trace - Minimal |minimal tracing support |tracing support for |that can be turned off to |gitoxide that can be turned |zero cost |off to zero cost
https://bugzilla.redhat.com/show_bug.cgi?id=2217186
--- Comment #2 from blinxen h-k-81@hotmail.com --- I updated the files and also made the summary more user friendly.
https://bugzilla.redhat.com/show_bug.cgi?id=2217186
Fabio Valentini decathorpe@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ Status|ASSIGNED |POST
--- Comment #3 from Fabio Valentini decathorpe@gmail.com --- Thanks, looks good to me now. Sorry for the delay, I somehow missed the email notification for your last update.
===
Package was generated with rust2rpm, simplifying the review.
- package builds and installs without errors on rawhide - test suite is run and all unit tests pass - latest version of the crate is packaged - license matches upstream specification and is acceptable for Fedora - license file is included with %license in %files - package complies with Rust Packaging Guidelines
Package APPROVED.
===
Recommended post-import rust-sig tasks:
- add @rust-sig with "commit" access as package co-maintainer
- set bugzilla assignee overrides to @rust-sig (optional)
- set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate
- track package in koschei for all built branches
https://bugzilla.redhat.com/show_bug.cgi?id=2217186
--- Comment #4 from Fedora Admin user for bugzilla script actions fedora-admin-xmlrpc@fedoraproject.org --- The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-gix-trace
https://bugzilla.redhat.com/show_bug.cgi?id=2217186
blinxen h-k-81@hotmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2023-07-03 20:24:41
--- Comment #5 from blinxen h-k-81@hotmail.com --- Imported and built: https://bodhi.fedoraproject.org/updates/FEDORA-2023-a61761c7b9
package-review@lists.fedoraproject.org