https://bugzilla.redhat.com/show_bug.cgi?id=858381
Bug ID: 858381 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: jogl2 - Java bindings for the OpenGL API Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: c.david86@gmail.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://davidcl.fedorapeople.org/jogl2.spec SRPM URL: http://davidcl.fedorapeople.org/jogl2-2.0-0.1.rc10.fc17.src.rpm Fedora Account System Username: davidcl
Description:
The JOGL project hosts the development version of the Java Binding for the OpenGL API (JSR-231), and is designed to provide hardware-supported 3D graphics to applications written in Java. JOGL provides full access to the APIs in the OpenGL 2.0 specification as well as nearly all vendor extensions, and integrates with the AWT and Swing widget sets. It is part of a suite of open-source technologies initiated by the Game Technology Group at Sun Microsystems.
https://bugzilla.redhat.com/show_bug.cgi?id=858381
Clément DAVID c.david86@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |652183 (FE-JAVASIG)
https://bugzilla.redhat.com/show_bug.cgi?id=858381
Clément DAVID c.david86@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Depends On| |858380
https://bugzilla.redhat.com/show_bug.cgi?id=858381
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |puntogil@libero.it
--- Comment #1 from gil cattaneo puntogil@libero.it --- hi can you add a link also in %_jnidir (/usr/lib*/java), and rebuild the package using also the task maven.prepare.pom maven.prepare.native.pom, and install the maven metadta files?
for example ant -f make/maven-common.xml -Dbuild=$PWD/build -Dmaven.artifacts.version=%{namedversion}" maven.prepare.pom maven.prepare.native.pom
for javadoc ant -f make/build.xml \ -Dantlr.jar=$(build-classpath antlr) \ -Djavadoc.link=%{_javadocdir}/java \ -Dgluegen.link=%{_javadocdir}/gluegen2 \ javadoc.all thanks regard
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #2 from gil cattaneo puntogil@libero.it --- ops namedversion is equal at 2.0-rc10
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #3 from Clément DAVID c.david86@gmail.com --- Spec URL: http://davidcl.fedorapeople.org/jogl2.spec SRPM URL: http://davidcl.fedorapeople.org/jogl2-2.0-0.2.rc10.fc17.src.rpm Fedora Account System Username: davidcl
Hi, I updated to provide all javadocs and doc. Even if gluegen2 provide a maven target, jogl2 does not (may be in a future rc).
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #4 from gil cattaneo puntogil@libero.it --- hi Clément, can use this pom instead ?
in jogl-v2.0-rc10/make/pom.xml
but in this one you should fix - change
<version>this pom is a stub, just to resolve dependencies</version> with <version>2.0-rc10</version>
and <dependencies> <dependency> <artifactId>gluegen-rt-natives</artifactId> <groupId>org.jogamp.gluegen</groupId> <version>[1.0-beta07-SNAPSHOT,)</version> <!--TODO:exclude snapshot versions from this range--> <classifier>${envClassifier}-${os.arch}</classifier> <!--Can't use ${os.name} - it's uppercase--> </dependency> <dependency> <artifactId>gluegen-cpptasks</artifactId> <groupId>org.jogamp.gluegen</groupId> <version>[1.0-beta07-SNAPSHOT,)</version> <!--TODO:exclude snapshot versions from this range--> </dependency> </dependencies>
with
<dependencies> <dependency> <artifactId>gluegen-rt</artifactId> <groupId>org.jogamp.gluegen</groupId> <version>2.0-rc10</version> </dependency> <dependency> <artifactId>cpptasks</artifactId> <groupId>ant-contrib</groupId> <version>1.0b5</version> <scope>system</scope> <systemPath>${_javadir}/cpptasks.jar</systemPath> </dependency> </dependencies>
(cpptasks package dont provides maven pom and depmap, this is a workaround and temporarily fix the problem)
and when create the depmap add also this please
%add_maven_depmap JPP-%{name}.pom %{name}.jar -a "org.jogamp.jogl:jogl-all"
thanks
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #5 from Clément DAVID c.david86@gmail.com --- Spec URL: http://davidcl.fedorapeople.org/jogl2.spec SRPM URL: http://davidcl.fedorapeople.org/jogl2-2.0-0.3.rc10.fc17.src.rpm Fedora Account System Username: davidcl
Updated, the pom is provided as a source and I also added a patch to remove the Xinerama loading log.
https://bugzilla.redhat.com/show_bug.cgi?id=858381
Clément DAVID c.david86@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Alias| |JOGL2
https://bugzilla.redhat.com/show_bug.cgi?id=858381
Clément DAVID c.david86@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |811661
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #6 from gil cattaneo puntogil@libero.it --- hi Clément you should add BuildRequires: p7zip in spec file thanks regards
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #7 from Clément DAVID c.david86@gmail.com --- Spec URL: http://davidcl.fedorapeople.org/jogl2.spec SRPM URL: http://davidcl.fedorapeople.org/jogl2-2.0-0.4.rc10.fc17.src.rpm koji URL: http://koji.fedoraproject.org/koji/taskinfo?taskID=4561911 Fedora Account System Username: davidcl
Updated, a mock (through koji) build now works.
https://bugzilla.redhat.com/show_bug.cgi?id=858381
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |puntogil@libero.it Flags| |fedora-review?
--- Comment #8 from gil cattaneo puntogil@libero.it --- I am taking this review.
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #9 from gil cattaneo puntogil@libero.it ---
Package Review ==============
Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [ ] = Manual review needed
Issues: ======= [!]: Fully versioned dependency in subpackages, if present. Note: Missing: 'Requires: %%{name} =' in: %package doc See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find licenses in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShor...
===== MUST items =====
C/C++: [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in %package javadoc, %package doc [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Large documentation files are in a -doc subpackage, if required. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find licenses in rpm(s) [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [-]: Package consistently uses macro is (instead of hard-coded directory names). [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [-]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Useful -debuginfo package or justification otherwise.
Java: [x]: If source tarball includes bundled jar/class files these need to be removed prior to building [x]: Packages have proper BuildRequires/Requires on jpackage-utils [!]: Fully versioned dependency in subpackages, if present. Note: Missing: 'Requires: %%{name} =' in: %package doc [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven: [x]: Pom files have correct add_maven_depmap call Note: Some add_maven_depmap calls found. Please check if they are correct [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (jogl-v2.0-rc10.tar.7z) [x]: SourceX is a working URL. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define. Note: %define pkg_release 0.%{baserelease}.%{pkg_rc}%{?dist} %define pkg_release %{baserelease}%{?dist}
Java: [x]: Package has BuildArch: noarch (if possible) [x]: Package uses upstream build method (ant/maven/etc.)
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: jogl2-javadoc-2.0-0.4.rc10.fc19.noarch.rpm jogl2-2.0-0.4.rc10.fc19.i686.rpm jogl2-doc-2.0-0.4.rc10.fc19.noarch.rpm jogl2-2.0-0.4.rc10.fc19.src.rpm jogl2-debuginfo-2.0-0.4.rc10.fc19.i686.rpm 5 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint jogl2-doc jogl2-debuginfo jogl2-javadoc jogl2 4 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:'
Requires -------- jogl2-javadoc-2.0-0.4.rc10.fc19.noarch.rpm (rpmlib, GLIBC filtered):
jpackage-utils
jogl2-2.0-0.4.rc10.fc19.i686.rpm (rpmlib, GLIBC filtered):
gluegen2 java >= 1:1.6.0 jpackage-utils libX11.so.6 libXrandr.so.2 libXrender.so.1 libXxf86vm.so.1 libc.so.6 libjawt.so libjawt.so(SUNWprivate_1.1) rtld(GNU_HASH)
jogl2-doc-2.0-0.4.rc10.fc19.noarch.rpm (rpmlib, GLIBC filtered):
jogl2-debuginfo-2.0-0.4.rc10.fc19.i686.rpm (rpmlib, GLIBC filtered):
Provides -------- jogl2-javadoc-2.0-0.4.rc10.fc19.noarch.rpm:
jogl2-javadoc = 2.0-0.4.rc10.fc19
jogl2-2.0-0.4.rc10.fc19.i686.rpm:
jogl2 = 2.0-0.4.rc10.fc19 jogl2(x86-32) = 2.0-0.4.rc10.fc19 libjogl_cg.so libjogl_desktop.so libjogl_mobile.so libnativewindow_awt.so libnativewindow_x11.so libnewt.so mvn(org.jogamp.jogl:jogl) = 2.0 mvn(org.jogamp.jogl:jogl-all) = 2.0
jogl2-doc-2.0-0.4.rc10.fc19.noarch.rpm:
jogl2-doc = 2.0-0.4.rc10.fc19
jogl2-debuginfo-2.0-0.4.rc10.fc19.i686.rpm:
jogl2-debuginfo = 2.0-0.4.rc10.fc19 jogl2-debuginfo(x86-32) = 2.0-0.4.rc10.fc19
Unversioned so-files -------------------- jogl2-2.0-0.4.rc10.fc19.i686.rpm: /usr/lib/jogl2/libjogl_cg.so jogl2-2.0-0.4.rc10.fc19.i686.rpm: /usr/lib/jogl2/libjogl_desktop.so jogl2-2.0-0.4.rc10.fc19.i686.rpm: /usr/lib/jogl2/libjogl_mobile.so jogl2-2.0-0.4.rc10.fc19.i686.rpm: /usr/lib/jogl2/libnativewindow_awt.so jogl2-2.0-0.4.rc10.fc19.i686.rpm: /usr/lib/jogl2/libnativewindow_x11.so jogl2-2.0-0.4.rc10.fc19.i686.rpm: /usr/lib/jogl2/libnewt.so
MD5-sum check ------------- http://jogamp.org/deployment/jogamp-current/archive/Sources/jogl-v2.0-rc10.t... : CHECKSUM(SHA256) this package : aebf96e4aaed8f59e2acf6229326563d427176a2e791daa71fe235095606d66d CHECKSUM(SHA256) upstream package : aebf96e4aaed8f59e2acf6229326563d427176a2e791daa71fe235095606d66d
https://bugzilla.redhat.com/show_bug.cgi?id=858381
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? | Flags| |fedora-review+
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #10 from gil cattaneo puntogil@libero.it --- Issues: ======= [!]: Fully versioned dependency in subpackages, if present. Note: Missing: 'Requires: %%{name} =' in: %package doc See: http://fedoraproject.org/wiki/Packaging/Guidelines#RequiringBasePackage [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find licenses in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShor...
[!]: Dist tag is present.
[!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (jogl-v2.0-rc10.tar.7z)
[!]: Spec use %global instead of %define. Note: %define pkg_release 0.%{baserelease}.%{pkg_rc}%{?dist} %define pkg_release %{baserelease}%{?dist}
should be simply %global pkg_release 0.%{baserelease}.%{pkg_rc}%{?dist}
please, can you check,also, if in gluegen2 package is present gluegen.cpptasks.detect.os
https://bugzilla.redhat.com/show_bug.cgi?id=858381
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #11 from Clément DAVID c.david86@gmail.com --- Hi gil, thanks for taking the review,
[!]: Fully versioned dependency in subpackages, if present. Note: Missing: 'Requires: %%{name} =' in: %package doc
Fixed to avoid outdated javadoc / doc documentation on update.
in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find licenses in rpm(s)
See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. See: http://fedoraproject.org/wiki/Packaging/ LicensingGuidelines#ValidLicenseShortNames
I checked the licenses, the LICENSE.txt file is provided on each package and document licenses usages. I updated the spec to list them all.
[!]: Dist tag is present.
I did not understand this point, I used the {?dist} macro on the release field.
[!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (jogl-v2.0-rc10.tar.7z)
I prefer keeping the same source package as upstream. The package name has been changed to provide both jogl and jogl2 on the same system.
[!]: Spec use %global instead of %define. Note: %define pkg_release 0.%{baserelease}.%{pkg_rc}%{?dist} %define pkg_release %{baserelease}%{?dist} should be simply %global pkg_release 0.%{baserelease}.%{pkg_rc}%{?dist}
Fixed.
please, can you check,also, if in gluegen2 package is present gluegen.cpptasks.detect.os
Yes /usr/share/gluegen2/make/gluegen-cpptasks-base.xml:700
Please note that for these minor spec modification I did not bump the version.
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #12 from gil cattaneo puntogil@libero.it --- hi Clément, please update the source rpm. there are still the same problems discussed above thanks regards
https://bugzilla.redhat.com/show_bug.cgi?id=858381
Clément DAVID c.david86@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW
--- Comment #13 from Clément DAVID c.david86@gmail.com --- Updated, sorry to miss that.
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #14 from gil cattaneo puntogil@libero.it --- hi,
[!]: Dist tag is present.
if use
%if 0%{?pkg_rc:1} %global pkg_release 0.%{baserelease}.%{pkg_rc}%{?dist} %else %global pkg_release %{baserelease}%{?dist} %endif
pkg_release is %{baserelease}%{?dist} (equal to 2.0-4) and not as in changelog * Fri Oct 05 2012 Clément David c.david86@gmail.com - 2.0-0.4.rc10
please correct it
Package Review ==============
Key: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated [x] = Manual review needed
Issues: ======= [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find licenses in rpm(s) See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShor...
===== MUST items =====
C/C++: [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path.
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package contains no bundled libraries. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package requires other packages for directories it uses. [x]: Package uses nothing in %doc for runtime. [x]: Package is not known to require ExcludeArch. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Fully versioned dependency in subpackages, if present. [x]: Package complies to the Packaging Guidelines [x]: Spec file lacks Packager, Vendor, PreReq tags. [x]: Large documentation files are in a -doc subpackage, if required. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find licenses in rpm(s) [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [x]: License file installed when any subpackage combination is installed. [x]: Package consistently uses macro is (instead of hard-coded directory names). [-]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package is named using only allowed ASCII characters. [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: Package do not use a name that already exist [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package installs properly. [x]: Package is not relocatable. [x]: Requires correct, justified where necessary. [x]: CheckResultdir [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file is legible and written in American English. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Useful -debuginfo package or justification otherwise.
Java: [x]: If source tarball includes bundled jar/class files these need to be removed prior to building [x]: Packages have proper BuildRequires/Requires on jpackage-utils [x]: Fully versioned dependency in subpackages, if present. [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages have Requires: jpackage-utils [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink)
Maven: [x]: Pom files have correct add_maven_depmap call Note: Some add_maven_depmap calls found. Please check if they are correct [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DOES NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: If package contains pom.xml files install it (including depmaps) even when building with ant [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use %{_mavenpomdir} instead of %{_datadir}/maven2/poms
===== SHOULD items =====
Generic: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Dist tag is present. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: The placement of pkgconfig(.pc) files are correct. [x]: SourceX tarball generation or download is documented. [!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (jogl-v2.0-rc10.tar.7z) [x]: SourceX is a working URL. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define.
Java: [x]: Package has BuildArch: noarch (if possible) [x]: Package uses upstream build method (ant/maven/etc.)
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: jogl2-javadoc-2.0-0.4.rc10.fc19.noarch.rpm jogl2-2.0-0.4.rc10.fc19.i686.rpm jogl2-doc-2.0-0.4.rc10.fc19.noarch.rpm jogl2-2.0-0.4.rc10.fc19.src.rpm jogl2-debuginfo-2.0-0.4.rc10.fc19.i686.rpm 5 packages and 0 specfiles checked; 0 errors, 0 warnings.
Rpmlint (installed packages) ---------------------------- # rpmlint jogl2-doc jogl2-debuginfo jogl2-javadoc jogl2 4 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:'
Requires -------- jogl2-javadoc-2.0-0.4.rc10.fc19.noarch.rpm (rpmlib, GLIBC filtered):
jogl2 = 2.0-0.4.rc10.fc19 jpackage-utils
jogl2-2.0-0.4.rc10.fc19.i686.rpm (rpmlib, GLIBC filtered):
gluegen2 java >= 1:1.6.0 jpackage-utils libX11.so.6 libXrandr.so.2 libXrender.so.1 libXxf86vm.so.1 libc.so.6 libjawt.so libjawt.so(SUNWprivate_1.1) rtld(GNU_HASH)
jogl2-doc-2.0-0.4.rc10.fc19.noarch.rpm (rpmlib, GLIBC filtered):
jogl2 = 2.0-0.4.rc10.fc19
jogl2-debuginfo-2.0-0.4.rc10.fc19.i686.rpm (rpmlib, GLIBC filtered):
Provides -------- jogl2-javadoc-2.0-0.4.rc10.fc19.noarch.rpm:
jogl2-javadoc = 2.0-0.4.rc10.fc19
jogl2-2.0-0.4.rc10.fc19.i686.rpm:
jogl2 = 2.0-0.4.rc10.fc19 jogl2(x86-32) = 2.0-0.4.rc10.fc19 libjogl_cg.so libjogl_desktop.so libjogl_mobile.so libnativewindow_awt.so libnativewindow_x11.so libnewt.so mvn(org.jogamp.jogl:jogl) = 2.0 mvn(org.jogamp.jogl:jogl-all) = 2.0
jogl2-doc-2.0-0.4.rc10.fc19.noarch.rpm:
jogl2-doc = 2.0-0.4.rc10.fc19
jogl2-debuginfo-2.0-0.4.rc10.fc19.i686.rpm:
jogl2-debuginfo = 2.0-0.4.rc10.fc19 jogl2-debuginfo(x86-32) = 2.0-0.4.rc10.fc19
Unversioned so-files -------------------- jogl2-2.0-0.4.rc10.fc19.i686.rpm: /usr/lib/jogl2/libjogl_cg.so jogl2-2.0-0.4.rc10.fc19.i686.rpm: /usr/lib/jogl2/libjogl_desktop.so jogl2-2.0-0.4.rc10.fc19.i686.rpm: /usr/lib/jogl2/libjogl_mobile.so jogl2-2.0-0.4.rc10.fc19.i686.rpm: /usr/lib/jogl2/libnativewindow_awt.so jogl2-2.0-0.4.rc10.fc19.i686.rpm: /usr/lib/jogl2/libnativewindow_x11.so jogl2-2.0-0.4.rc10.fc19.i686.rpm: /usr/lib/jogl2/libnewt.so
MD5-sum check ------------- http://jogamp.org/deployment/jogamp-current/archive/Sources/jogl-v2.0-rc10.t... : CHECKSUM(SHA256) this package : aebf96e4aaed8f59e2acf6229326563d427176a2e791daa71fe235095606d66d CHECKSUM(SHA256) upstream package : aebf96e4aaed8f59e2acf6229326563d427176a2e791daa71fe235095606d66d
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #15 from Clément DAVID c.david86@gmail.com --- Hi gil,
I update the spec and srpm file to fix the %{?dist} issue.
Issues: =======
in its own file, then that file, containing the text of the license(s) for the package is included in %doc. Note: Cannot find licenses in rpm(s)
See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text
LICENSE.txt is present as %doc in the main package and sub-packages
[!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#ValidLicenseShor...
A comment is present which clarify this thing accordingly to the guidelines.
[!]: SourceX / PatchY prefixed with %{name}. Note: Source0 (jogl-v2.0-rc10.tar.7z)
Renamed to provide both jogl and jogl2 packages.
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #16 from gil cattaneo puntogil@libero.it --- hi Clément, please update the source rpm. there are still the same problems discussed above thanks regards
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #17 from Clément DAVID c.david86@gmail.com --- Spec URL: http://davidcl.fedorapeople.org/jogl2.spec SRPM URL: http://davidcl.fedorapeople.org/jogl2-2.0-0.4.rc10.fc17.src.rpm Fedora Account System Username: davidcl
Updated accordingly
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #18 from gil cattaneo puntogil@libero.it --- APPROVED
https://bugzilla.redhat.com/show_bug.cgi?id=858381
Clément DAVID c.david86@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #19 from Clément DAVID c.david86@gmail.com --- New Package SCM Request ======================= Package Name: jogl2 Short Description: Java bindings for the OpenGL API Owners: davidcl Branches: f17 f18 el6 InitialCC: java-sig
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #20 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=858381
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #21 from Fedora Update System updates@fedoraproject.org --- jogl2-2.0-0.4.rc10.fc18 has been submitted as an update for Fedora 18. https://admin.fedoraproject.org/updates/jogl2-2.0-0.4.rc10.fc18
https://bugzilla.redhat.com/show_bug.cgi?id=858381
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #22 from Fedora Update System updates@fedoraproject.org --- jogl2-2.0-0.4.rc10.fc18 has been pushed to the Fedora 18 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=858381
--- Comment #23 from Fedora Update System updates@fedoraproject.org --- jogl2-2.0-0.4.rc10.fc17 has been submitted as an update for Fedora 17. https://admin.fedoraproject.org/updates/jogl2-2.0-0.4.rc10.fc17
https://bugzilla.redhat.com/show_bug.cgi?id=858381
gil cattaneo puntogil@libero.it changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks|652183 (FE-JAVASIG) |
https://bugzilla.redhat.com/show_bug.cgi?id=858381
Clément DAVID c.david86@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2012-10-25 09:34:11
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=858381
Bug 858381 depends on bug 858380, which changed state.
Bug 858380 Summary: Review Request: Gluegen2 - Java/JNI glue code generator to call out to ANSI C https://bugzilla.redhat.com/show_bug.cgi?id=858380
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |CURRENTRELEASE
package-review@lists.fedoraproject.org