https://bugzilla.redhat.com/show_bug.cgi?id=1941896 --- Comment #1 from Rémi Lauzier <remilauzier(a)protonmail.com&gt; --- If you need any modification of the .spec or something else you can contact me. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Robert-André Mauchin 🐧 <zebob.m(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m(a)gmail.com Doc Type|--- |If docs needed, set a value --- Comment #2 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com&gt; --- - The LICENSE file must be installed with %license in %files %files -n %{crate} %doc README.md %license LICENSE %{_bindir}/rudo %endif […] %files devel %doc README.md %license LICENSE %{cargo_registry}/%{crate}-%{version_no_tilde}/ - The configuration files are not installed? You need to BuildRequires: pam-devel and install the pam file conf/rudo to %{buildroot}%{_sysconfdir}/pam.d/rudo %config(noreplace) %{_sysconfdir}/pam.d/rudo A default configuration file should probably be installed with wheel permission enabled. If this is auto generated at startup, I'd still recommend to add %ghost directive so the file is taken care of when uninstalling. %ghost %{_sysconfdir}/rudo.conf - You should set suid in %files: %attr(4755,root,root) %{_bindir}/rudo - The documentation for the config file is not very clear. Consider writing a man page. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 --- Comment #4 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com&gt; --- - You can do: %generate_buildrequires %cargo_generate_buildrequires echo "pam-devel" - You need to open review requests for you dependencies too. Also you may need to patch some Cargo.toml to build the packages. For example, in your pam-sys build you have: No matching package to install: 'crate(bindgen/default) = 0.53.2' But Fedora is at rust-bindgen 0.56.0. So you need to use 'rust2rpm -p' to patch the Cargo.toml. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Rémi Lauzier <remilauzier(a)protonmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1943989 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1943989 [Bug 1943989] Review Request: rust-pam-sys - a library to access pam with rust code -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Bug 1941896 depends on bug 1943989, which changed state. Bug 1943989 Summary: Review Request: rust-pam-sys - a library to access pam with rust code https://bugzilla.redhat.com/show_bug.cgi?id=1943989 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |CLOSED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Rémi Lauzier <remilauzier(a)protonmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1944398 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1944398 [Bug 1944398] Review Request: rust-cstr-argument - A trait for converting function arguments to null terminated strings -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Rémi Lauzier <remilauzier(a)protonmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1944408 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1944408 [Bug 1944408] Review Request: rust-libsystemd-sys - FFI bindings to libsystemd and libelogind -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Rémi Lauzier <remilauzier(a)protonmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Depends On| |1944422 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1944422 [Bug 1944422] Review Request: rust-systemd - A rust interface to libsystemd/libelogind provided APIs -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 --- Comment #6 from Rémi Lauzier <remilauzier(a)protonmail.com&gt; --- Hi! I manage to put review for all dependency of rudo and to compile them in my copr. https://copr.fedorainfracloud.org/coprs/remilauzier/rudo/ For now i manage to compile rudo but the config file appear to install as directory even if it is a file in the final rpm. Thanks for your time. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 --- Comment #8 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com&gt; --- Sent you a PR. Use go-md2man as indicated in the commit log. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Robert-André Mauchin 🐧 <zebob.m(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com Flags| |fedora-review? --- Comment #10 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com&gt; --- - /etc → %{_sysconfdir} - Use install -p to keep timestamps - Why are you doing this: cp conf/rudo ~/ cp conf/rudo.conf ~/ cp man/rudo.1 ~/ cp man/rudo.conf.5 ~/ instead of just installing them from their current location? mkdir -p %{buildroot}%{_sysconfdir} mkdir -p %{buildroot}%{_sysconfdir}/pam.d/ mkdir -p %{buildroot}%{_mandir}/man1 mkdir -p %{buildroot}%{_mandir}/man5 install -pm 0640 cp conf/rudo.conf %{buildroot}%{_sysconfdir}/rudo.conf install -pm 0644 conf/rudo %{buildroot}%{_sysconfdir}/pam.d/rudo install -pm 0644 man/rudo.1 %{buildroot}%{_mandir}/man1/rudo.1 install -pm 0644 man/rudo.conf.5 %{buildroot}%{_mandir}/man5/rudo.conf.5 - This is not needed anymore: echo "pam-devel" echo "systemd-devel" pam-devel is implied by the rust-pam-sys dep and systemd-devel by the rust-libsystemd-sys dep - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Robert-André Mauchin 🐧 <zebob.m(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #12 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com&gt; --- I don't think this is necessary. Package approved. You still need to find a sponsor. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 --- Comment #14 from Tomas Hrcka <thrcka(a)redhat.com&gt; --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-rudo -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Bug 1941896 depends on bug 1944398, which changed state. Bug 1944398 Summary: Review Request: rust-cstr-argument - A trait for converting function arguments to null terminated strings https://bugzilla.redhat.com/show_bug.cgi?id=1944398 What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Bug 1941896 depends on bug 1944403, which changed state. Bug 1944403 Summary: Review Request: rust-enum-repr - Derive enum repr conversions compatible with type aliases. https://bugzilla.redhat.com/show_bug.cgi?id=1944403 What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Bug 1941896 depends on bug 1944422, which changed state. Bug 1944422 Summary: Review Request: rust-systemd - A rust interface to libsystemd/libelogind provided APIs https://bugzilla.redhat.com/show_bug.cgi?id=1944422 What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |ERRATA -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1941896 Rémi Lauzier <remilauzier(a)protonmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|POST |CLOSED Resolution|--- |RAWHIDE Last Closed| |2021-07-11 05:07:25 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component