Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742389 --- Comment #2 from Mohamed El Morabity <pikachu.2014(a)gmail.com&gt; 2011-09-30 15:23:10 EDT --- I'm planning to submit also the Light themes from Ubuntu, which requires this GTK engine , as well as the corresponding icons (the packages are already ready, see in http://melmorabity.fedorapeople.org/packages/). The engine is delivered "as if", and will be packaged "as if". -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742389 --- Comment #4 from Mohamed El Morabity <pikachu.2014(a)gmail.com&gt; 2011-10-03 14:33:35 EDT --- (In reply to comment #3) According to http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GTK.2B_modules , these scriplets are needed. Without them, it doesn't work. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742389 --- Comment #6 from Mohamed El Morabity <pikachu.2014(a)gmail.com&gt; 2011-10-03 16:39:37 EDT --- And you're absolutely right, sorry for the mistake. I probably made something wrong when I tried the engine without the scriptlets. It works without anyway. Here is the fixed version: http://melmorabity.fedorapeople.org/packages/gtk-unico-engine/gtk-unico-e... http://melmorabity.fedorapeople.org/packages/gtk-unico-engine/gtk-unico-e... -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742389 Mario Blättermann <mariobl(a)freenet.de&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #7 from Mario Blättermann <mariobl(a)freenet.de&gt; 2011-10-04 14:07:14 EDT --- Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3402806 $ rpmlint -i -v *gtk-unico-engine.src: I: checking gtk-unico-engine.src: W: spelling-error Summary(en_US) theming -> teeming, hemming, emitting The value of this tag appears to be misspelled. Please double-check. gtk-unico-engine.src: W: spelling-error %description -l en_US theming -> teeming, hemming, emitting The value of this tag appears to be misspelled. Please double-check. gtk-unico-engine.src: I: checking-url https://launchpad.net/unico/ (timeout 10 seconds) gtk-unico-engine.src: I: checking-url http://launchpad.net/unico/1.0/1.0.1/+download/unico-1.0.1.tar.gz (timeout 10 seconds) gtk-unico-engine.i686: I: checking gtk-unico-engine.i686: W: spelling-error Summary(en_US) theming -> teeming, hemming, emitting The value of this tag appears to be misspelled. Please double-check. gtk-unico-engine.i686: W: spelling-error %description -l en_US theming -> teeming, hemming, emitting The value of this tag appears to be misspelled. Please double-check. gtk-unico-engine.i686: I: checking-url https://launchpad.net/unico/ (timeout 10 seconds) gtk-unico-engine.x86_64: I: checking gtk-unico-engine.x86_64: W: spelling-error Summary(en_US) theming -> teeming, hemming, emitting The value of this tag appears to be misspelled. Please double-check. gtk-unico-engine.x86_64: W: spelling-error %description -l en_US theming -> teeming, hemming, emitting The value of this tag appears to be misspelled. Please double-check. gtk-unico-engine.x86_64: I: checking-url https://launchpad.net/unico/ (timeout 10 seconds) gtk-unico-engine-debuginfo.i686: I: checking gtk-unico-engine-debuginfo.i686: I: checking-url https://launchpad.net/unico/ (timeout 10 seconds) gtk-unico-engine-debuginfo.x86_64: I: checking gtk-unico-engine-debuginfo.x86_64: I: checking-url https://launchpad.net/unico/ (timeout 10 seconds) gtk-unico-engine.spec: I: checking-url http://launchpad.net/unico/1.0/1.0.1/+download/unico-1.0.1.tar.gz (timeout 10 seconds) 5 packages and 1 specfiles checked; 0 errors, 6 warnings. Just a few ignoreable spelling errors. --------------------------------- key: [+] OK [.] OK, not applicable [X] needs work --------------------------------- [+] MUST: The package must be named according to the Package Naming Guidelines. [+] MUST: The spec file name must match the base package %{name}. [+] MUST: The package must meet the Packaging Guidelines. [+] MUST: The package must be licensed with a Fedora approved license. GPL+ or Artistic [+] MUST: The License field in the package spec file must match the actual license. [.] MUST: The file containing the text of the license(s) for the package must be included in %doc. [+] MUST: The spec file must be written in American English. [+] MUST: The spec file for the package MUST be legible. [+] MUST: The sources used to build the package must match the upstream source. $ md5sum * 1e56ff86337120dcf1b04dd443ea4b71 unico-1.0.1.tar.gz 1e56ff86337120dcf1b04dd443ea4b71 unico-1.0.1.tar.gz.packaged [+] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Succesful Koji build available. [.] MUST: If the package does not successfully compile, build or work on an architecture, ... [+] MUST: All build dependencies must be listed in BuildRequires. [.] MUST: The spec file MUST handle locales properly. [.] MUST: If a package installs files below %{_datadir}/icons, the icon cache must be updated. [.] MUST: Packages storing shared library files (not just symlinks) must call ldconfig in %post and %postun. [.] MUST: Packages must NOT bundle copies of system libraries. [.] MUST: If the package is designed to be relocatable, ... [+] MUST: A package must own all directories that it creates. [+] MUST: A Fedora package must not list a file more than once in %files. [+] MUST: Permissions on files must be set properly. [+] MUST: Packages must not provide RPM dependency information when that information is not global in nature, or are otherwise handled. [.] MUST: When filtering automatically generated RPM dependency information, the filtering system implemented by Fedora must be used. [+] MUST: Each package must consistently use macros. [+] MUST: The package must contain code, or permissable content. [.] MUST: Large documentation files must go in a -doc subpackage. [+] MUST: Files in %doc must not affect the runtime of the application. [.] MUST: Header files must be in a -devel package. [.] MUST: Static libraries must be in a -static package. [.] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), ... [.] MUST: devel packages must require the base package using a fully versioned dependency. [+] MUST: Packages must NOT contain any .la libtool archives. [.] MUST: Packages containing GUI applications must include a %{name}.desktop file [.] MUST: .desktop files must be properly installed with desktop-file-install in the %install section. [+] MUST: Packages must not own files or directories already owned by other packages. [+] MUST: All filenames in rpm packages must be valid UTF-8. [.] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream... [+] SHOULD: Timestamps of files should be preserved. [+] SHOULD: The reviewer should test that the package builds in mock. See Koji build above (which uses mock anyway) [+] SHOULD: The reviewer should test that the package functions as described. I assume the packager has tested it. Unfortunately, GTK+3 on my system is too old for that. [.] SHOULD: If scriptlets are used, those scriptlets must be sane. [.] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [.] SHOULD: pkgconfig(.pc) files should be placed in a -devel pkg. [.] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin ... [.] SHOULD: Your package should contain man pages for binaries/scripts. ---------------- PACKAGE APPROVED ---------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742389 --- Comment #9 from Mohamed El Morabity <pikachu.2014(a)gmail.com&gt; 2011-10-04 19:42:17 EDT --- Thanks for your review :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742389 --- Comment #11 from Jon Ciesla <limb(a)jcomserv.net&gt; 2011-10-04 20:10:36 EDT --- Git done (by process-git-requests). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742389 --- Comment #12 from Fedora Update System <updates(a)fedoraproject.org&gt; 2011-10-05 03:55:05 EDT --- gtk-unico-engine-1.0.1-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/gtk-unico-engine-1.0.1-2.fc16 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=742389 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |gtk-unico-engine-1.0.1-2.fc | |16 Resolution| |ERRATA Last Closed| |2011-10-13 00:36:00 --- Comment #14 from Fedora Update System <updates(a)fedoraproject.org&gt; 2011-10-13 00:36:00 EDT --- gtk-unico-engine-1.0.1-2.fc16 has been pushed to the Fedora 16 stable repository. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

https://bugzilla.redhat.com/show_bug.cgi?id=742389 --- Comment #16 from Jon Ciesla <limburgher(a)gmail.com&gt; --- Comments from primary maintainer? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=742389 --- Comment #17 from Wolfgang Ulbrich <chat-to-me(a)raveit.de&gt; --- Please take a look at in comment 15 provided link. I'm not interested in maintaining packages for EPEL. But feel free to request a new epel7 branch for gtk-unico-engine and maintain it ;) PLease apply -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=742389 --- Comment #18 from Mohamed El Morabity <pikachu.2014(a)gmail.com&gt; --- Package Change Request ====================== Package Name: gtk-unico-engine New Branches: epel7 Owners: raveit65 InitialCC: -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=742389 --- Comment #19 from Jon Ciesla <limburgher(a)gmail.com&gt; --- Git done (by process-git-requests). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=742389 --- Comment #20 from Fedora Update System <updates(a)fedoraproject.org&gt; --- gtk-unico-engine-1.0.3-0.6.20140109bzr152.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/gtk-unico-engine-1.0.3-0.6.201401... -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=742389 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version|gtk-unico-engine-1.0.1-2.fc |gtk-unico-engine-1.0.3-0.6. |16 |20140109bzr152.el7 Resolution|--- |ERRATA Last Closed|2011-10-13 00:36:00 |2014-11-05 13:46:25 --- Comment #22 from Fedora Update System <updates(a)fedoraproject.org&gt; --- gtk-unico-engine-1.0.3-0.6.20140109bzr152.el7 has been pushed to the Fedora EPEL 7 stable repository. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component