[Bug 361211] New: Review Request: rubygem-actionpack - Web-flow and rendering framework putting the VC in MVC
8:51 p.m.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=361211
Summary: Review Request: rubygem-actionpack - Web-flow and
rendering framework putting the VC in MVC
Product: Fedora
Version: devel
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: medium
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: dlutter(a)redhat.com
QAContact: extras-qa(a)fedoraproject.org
CC: fedora-package-review@redhat.com,notting(a)redhat.com
Spec URL: http://people.redhat.com/dlutter/yum/spec/rubygem-actionpack.spec
SRPM URL: http://people.redhat.com/dlutter/yum/SRPMS/rubygem-actionpack-1.13.5-1.sr...
Description:
Eases web-request routing, handling, and response as a half-way front,
half-way page controller. Implemented with specific emphasis on enabling easy
unit/integration testing that doesn't require a browser.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
8:52 p.m.
New subject: [Bug 361211] Review Request: rubygem-actionpack - Web-flow and rendering framework putting the VC in MVC
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: rubygem-actionpack - Web-flow and rendering framework putting the
VC in MVC
https://bugzilla.redhat.com/show_bug.cgi?id=361211
dlutter(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
OtherBugsDependingO| |361191
nThis| |
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
10:56 a.m.
New subject: [Bug 361211] Review Request: rubygem-actionpack - Web-flow and rendering framework putting the VC in MVC
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: rubygem-actionpack - Web-flow and rendering framework putting the
VC in MVC
https://bugzilla.redhat.com/show_bug.cgi?id=361211
sseago(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody(a)fedoraproject.org |sseago(a)redhat.com
Flag| |fedora-review?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
10:56 a.m.
New subject: [Bug 361211] Review Request: rubygem-actionpack - Web-flow and rendering framework putting the VC in MVC
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: rubygem-actionpack - Web-flow and rendering framework putting the
VC in MVC
https://bugzilla.redhat.com/show_bug.cgi?id=361211
------- Additional Comments From sseago(a)redhat.com 2007-11-07 11:56 EST -------
OK - Package name
OK - License info is accurate
OK - License tag is correct and licenses are approved
OK - Specfile name
OK - Specfile is legible
OK - No prebuilt binaries included
OK - PreReq not used
OK - Source md5sum matches upstream
OK - No hardcoded pathnames
OK - Package owns all the files it installs
OK - Package requires create needed unowned directories
OK - Package builds successfully on i386 and x86_64
OK - BuildRequires sufficient
OK - File permissions set properly (except for rpmlint error below)
OK - Macro usage is consistent
OK - Package is named rubygem-%{gemname}
OK - Source points to full URL of gem
OK - Package version identical with gem version
OK - Package Requires and BuildRequires rubygems
OK - Package provides rubygem(%{gemname}) = %version
OK - Package requires gem dependencies correctly
OK - %prep and %build are empty
OK - %gemdir defined properly, and gem installed into it
OK - Package owns its directories under %gemdir
OK - No arch-specific content in %{gemdir}
OK - Package is noarch
??? - BuildRoot value: not sure if this is really a problem, but it
looks like %{release} is omitted:
BuildRoot: %{_tmppath}/%{name}-%{version}-root-%(%{__id_u} -n)
vs.
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
FIX - RUNNING_UNIT_TESTS not installed as %doc
general doc question: docs are installed as doc in
%{_docdir}/%{name}-%{version} but still included as regular gem
files in %{geminstdir} -- should they be in one place or the other
but not both? Is there a clear preference (some of the other rubygem
packages -- both yours and mine include the doc in the gem, not in /usr/share/doc
FIX - rpmlint complains
E: rubygem-actionpack non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/examples/address_book_controller.rbx
0644
E: rubygem-actionpack non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/examples/blog_controller.cgi 0644
E: rubygem-actionpack non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/examples/debate_controller.cgi 0644
E: rubygem-actionpack zero-length
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/test/controller/controller_fixtures/app/controllers/admin/user_controller.rb
E: rubygem-actionpack non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/examples/address_book_controller.cgi
0644
E: rubygem-actionpack non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/examples/benchmark_with_ar.fcgi 0644
E: rubygem-actionpack non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/lib/action_controller/session/drb_server.rb
0644
E: rubygem-actionpack zero-length
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/test/controller/controller_fixtures/vendor/plugins/bad_plugin/lib/plugin_controller.rb
E: rubygem-actionpack zero-length
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/test/controller/controller_fixtures/app/controllers/user_controller.rb
E: rubygem-actionpack non-executable-script
/usr/lib/ruby/gems/1.8/gems/actionpack-1.13.5/examples/address_book_controller.fcgi
0644
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
10:17 p.m.
New subject: [Bug 361211] Review Request: rubygem-actionpack - Web-flow and rendering framework putting the VC in MVC
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: rubygem-actionpack - Web-flow and rendering framework putting the
VC in MVC
https://bugzilla.redhat.com/show_bug.cgi?id=361211
------- Additional Comments From dlutter(a)redhat.com 2007-11-13 23:17 EST -------
Fixed: buildroot.
Fixed: marked RUNNING_UNIT_TESTS as %doc (I actually picked geminstdir apart and
classified things more cleanly as %doc)
That also took care of most of the rpmlint warnings. I removed the '#!' from
drb_server.rb - the only rpmlint output is about zero-length files, which I'd
prefer to keep in there to minimize the differences between the gem and the rpm
I also removed the stuff about moving some files to _docdir - having them in
geminstdir, but marked as %doc should be clean enough.
Spec URL: http://people.redhat.com/dlutter/yum/spec/rubygem-actionpack.spec
SRPM URL:
http://people.redhat.com/dlutter/yum/SRPMS/rubygem-actionpack-1.13.5-2.sr...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
4:08 p.m.
New subject: [Bug 361211] Review Request: rubygem-actionpack - Web-flow and rendering framework putting the VC in MVC
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: rubygem-actionpack - Web-flow and rendering framework putting the
VC in MVC
https://bugzilla.redhat.com/show_bug.cgi?id=361211
sseago(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
------- Additional Comments From sseago(a)redhat.com 2007-11-14 17:08 EST -------
approved
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
1:19 p.m.
New subject: [Bug 361211] Review Request: rubygem-actionpack - Web-flow and rendering framework putting the VC in MVC
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: rubygem-actionpack - Web-flow and rendering framework putting the
VC in MVC
https://bugzilla.redhat.com/show_bug.cgi?id=361211
dlutter(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-cvs?
------- Additional Comments From dlutter(a)redhat.com 2007-11-28 14:19 EST -------
New Package CVS Request
=======================
Package Name: rubygem-actionpack
Short Description: Web-flow and rendering framework
Owners: lutter,sseago
Branches: F-7 F-8
InitialCC:
Cvsextras Commits: yes
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
5:22 p.m.
New subject: [Bug 361211] Review Request: rubygem-actionpack - Web-flow and rendering framework putting the VC in MVC
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: rubygem-actionpack - Web-flow and rendering framework putting the
VC in MVC
https://bugzilla.redhat.com/show_bug.cgi?id=361211
kevin(a)tummy.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From kevin(a)tummy.com 2007-11-28 18:22 EST -------
cvs done.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
5:49 p.m.
New subject: [Bug 361211] Review Request: rubygem-actionpack - Web-flow and rendering framework putting the VC in MVC
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.
Summary: Review Request: rubygem-actionpack - Web-flow and rendering framework putting the
VC in MVC
https://bugzilla.redhat.com/show_bug.cgi?id=361211
bugzilla(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|devel |rawhide
dlutter(a)redhat.com changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |CLOSED
Resolution| |RAWHIDE
------- Additional Comments From dlutter(a)redhat.com 2007-12-03 18:49 EST -------
Successfully imported and built.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug, or are watching someone who is.
6030
days inactive
6062
days old
package-review@lists.fedoraproject.org
8 comments
1 participants
participants (1)
-
Red Hat Bugzilla