Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: synce-sync-engine - Synce synchronization engine https://bugzilla.redhat.com/show_bug.cgi?id=428361 andreas.bierfert(a)lowlatency.de changed: What |Removed |Added ---------------------------------------------------------------------------- BugsThisDependsOn| |427526, 428360 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: synce-sync-engine - Synce synchronization engine https://bugzilla.redhat.com/show_bug.cgi?id=428361 Bug 428361 depends on bug 427526, which changed state. Bug 427526 Summary: Review Request: librtfcomp - Library for reading of compressed RTF files https://bugzilla.redhat.com/show_bug.cgi?id=427526 What |Old Value |New Value ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: synce-sync-engine - Synce synchronization engine https://bugzilla.redhat.com/show_bug.cgi?id=428361 ------- Additional Comments From panemade(a)gmail.com 2008-01-12 20:03 EST ------- koji build failed http://koji.fedoraproject.org/koji/getfile?taskID=344975&name=build.log -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: synce-sync-engine - Synce synchronization engine https://bugzilla.redhat.com/show_bug.cgi?id=428361 ------- Additional Comments From panemade(a)gmail.com 2008-01-13 05:30 EST ------- rpmlint gave me synce-sync-engine.noarch: E: explicit-lib-dependency librtfcomp-python You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. synce-sync-engine.noarch: E: explicit-lib-dependency libxml2-python You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. synce-sync-engine.noarch: E: explicit-lib-dependency libxslt-python You must let rpm find the library dependencies by itself. Do not put unneeded explicit Requires: tags. synce-sync-engine.noarch: W: incoherent-version-in-changelog 0.11.-2 0.11-2.fc9 The last entry in %changelog contains a version identifier that is not coherent with the epoch:version-release tuple of the package. synce-sync-engine.noarch: W: obsolete-not-provided libopensync-plugin-synce If a package is obsoleted by a compatible replacement, the obsoleted package must also be provided in order to provide clean upgrade paths and not cause unnecessary dependency breakage. If the obsoleting package is not a compatible replacement for the old one, leave out the provides. synce-sync-engine.noarch: E: only-non-binary-in-usr-lib There are only non binary files in /usr/lib so they should be in /usr/share. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: synce-sync-engine - Synce synchronization engine https://bugzilla.redhat.com/show_bug.cgi?id=428361 panemade(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade(a)gmail.com 2008-01-13 09:09 EST ------- Thanks. I will not go with detailed review here But do have suggestions SHOULD: 1) Source URL should be http://downloads.sourceforge.net/sourceforge/synce/sync-engine-%{version}... 2) License is GPLv2+ 3) I don't think you need => CFLAGS="$RPM_OPT_FLAGS" in %build APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: synce-sync-engine - Synce synchronization engine https://bugzilla.redhat.com/show_bug.cgi?id=428361 kevin(a)tummy.com changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+ ------- Additional Comments From kevin(a)tummy.com 2008-01-13 13:14 EST ------- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.