1:48 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1058623
Bug ID: 1058623
Summary: Review Request: perl-WebService-Linode - Perl
Interface to the Linode.com API
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: cickumqt(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: http://cicku.me/perl-WebService-Linode.spec
SRPM URL: http://cicku.me/perl-WebService-Linode-0.17-1.fc21.src.rpm
Description: This module implements the Linode.com api methods. Linode methods
have had dots replaced with underscores to generate the perl method name. All
keys and parameters have been lower cased but returned data remains otherwise
the same. For additional information see http://www.linode.com/api/ .
Fedora Account System Username: cicku
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:12 a.m.
New subject: [Bug 1058623] Review Request: perl-WebService-Linode - Perl Interface to the Linode.com API
https://bugzilla.redhat.com/show_bug.cgi?id=1058623
Christopher Meng <cickumqt(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |1058628
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1058628
[Bug 1058628] Review Request: linode-cli - Official command-line interface
to the Linode platform
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:45 a.m.
New subject: [Bug 1058623] Review Request: perl-WebService-Linode - Perl Interface to the Linode.com API
https://bugzilla.redhat.com/show_bug.cgi?id=1058623
Petr Šabata <psabata(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |psabata(a)redhat.com
Assignee|nobody(a)fedoraproject.org |psabata(a)redhat.com
Flags| |fedora-review?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:19 a.m.
New subject: [Bug 1058623] Review Request: perl-WebService-Linode - Perl Interface to the Linode.com API
https://bugzilla.redhat.com/show_bug.cgi?id=1058623
--- Comment #1 from Petr Šabata <psabata(a)redhat.com> ---
FIX: Missing the perl(Data::Dumper) BR, from lib/WebService/Linode/Base.pm:10
and t/01-domains.t:4
FIX: Remove the JSON and LWP::UserAgent from the explicit runtime deps. Those
will be picked up automatically.
TODO: Add `perl' to your BRs as it's called in the SPEC.
TODO: Package `examples' in the %doc.
NOTE: I think it'd be better to require perl(LWP::Protocol::https) instead of
the perl(Mozilla::CA) and perl(Crypt::SSLeay) combo, however I know you're just
following the upstream's recommendation. Perhaps try if the module works with
LWP::Protocol::https only and suggest the switch to upstream if you feel like
it? In my opinion it'd be a bit cleaner. Anyhow, this really isn't important
for the review and I haven't checked whether this makes any sense either :)
Just a thought.
Fix the points marked as FIX and I'll approve the package.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:45 p.m.
New subject: [Bug 1058623] Review Request: perl-WebService-Linode - Perl Interface to the Linode.com API
https://bugzilla.redhat.com/show_bug.cgi?id=1058623
--- Comment #2 from Christopher Meng <cickumqt(a)gmail.com> ---
Ignore your thought for a while ;) But I've filed an issue at upstream:
Fixed:
Spec URL: http://cicku.me/perl-WebService-Linode.spec
SRPM URL: http://cicku.me/perl-WebService-Linode-0.18-1.fc21.src.rpm
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:18 a.m.
New subject: [Bug 1058623] Review Request: perl-WebService-Linode - Perl Interface to the Linode.com API
https://bugzilla.redhat.com/show_bug.cgi?id=1058623
Petr Šabata <psabata(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Šabata <psabata(a)redhat.com> ---
Alright, approving.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:24 a.m.
New subject: [Bug 1058623] Review Request: perl-WebService-Linode - Perl Interface to the Linode.com API
https://bugzilla.redhat.com/show_bug.cgi?id=1058623
Christopher Meng <cickumqt(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-cvs?
--- Comment #4 from Christopher Meng <cickumqt(a)gmail.com> ---
(In reply to Petr Šabata from comment #3)
Alright, approving.
Upstream changed the code based on your suggestion! Bingo! ;)
New Package SCM Request
=======================
Package Name: perl-WebService-Linode
Short Description: Perl Interface to the Linode.com API
Owners: cicku
Branches: f20 el6 epel7
InitialCC: perl-sig
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:14 a.m.
New subject: [Bug 1058623] Review Request: perl-WebService-Linode - Perl Interface to the Linode.com API
https://bugzilla.redhat.com/show_bug.cgi?id=1058623
Jon Ciesla <limburgher(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-cvs? |fedora-cvs+
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:14 a.m.
New subject: [Bug 1058623] Review Request: perl-WebService-Linode - Perl Interface to the Linode.com API
https://bugzilla.redhat.com/show_bug.cgi?id=1058623
--- Comment #5 from Jon Ciesla <limburgher(a)gmail.com> ---
Git done (by process-git-requests).
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:31 a.m.
New subject: [Bug 1058623] Review Request: perl-WebService-Linode - Perl Interface to the Linode.com API
https://bugzilla.redhat.com/show_bug.cgi?id=1058623
Nick Bebout <nb(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nb(a)fedoraproject.org
--- Comment #6 from Nick Bebout <nb(a)fedoraproject.org> ---
*** Bug 1056336 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:10 a.m.
New subject: [Bug 1058623] Review Request: perl-WebService-Linode - Perl Interface to the Linode.com API
https://bugzilla.redhat.com/show_bug.cgi?id=1058623
--- Comment #7 from Petr Šabata <psabata(a)redhat.com> ---
Ping; have you pushed and built the package?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:36 a.m.
New subject: [Bug 1058623] Review Request: perl-WebService-Linode - Perl Interface to the Linode.com API
https://bugzilla.redhat.com/show_bug.cgi?id=1058623
Christopher Meng <i(a)cicku.me> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution|--- |RAWHIDE
Last Closed| |2014-07-01 11:36:25
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3612
days inactive
3766
days old
package-review@lists.fedoraproject.org
11 comments
1 participants
participants (1)
-
Red Hat Bugzilla