https://bugzilla.redhat.com/show_bug.cgi?id=1094015

--- Comment #2 from Parag AN(पराग) panemade@gmail.com --- Let me see if I can find some time here but before that I see you need sponsorship. Have you started reviewing other new packages? If yes please provide here links to your package reviews.

If you are not knowing about sponsorship process then please have a look at https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

Look for new packages at http://fedoraproject.org/PackageReviewStatus/NEW.html

you may also find following links interested to read http://fedoraproject.org/wiki/Using_Fedora_GIT

http://fedoraproject.org/wiki/Packaging_tricks

http://fedoraproject.org/wiki/How_to_create_an_RPM_package

http://fedoraproject.org/wiki/Packaging:ReviewGuidelines

http://fedoraproject.org/wiki/Package_Review_Process

https://bugzilla.redhat.com/show_bug.cgi?id=1094015

--- Comment #4 from Parag AN(पराग) panemade@gmail.com --- rpmlint on source and binary rpms gave cwtex-q-fangsong-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/cwtex-q-fangsong-fonts/license.txt cwtex-q-fonts.src:37: W: macro-in-comment %package cwtex-q-fonts.src:41: W: macro-in-comment %description cwtex-q-fonts.src:42: W: macro-in-comment %common_desc cwtex-q-fonts.src:44: W: macro-in-comment %{name} cwtex-q-fonts.src:50: W: macro-in-comment %{name} cwtex-q-fonts.src:50: W: macro-in-comment %{version} cwtex-q-fonts.src:50: W: macro-in-comment %{release} cwtex-q-fonts.src:64: W: macro-in-comment %{name} cwtex-q-fonts.src:64: W: macro-in-comment %{version} cwtex-q-fonts.src:64: W: macro-in-comment %{release} cwtex-q-fonts.src:78: W: macro-in-comment %{name} cwtex-q-fonts.src:78: W: macro-in-comment %{version} cwtex-q-fonts.src:78: W: macro-in-comment %{release} cwtex-q-fonts.src:92: W: macro-in-comment %{name} cwtex-q-fonts.src:92: W: macro-in-comment %{version} cwtex-q-fonts.src:92: W: macro-in-comment %{release} cwtex-q-fonts.src:106: W: macro-in-comment %{name} cwtex-q-fonts.src:106: W: macro-in-comment %{version} cwtex-q-fonts.src:106: W: macro-in-comment %{release} cwtex-q-fonts.src:159: W: macro-in-comment %files cwtex-q-fonts.src:160: W: macro-in-comment %defattr cwtex-q-fonts.src:161: W: macro-in-comment %doc cwtex-q-fonts.src: W: invalid-url Source0: cwtex-q-fonts-v02-1.tar.xz cwtex-q-hei-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/cwtex-q-hei-fonts/license.txt cwtex-q-kai-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/cwtex-q-kai-fonts/license.txt cwtex-q-ming-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/cwtex-q-ming-fonts/license.txt cwtex-q-yuan-fonts.noarch: W: spelling-error %description -l en_US yaun -> yuan, yarn, faun cwtex-q-yuan-fonts.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/cwtex-q-yuan-fonts/license.txt 6 packages and 0 specfiles checked; 0 errors, 29 warnings.

==> Fix for above issues are as 1) when writing macros in comments always add extra % so %{name} should be %%{name}

2) wrong-file-end-of-line-encoding messages, fix this by using https://fedoraproject.org/wiki/PackageMaintainers/Common_Rpmlint_Issues#wron...

3) In the changelog you don't need dist tag i.e. change 0.2-1%{?dist} to 0.2-1

4) For fedora packaging only you don't need now a) removal of buildroot in %install b) %clean section See more about this https://fedoraproject.org/wiki/PackagingGuidelines#.25clean and https://fedoraproject.org/wiki/PackagingGuidelines#BuildRoot_tag

I did not like the -common for just few (here 2) files which becomes one more dependent package for all other fonts subpackages. So, decide if you want to keep -common in your package then enable lines in comments else remove lines with comments.

Note with every update to package you should increase release tag number by 1 and submit new package for further review.

https://bugzilla.redhat.com/show_bug.cgi?id=1094015

--- Comment #6 from Parag AN(पराग) panemade@gmail.com --- A quick look into given spec link issues 1, 2 fixed issue 3 fixed but you need to add changelog entry with every update and write lines there about what has changed from last release. For the new package you can add changelog like

* Sat Jun 28 2014 Cheng-Chia Tseng pswo10680@gmail.com - 0.2-2 - fixed issues reported in package review

issue 4, you have not replied whether you want this package only for Fedora or you also want this package in el6 or epel7

remove un-necessary comment lines

https://bugzilla.redhat.com/show_bug.cgi?id=1094015

--- Comment #8 from Parag AN(पराग) panemade@gmail.com --- For EPEL packaging guidelines see http://fedoraproject.org/wiki/EPEL:Packaging

https://bugzilla.redhat.com/show_bug.cgi?id=1094015

--- Comment #10 from Parag AN(पराग) panemade@gmail.com --- same for removal of buildroot in %install in http://fedoraproject.org/wiki/EPEL:Packaging#Prepping_BuildRoot_For_.25insta...

else spec looks good but I need to check fontconfig contents. Meanwhile you can start reviewing work of other packages for your sponsorship.

https://bugzilla.redhat.com/show_bug.cgi?id=1094015

--- Comment #12 from Parag AN(पराग) panemade@gmail.com --- Hi, Do you get time to review packages?

https://bugzilla.redhat.com/show_bug.cgi?id=1094015

--- Comment #14 from Parag AN(पराग) panemade@gmail.com --- Thanks for the update on this review. We can wait.

https://bugzilla.redhat.com/show_bug.cgi?id=1094015

Cheng-Chia Tseng pswo10680@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(pswo10680@gmail.c | |om) |

--- Comment #16 from Cheng-Chia Tseng pswo10680@gmail.com --- I find I don't have much time working on packaging in this period. :(

The situation is that we, the community in Taiwan, don't have people working on packaging here. I would like to help with this, so I am translating and learning How to create an RPM package on wiki now to promote RPM packaging in these days. [1]

I will apply for sponsoring in the future after my review some packages. Sorry for the long-time-delay. ;P

[1] https://fedoraproject.org/wiki/How_to_create_an_RPM_package/zh-tw

https://bugzilla.redhat.com/show_bug.cgi?id=1094015

--- Comment #18 from Cheng-Chia Tseng pswo10680@gmail.com --- Thank you very much! :)

https://bugzilla.redhat.com/show_bug.cgi?id=1094015

--- Comment #20 from Cheng-Chia Tseng pswo10680@gmail.com --- Cool! You guys are so kind!

https://bugzilla.redhat.com/show_bug.cgi?id=1094015

Cheng-Chia Tseng pswo10680@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(pswo10680@gmail.c | |om) |

--- Comment #22 from Cheng-Chia Tseng pswo10680@gmail.com --- I'm sorry that I got a new job that taking about all of my time and even have to work on Saturday until noon.

I have to admit that I rarely have time to do work on package reviews, so I won't apply for sponsoring in next 2 years. I am going to remove the FE-NEEDSPONSOR tag.

However, I will update this package to catch up the new upstream version in next 2 weeks, and keep refreshing this font package. I think that is what I can do now in this period. Thanks for notifying me! :)

https://bugzilla.redhat.com/show_bug.cgi?id=1094015

--- Comment #23 from Cheng-Chia Tseng pswo10680@gmail.com --- Hi, I am working on 0.4 version today, and I will upload the spec and SRPM tomorrow.

As for the sponsorship, I find I don't have much free time working on packaging after my new job since August. Maybe I will apply that after being used to my new job and having more free time. :P

https://bugzilla.redhat.com/show_bug.cgi?id=1094015

Robert-André Mauchin zebob.m@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |zebob.m@gmail.com Blocks| |177841 (FE-NEEDSPONSOR)

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=177841 [Bug 177841] Tracker: Review requests from new Fedora packagers who need a sponsor