[Bug 835062] New: Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README - package-review

List overview All Threads
Download

newer

[Bug 835062] New: Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README

older

[Bug 835804] New: Review Request:...

[Bug 818629] New: Review Request:...

Red Hat Bugzilla

25 Jun 2012 25 Jun '12

12:55 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=835062

Bug ID: 835062 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Depends On: 835028, 835051 Priority: unspecified CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: jplesnik@redhat.com Type: Bug Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora

Spec URL: http://jplesnik.fedorapeople.org/perl-Module-Install-ReadmeFromPod/perl-Modu... SRPM URL: http://jplesnik.fedorapeople.org/perl-Module-Install-ReadmeFromPod/perl-Modu... Description: Module::Install::ReadmeFromPod is a Module::Install extension that generates a README file automatically from an indicated file containing POD, whenever the author runs Makefile.PL. Several output formats are supported: plain-text, HTML, PDF or manpage.

Fedora Account System Username: jplesnik

-- You are receiving this mail because: You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

27 Jun 27 Jun

8:21 a.m.

New subject: [Bug 835062] Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README

https://bugzilla.redhat.com/show_bug.cgi?id=835062

Jitka Plesnikova jplesnik@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |835804

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:27 p.m.

New subject: [Bug 835062] Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README

https://bugzilla.redhat.com/show_bug.cgi?id=835062

Bug 835062 depends on bug 835028, which changed state.

Bug 835028 Summary: Review Request: perl-pod2pdf - Converts Pod to PDF format https://bugzilla.redhat.com/show_bug.cgi?id=835028

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

28 Jun 28 Jun

3:40 p.m.

New subject: [Bug 835062] Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README

https://bugzilla.redhat.com/show_bug.cgi?id=835062

Bug 835062 depends on bug 835051, which changed state.

Bug 835051 Summary: Review Request: perl-Module-Install-AutoLicense - Module::Install extension to automatically generate LICENSE files https://bugzilla.redhat.com/show_bug.cgi?id=835051

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

12 Sep 12 Sep

12:25 p.m.

New subject: [Bug 835062] Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README

https://bugzilla.redhat.com/show_bug.cgi?id=835062

Petr Pisar ppisar@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

1:02 p.m.

New subject: [Bug 835062] Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README

https://bugzilla.redhat.com/show_bug.cgi?id=835062

Petr Pisar ppisar@redhat.com changed:

--- Comment #1 from Petr Pisar ppisar@redhat.com --- Source tar ball is original (verified from http://search.cpan.org/CPAN/authors/id/B/BI/BINGOS/Module-Install-ReadmeFromPod-0.18.tar.gz, SHA-256: a905bf3699af2c6727991634d5ae004d64b8e9279ad01eb696d8b8bbe571bdfb). Ok. Source0 and URL are usable. Ok. Summary verified from lib/Module/Install/ReadmeFromPod.pm. Ok. Description verified from lib/Module/Install/ReadmeFromPod.pm. Ok. License verified from lib/Module/Install/ReadmeFromPod.pm and LICENSE. Ok. No XS code, noarch BuildArch is Ok.

TODO: Build-require `perl(lib)' (Makefile.PL:2). TODO: Remove useless build-require `perl(ExtUtils::MakeMaker)'.

TODO: I recommend to drop `perl(App:pod2pdf)' from dependencies. The package is properly evaluated and it pulls in a lot packages which are not needed otherwise.

TODO: Remove cleaning empty directories from %install section. This is default now.

All tests pass. Ok.

$ rpmlint perl-Module-Install-ReadmeFromPod.spec ../SRPMS/perl-Module-Install-ReadmeFromPod-0.18-1.fc19.src.rpm ../RPMS/noarch/perl-Module-Install-ReadmeFromPod-0.18-1.fc19.noarch.rpm perl-Module-Install-ReadmeFromPod.src: W: spelling-error %description -l en_US manpage -> manage, man page, man-page perl-Module-Install-ReadmeFromPod.noarch: W: spelling-error %description -l en_US manpage -> manage, man page, man-page 2 packages and 1 specfiles checked; 0 errors, 2 warnings.

TODO: Write the `manpage' as `manual page' in the description.

$ rpm -q -lv -p ../RPMS/noarch/perl-Module-Install-ReadmeFromPod-0.18-1.fc19.noarch.rpm drwxr-xr-x 2 root root 0 Sep 12 13:53 /usr/share/doc/perl-Module-Install-ReadmeFromPod-0.18 -rw-r--r-- 1 root root 6814 Feb 25 2012 /usr/share/doc/perl-Module-Install-ReadmeFromPod-0.18/Changes -rw-r--r-- 1 root root 18353 Sep 12 13:52 /usr/share/doc/perl-Module-Install-ReadmeFromPod-0.18/LICENSE drwxr-xr-x 2 root root 0 Feb 25 2012 /usr/share/doc/perl-Module-Install-ReadmeFromPod-0.18/tools -rw-r--r-- 1 root root 2299 Feb 6 2012 /usr/share/doc/perl-Module-Install-ReadmeFromPod-0.18/tools/git-log.pl -rw-r--r-- 1 root root 3109 Sep 12 13:52 /usr/share/man/man3/Module::Install::ReadmeFromPod.3pm.gz drwxr-xr-x 2 root root 0 Sep 12 13:52 /usr/share/perl5/vendor_perl/Module drwxr-xr-x 2 root root 0 Sep 12 13:52 /usr/share/perl5/vendor_perl/Module/Install -rw-r--r-- 1 root root 6356 Feb 25 2012 /usr/share/perl5/vendor_perl/Module/Install/ReadmeFromPod.pm File permissions and layout is Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Module-Install-ReadmeFromPod-0.18-1.fc19.noarch.rpm | sort | uniq -c 1 perl >= 0:5.006 1 perl(App::pod2pdf) 1 perl(base) 1 perl(:MODULE_COMPAT_5.16.1) 1 perl(Module::Install) >= 1 1 perl(Module::Install::Base) 1 perl(Pod::Html) 1 perl(Pod::Man) 1 perl(Pod::Text) >= 3.13 1 perl(strict) 1 perl(vars) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-Module-Install-ReadmeFromPod-0.18-1.fc19.noarch.rpm | sort | uniq -c 1 perl(Module::Install::ReadmeFromPod) = 0.18 1 perl-Module-Install-ReadmeFromPod = 0.18-1.fc19 Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Module-Install-ReadmeFromPod-0.18-1.fc19.noarch.rpm Binary dependencies resolvable. Ok.

Package builds in F19 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4477405). Ok.

Package is in line with Fedora and Perl packaging guidelines.

Please consider fixing all `TODO' items before building the package. Resolution: Package APPROVED.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:24 p.m.

New subject: [Bug 835062] Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README

https://bugzilla.redhat.com/show_bug.cgi?id=835062

Jitka Plesnikova jplesnik@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #2 from Jitka Plesnikova jplesnik@redhat.com --- New Package SCM Request ======================= Package Name: perl-Module-Install-ReadmeFromPod Short Description: Module::Install extension to automatically convert POD to a README Owners: jplesnik mmaslano ppisar psabata Branches: InitialCC: perl-sig

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

2:31 p.m.

New subject: [Bug 835062] Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README

https://bugzilla.redhat.com/show_bug.cgi?id=835062

--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

13 Sep 13 Sep

9:38 a.m.

New subject: [Bug 835062] Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README

https://bugzilla.redhat.com/show_bug.cgi?id=835062

Jitka Plesnikova jplesnik@redhat.com changed:

--- Comment #4 from Jitka Plesnikova jplesnik@redhat.com --- Thank you for the review and the repository.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

12:26 p.m.

New subject: [Bug 835062] Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README

https://bugzilla.redhat.com/show_bug.cgi?id=835062

--- Comment #5 from Jon Ciesla limburgher@gmail.com --- Already exists, no need to re-set cvs flag.

-- You are receiving this mail because: You are on the CC list for the bug.

Red Hat Bugzilla

11 Dec 11 Dec

6:17 p.m.

New subject: [Bug 835062] Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=835062

Tom "spot" Callaway tcallawa@redhat.com changed:

--- Comment #6 from Tom "spot" Callaway tcallawa@redhat.com --- Package Change Request ====================== Package Name: perl-Module-Install-ReadmeFromPod New Branches: f16 f17 f18 Owners: jplesnik mmaslano ppisar psabata InitialCC: perl-sig

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=rfGv2xuPtf&a=cc_unsubscribe

Red Hat Bugzilla

6:26 p.m.

New subject: [Bug 835062] Review Request: perl-Module-Install-ReadmeFromPod - Module::Install extension to automatically convert POD to a README

Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=835062

--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. Unsubscribe from this bug https://bugzilla.redhat.com/token.cgi?t=tsgb2apIrE&a=cc_unsubscribe

4218

Age (days ago)

4387

Last active (days ago)

package-review@lists.fedoraproject.org

11 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla