Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From tibbs@math.uh.edu 2007-10-14 23:05 EST ------- The "slight funkiness" could be problematic, because this package will only appear in the i386 repository due to the presence of ExclusiveArch:. I don't know if that's an issue for you. syslinux builds on x86_64 just fine and of course isn't applicable on ppc, sparc or alpha in any case.

At first glance, %{_libdir}/mknbi looks to be unowned. Why not just have that directory in your %files section instead of listing all of the files underneath it separately? Honestly, barring some other reason for listing everything out, your %files section could be as simple as: %files %{_libdir}/mknbi/ %{_bindir}* %{_mandir}/man1/* %doc COPYING LOG README spec.txt but of course that's up to you. Regardless of what you do, you must still own %{_libdir}/mknbi.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From eharrison@mesd.k12.or.us 2007-10-15 00:17 EST ------- directory ownership fixed & *spec have been cleaned up.

I pulled the exclusivearch & tried building it on a x86_64 box w/o joy: first32.c:1: error: CPU you selected does not support x86-64 instruction set make: *** [first32.o] Error 1

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From notting@redhat.com 2007-10-15 14:23 EST ------- What does this do that network boot support in mkinitrd doesn't?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From eharrison@mesd.k12.or.us 2007-10-15 14:43 EST ------- The NBI images are a container wrapping the vmlinuz/initramfs generated by mkinitrd. PXE can boot the files generated by mkinitrd, but Etherboot/Netboot/etc need some extra glue (and can only tftpboot 1 file, you cannot fetch separate kernel & initramfs files).

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

wtogami@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |NEEDINFO Flag| |needinfo?

------- Additional Comments From wtogami@redhat.com 2007-10-19 15:52 EST ------- http://togami.com/~warren/fedora/mknbi-1.4.4-5.fc8.src.rpm

* Fri Oct 19 2007 Warren Togami wtogami@redhat.com 1.4.4-5 - Not noarch - Fix build and make ExclusiveArch: i386 x86_64 - more cleanups

This builds i386 binaries within the x86_64 package, similar to how we package memtest86+. noarch was not a good choice for this package because it clearly contained architecture specific bytecode, and wouldn't run at all on PPC for example.

rpmlint mknbi-1.4.4-5.fc8.i386.rpm mknbi.i386: E: no-binary mknbi.i386: E: only-non-binary-in-usr-lib

No idea what these errors are about. Any ideas?

[builder1@newcaprica SRPMS]$ rpmlint mknbi-1.4.4-5.fc8.src.rpm mknbi.src:30: W: rpm-buildroot-usage %build make BUILD_ROOT="$RPM_BUILD_ROOT" PREFIX=%{_prefix}

Not harmful...

mknbi.src:43: E: hardcoded-library-path in /usr/lib/mknbi/

This is necessary due to i386 binaries in the x86_64 package.

Any objections to approving this? Any other suggestions for improvement?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From pertusus@free.fr 2007-10-19 20:45 EST ------- (In reply to comment #8)

Maybe %attr(-,root,root) /usr/lib/mknbi/ could be instead %{_prefix}/lib/mknbi/

[builder1@newcaprica SRPMS]$ rpmlint mknbi-1.4.4-5.fc8.src.rpm mknbi.src:30: W: rpm-buildroot-usage %build make BUILD_ROOT="$RPM_BUILD_ROOT" PREFIX=%{_prefix}

Not harmful...

This should be fixed.

Also you could do something along make BUILD_ROOT="$RPM_BUILD_ROOT" PREFIX=%{_prefix} \ RPMVERSION="$RPM_PACKAGE_VERSION" INSTALL='install -p' install to keep timestamps.

(In reply to comment #9)

Regarding $RPM_OPT_FLAGS, we shouldn't use it here. This is essentially boot loader code, and we want to avoid surprises. It also isn't helpful to have a debuginfo package, because how are you going to debug it?

i don't see why the normal $RPM_OPT_FLAGS shouldn't be used. For the debuginfo, isn't it possible to use some virtualization to debug?

I suggest using %defattr(-,root,root,-) instead of %defattr(-,root,root)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

wtogami@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |pertusus@free.fr

------- Additional Comments From wtogami@redhat.com 2007-10-25 16:53 EST ------- http://togami.com/~warren/fedora/mknbi.spec http://togami.com/~warren/fedora/mknbi-1.4.4-6.fc8.src.rpm

This should be everything requested.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From pertusus@free.fr 2007-10-25 17:11 EST ------- Also in my opinion it would be cleaner to use, on the make install line MANDIR=$RPM_BUILD_ROOT%{_mandir}/man1 BINDIR=$RPM_BUILD_ROOT%{_bindir}

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From pertusus@free.fr 2007-10-29 06:23 EST ------- (In reply to comment #15)

%install rm -rf $RPM_BUILD_ROOT make BUILD_ROOT="$RPM_BUILD_ROOT" PREFIX=%{_prefix} \ MANDIR=$RPM_BUILD_ROOT%{_mandir}/man1 \ BINDIR=$RPM_BUILD_ROOT%{_bindir} \ RPMVERSION="$RPM_PACKAGE_VERSION" INSTALL='install -p' install

You mean like this?

Yes, looks good.

...

Why is LD used for linking instead of gcc?

I don't know, but does it really matter? This was upstream's decision.

Looking at the files generated by LD, it could even be better to use LD and not gcc since they seem to be files that are run at the very beginning of the boot.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From pertusus@free.fr 2007-10-29 11:56 EST ------- A Vendor tag crept in.

I spotted a license issue: md5.c has only this license information: * This implementation is copyright 1997 by M. Gutschke.

This man seems to be the first etherboot maintainer, so it is likely not to be very problematic, but still.

Otherwise it seems to be GPLv2+ (some file don't have any license, not a big deal, may be worth reporting upstream).

Another issue is that the Source is wrong.

mknbi.html should certainly be in %doc

In general it is better to put perl noarch internal modules in %_datadir. And mknbi itself should certainly be in %_bindir directly. However, in the case of mknbi, it is certainly too much work and divergence from upstream to put everything at the right place.

Therefore, all the rpmlint warnings are ignorable: mknbi.src:46: E: hardcoded-library-path in %{_prefix}/lib/mknbi/ mknbi.i386: E: no-binary mknbi.i386: E: only-non-binary-in-usr-lib mknbi-debuginfo.i386: E: empty-debuginfo-package

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From pertusus@free.fr 2007-10-29 14:08 EST ------- The Source0 is still non existing...

Also (not blockers) I think that there should be comments explaining:

* the fact that optflags are not used (and the consequences on debug) * the trick that allows to build on x86_64 32 bit only * the weird placement of everything in /usr/lib/mknbi

License would be better as GPLv2+

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From pertusus@free.fr 2007-10-29 17:07 EST ------- * doesn't really follow packaging guidelines, but it is a very special package, it is intended to create boot images, 32 bit only. No debug flags, no optflags. * source match upstream 5ddafef0a582cfb2b3cd30951662e6e2 mknbi-1.4.4.tar.gz * free software license included. Some files lack a license * follow naming guidelines

Still needswork: There are perl provides that should be filtered out Provides: perl(Elf) perl(Nbi) perl(TruncFD)

The source timestamp isn't kept. You can use wget -N or spectool -g. -rw-rw-r-- 1 dumas dumas 212454 aoû 18 2004 mknbi-1.4.4.tar.gz -rw-rw-r-- 1 dumas dumas 212454 oct 15 04:11 ../SOURCES/mknbi-1.4.4.tar.gz

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From wtogami@redhat.com 2007-10-29 17:58 EST ------- Alternatively, just approve it with the condition that you be allowed to add more cleanups before the first tag & build. That would save a lot of time as well.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From pertusus@free.fr 2007-10-29 18:16 EST ------- Created an attachment (id=242471) --> (https://bugzilla.redhat.com/attachment.cgi?id=242471&action=view) filter out internal modules perl requires

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From wtogami@redhat.com 2007-10-29 20:18 EST ------- Huh? Didn't I already add something like that?

I don't see a second patch.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From pertusus@free.fr 2007-10-30 16:34 EST ------- (In reply to comment #28)

Huh? Didn't I already add something like that?

I don't see a second patch.

In comment #26, I propose a patch to filter out the Requires that are provided by the package itself, but are filtered out since they are not available as modules for real.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From pertusus@free.fr 2007-10-30 17:27 EST ------- Ok, it seemed to me that you only removed the autogenerated Provides. Then the corresponding autogenerated requires were still there and no package satisfied them. I know that am not clear, but one way to understand the issue is to try to install the package and if the package has the problem it won't install.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: mknbi - Utility for creating network bootable images

https://bugzilla.redhat.com/show_bug.cgi?id=331631

------- Additional Comments From pertusus@free.fr 2007-11-14 03:34 EST ------- Maybe this bug should be closed?