https://bugzilla.redhat.com/show_bug.cgi?id=2090791
Miro Hrončok <mhroncok(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Flags| |fedora-review?
Blocks| |2090769
CC| |mhroncok(a)redhat.com
Assignee|nobody(a)fedoraproject.org |mhroncok(a)redhat.com
Doc Type|--- |If docs needed, set a value
--- Comment #1 from Miro Hrončok <mhroncok(a)redhat.com> ---
The entire package uses legacy Python macros, consider not doing that and
benefiting from the automation described in
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ -- I am happy
to help answer questions. Using the new macros would prevent situations like
bz2090769.
Summary: Zope Hookable Objects
Name: python-zope-hookable
The order here is quite unusual. What is the motivation?
Source0:
https://pypi.io/packages/source/z/%{modname}/%{modname}-%{version}.tar.gz
Consider using %{pypi_source %{modname}} instead:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_s...
The number of the source is also redundant.
URL:
https://pypi.io/project/zope.hookable
Consider using
https://github.com/zopefoundation/zope.hookable which is what
upstream lists as their homepage
%package -n python3-zope-hookable
Summary: Zope Hookable Objects
The summary is repeated here for no good reason. You seem to define %{modname}
not to repeat a string that is not much longer than literal %{modname}, yet you
copy-paste the summary instead of using %{summary} here. The same goes with
description but that is a tad trickier to reuse, see:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_e...
%{?python_provide:%python_provide python3-zope-hookable}
This is deprecated and SHOULD NOT be used. It is also not needed: See the note
below
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_t...
Requires: python3-zope-component
Requires: python3-zope-interface
Requires: python3-zope-event
This is not needed and MUST NOT be used. See
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python_201x/#_a...
and
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_package_depen...
rm -rf %{modname}.egg-info
This is not needed. There is no .egg-info in the source tarball. And even if it
was, it would not be required to be removed.
# build Sphinx documents
COPYRIGHT=`grep Author: PKG-INFO |sed -e 's/Author: //'`
cat >docs/conf.py <<END
templates_path = ['_templates']
source_suffix = '.rst'
master_doc = 'index'
project = '%{modname}'
copyright = '$COPYRIGHT'
version = '%{version}'
release = '%{version}'
pygments_style = 'sphinx'
html_static_path = ['_static']
extensions = []
END
This is very confusing. Why is it needed?
%exclude %{python3_sitearch}/zope/hookable/*.txt
Why is this excluded?
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2090769
[Bug 2090769] F37FailsToInstall: python3-zope-component
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2090791