https://bugzilla.redhat.com/show_bug.cgi?id=1169140
Bug ID: 1169140 Summary: Review Request: nodejs-util - Node.JS util module Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: piotr1212@gmail.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://piotrp.fedorapeople.org/nodejs-util.spec SRPM URL: https://piotrp.fedorapeople.org/nodejs-util-0.10.3-1.fc21.src.rpm Description: Node.JS util module Fedora Account System Username: piotrp
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |panemade@gmail.com Assignee|nobody@fedoraproject.org |panemade@gmail.com Flags| |fedora-review+
--- Comment #1 from Parag AN(पराग) panemade@gmail.com --- Review:
+ Package built successful in mock (f22 x86_64)
+ rpmlint on generated rpms gave output nodejs-util.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-util.noarch: W: only-non-binary-in-usr-lib nodejs-util.noarch: W: dangling-symlink /usr/lib/node_modules/util/node_modules/inherits /usr/lib/node_modules/inherits@2 nodejs-util.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 4 warnings.
+ Source verified with upstream as (sha256sum) srpm tarball: 88033ac0a981b3c3919d7bf21e9808d0a2903c331688e4122bdd32eeea3dd6d0 upstream tarball: 88033ac0a981b3c3919d7bf21e9808d0a2903c331688e4122bdd32eeea3dd6d0
+ License is "MIT" and included in its own LICENSE file.
+ follows nodejs packaging guidelines.
Suggestions: 1) Group tag is optional, can be removed.
2) description can be same as %{summary}. Node.js util module.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #2 from Piotr Popieluch piotr1212@gmail.com --- New Package SCM Request ======================= Package Name: nodejs-util Short Description: Node.JS util module Upstream URL: https://github.com/defunctzombie/node-util Owners: piotrp Branches: f19 f20 f21 el6 epel7 InitialCC: piotrp
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- nodejs-util-0.10.3-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-1.fc21
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- nodejs-util-0.10.3-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-1.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- nodejs-util-0.10.3-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-1.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- nodejs-util-0.10.3-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-1.el7
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- nodejs-util-0.10.3-1.el7 has been pushed to the Fedora EPEL 7 testing repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- nodejs-util-0.10.3-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-2.el7
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- nodejs-util-0.10.3-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-2.fc19
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2014-12-14 07:37:08
--- Comment #11 from Piotr Popieluch piotr1212@gmail.com --- Package built and in testing, closing bug.
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- nodejs-util-0.10.3-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-2.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |nodejs-util-0.10.3-1.fc21 Resolution|NEXTRELEASE |ERRATA
--- Comment #13 from Fedora Update System updates@fedoraproject.org --- nodejs-util-0.10.3-1.fc21 has been pushed to the Fedora 21 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
--- Comment #14 from Fedora Update System updates@fedoraproject.org --- nodejs-util-0.10.3-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-util-0.10.3-2.fc21
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-util-0.10.3-1.fc21 |nodejs-util-0.10.3-2.fc20
--- Comment #15 from Fedora Update System updates@fedoraproject.org --- nodejs-util-0.10.3-2.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-util-0.10.3-2.fc20 |nodejs-util-0.10.3-2.el7
--- Comment #16 from Fedora Update System updates@fedoraproject.org --- nodejs-util-0.10.3-2.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1169140
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-util-0.10.3-2.el7 |nodejs-util-0.10.3-2.fc21
--- Comment #17 from Fedora Update System updates@fedoraproject.org --- nodejs-util-0.10.3-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org