[Bug 2132377] New: Review Request: golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra integration with the fig shell
7:59 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
Bug ID: 2132377
Summary: Review Request:
golang-github-withfig-autocomplete-tools-integrations-
cobra - Cobra integration with the fig shell
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: hello(a)anthonyrabbito.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools...
SRPM URL:
https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools...
Description: Fig's integration with popular CLI framework Cobra.
Fedora Account System Username: anthr76
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
7:59 a.m.
New subject: [Bug 2132377] Review Request:
golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra
integration with the fig shell
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
Anthony Rabbito <hello(a)anthonyrabbito.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Doc Type|--- |If docs needed, set a value
Blocks| |2130734
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=2130734
[Bug 2130734] Review Request: Chezmoi - Manage your dotfiles across multiple
diverse machines, securely.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
7:38 p.m.
New subject: [Bug 2132377] Review Request:
golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra
integration with the fig shell
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
--- Comment #1 from Anthony Rabbito <hello(a)anthonyrabbito.com> ---
Updated spec with `gosourcedir0`
Spec URL:
https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools...
SRPM URL:
https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
3:32 a.m.
New subject: [Bug 2132377] Review Request:
golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra
integration with the fig shell
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
Mikel Olasagasti Uranga <mikel(a)olasagasti.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|nobody(a)fedoraproject.org |mikel(a)olasagasti.info
CC| |mikel(a)olasagasti.info
Status|NEW |ASSIGNED
--- Comment #2 from Mikel Olasagasti Uranga <mikel(a)olasagasti.info> ---
Spec is correct, but there is one issue with the README.md files, as you've two
and it complains about duplicated file.
You can fix this by doing in %prep something like `mv
integrations/cobra/README.md README-cobra.md` and adjust `%global godocs` to
the new name.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
9:47 a.m.
New subject: [Bug 2132377] Review Request:
golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra
integration with the fig shell
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
--- Comment #3 from Anthony Rabbito <hello(a)anthonyrabbito.com> ---
Good catch :-)
I also added
autorelease -p
The licenses was also an issue.
Spec URL:
https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools...
SRPM URL:
https://anthr76.fedorapeople.org/golang-github-withfig-autocomplete-tools...
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
10:08 a.m.
New subject: [Bug 2132377] Review Request:
golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra
integration with the fig shell
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
Mikel Olasagasti Uranga <mikel(a)olasagasti.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |fedora-review+
--- Comment #4 from Mikel Olasagasti Uranga <mikel(a)olasagasti.info> ---
thanks for fixing also the Liencese and autorelease parts.
go2rpm package that requires changing gosourcedir0:
- [x] The specfile is sane.
- [x] License is correct
- [x] Builds successfully in mock
- [x] Package is installable (checked by fedora-review)
- [x] No relevant rpmlint errors
- [x] %check section passes
- [x] The latest version is packaged
- [x] `%goipath` is set correctly
- [-] Binaries don't conflict with binaries already in the distribution
- [x] The package complies with the Packaging Guidelines.
Package approved! On import, don't forget to do the following:
- [ ] Add package to release-monitoring.org
- [ ] Give go-sig privileges on package
- [ ] Close the review bug by referencing it in the rpm changelog and the Bodhi
ticket.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
8:39 a.m.
New subject: [Bug 2132377] Review Request:
golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra
integration with the fig shell
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
--- Comment #5 from Gwyn Ciesla <gwync(a)protonmail.com> ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/golang-github-withfig-autocomplete-too...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
12:52 p.m.
New subject: [Bug 2132377] Review Request:
golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra
integration with the fig shell
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |MODIFIED
--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2022-006cf951f8 has been submitted as an update to Fedora 38.
https://bodhi.fedoraproject.org/updates/FEDORA-2022-006cf951f8
--
You are receiving this mail because:
You are always notified about changes to this product and component
You are on the CC list for the bug.
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
12:54 p.m.
New subject: [Bug 2132377] Review Request:
golang-github-withfig-autocomplete-tools-integrations-cobra - Cobra
integration with the fig shell
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |CLOSED
Resolution|--- |ERRATA
Last Closed| |2022-10-13 17:54:03
--- Comment #7 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2022-006cf951f8 has been pushed to the Fedora 38 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
https://bugzilla.redhat.com/show_bug.cgi?id=2132377
582
days inactive
590
days old
package-review@lists.fedoraproject.org
8 comments
1 participants
participants (1)
-
bugzilla＠redhat.com