[Bug 1058765] New: Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form - package-review

List overview All Threads
Download

newer

[Bug 1058765] New: Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

older

[Bug 1120771] New: Review Request:...

[Bug 1128394] New: Review Request:...

Red Hat Bugzilla

28 Jan 2014 28 Jan '14

1:51 p.m.

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

Bug ID: 1058765 Summary: Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: mhroncok@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org

Spec URL: https://raw.github.com/hroncok/SPECS/master/mono-cecil.spec SRPM URL: http://kojipkgs.fedoraproject.org/work/tasks/2934/6462934/mono-cecil-0.9.5-1...

Description: Cecil is a library written by Jb Evain to generate and inspect programs and libraries in the ECMA CIL format. It has full support for generics, and support some debugging symbol format.

In simple English, with Cecil, you can load existing managed assemblies, browse all the contained types, modify them on the fly and save back to the disk the modified assembly.

Today it is used by the Mono Debugger, the bug-finding and compliance checking tool Gendarme, MoMA, DB4O, as well as many other tools.

Fedora Account System Username: churchyard

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Show replies by date

Red Hat Bugzilla

28 Jan 28 Jan

1:53 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

Miro Hrončok mhroncok@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1032883

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1032883 [Bug 1032883] OpenTK-2013.11.12 is available

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

31 Jan 31 Jan

4:52 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

Will Benton willb@redhat.com changed:

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

27 Feb 27 Feb

5:50 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

--- Comment #1 from Will Benton willb@redhat.com --- Thanks for your hard work packaging this project! There are a few minor things to address before I can approve the review.

Issues and notes:

* Thanks for using a commit SHA to specify your source archive location.

* Please replace the hard-coded /usr/lib/mono with a macro; you may define %{monodir} as /usr/lib/mono in this spec, but I am planning to get a clarification to the Mono guidelines that has an official macro (see https://fedorahosted.org/fpc/ticket/395).

* You probably should require mono-core since (1) mono-core is required to use mono-cecil and (2) you place files in /usr/lib/mono/gac, which mono-core owns. These conditions are listed in

https://fedoraproject.org/wiki/Packaging:Guidelines#File_and_Directory_Owner...

Note that Cecil's functional dependency on mono-core is captured by its (automatically-generated) Requires at the moment, but the explicit Requires: mono-core is to ensure that you comply by the file and directory ownership guidelines even if the assemblies you depend on move to another package than the gac directory in the future. It also appears to be common practice among mono libraries to explicitly depend on mono-core.

* Please file an issue upstream to get a license file included in the source tarball.

* It appears that this package includes tests. Please either run them (in %check) or justify why the tests can't be run in koji with a specfile comment.

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 76 files have unknown license. Detailed output of licensecheck in /home/wibenton/devel/review /mono-cecil/licensecheck.txt [x]: Package does not own files or directories owned by other packages. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [!]: Package consistently uses macros (instead of hard-coded directory names).

- see explanation above

[x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary.

- see explanation above

[x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. [!]: Package complies to the Packaging Guidelines

- except as already mentioned

[x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Each %files section contains %defattr if rpm < 4.4 [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass.

- please add %check or justify why the tests can't run

[x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX tarball generation or download is documented. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched.

Rpmlint ------- Checking: mono-cecil-0.9.5-1.20131105git8425de4.fc21.noarch.rpm mono-cecil-0.9.5-1.20131105git8425de4.fc21.src.rpm mono-cecil.noarch: W: incoherent-version-in-changelog 0.9.5-1 ['0.9.5-1.20131105git8425de4.fc21', '0.9.5-1.20131105git8425de4'] mono-cecil.noarch: W: only-non-binary-in-usr-lib mono-cecil.src:33: E: hardcoded-library-path in %{buildroot}/usr/lib/mono/gac/ mono-cecil.src:35: E: hardcoded-library-path in %{buildroot}/usr/lib mono-cecil.src:36: E: hardcoded-library-path in %{buildroot}/usr/lib mono-cecil.src:37: E: hardcoded-library-path in %{buildroot}/usr/lib mono-cecil.src:38: E: hardcoded-library-path in %{buildroot}/usr/lib mono-cecil.src:43: E: hardcoded-library-path in /usr/lib/mono/gac/Mono.Cecil* mono-cecil.src:44: E: hardcoded-library-path in /usr/lib/mono/Mono.Cecil* 2 packages and 0 specfiles checked; 7 errors, 2 warnings.

Rpmlint (installed packages) ---------------------------- # rpmlint mono-cecil mono-cecil.noarch: W: incoherent-version-in-changelog 0.9.5-1 ['0.9.5-1.20131105git8425de4.fc21', '0.9.5-1.20131105git8425de4'] mono-cecil.noarch: W: only-non-binary-in-usr-lib 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:'

Requires -------- mono-cecil (rpmlib, GLIBC filtered): mono(Mono.Cecil) mono(System) mono(System.Core) mono(mscorlib)

Provides -------- mono-cecil: mono(Mono.Cecil) mono(Mono.Cecil.Mdb) mono(Mono.Cecil.Pdb) mono(Mono.Cecil.Rocks) mono-cecil

Source checksums ---------------- https://github.com/jbevain/cecil/archive/8425de4db6a6e120154ced991f1ebc8d4d7... : CHECKSUM(SHA256) this package : f205b6b0d7efcf0358bc9a4d12a7a0debaa16061708dd8789dc55ad651291552 CHECKSUM(SHA256) upstream package : f205b6b0d7efcf0358bc9a4d12a7a0debaa16061708dd8789dc55ad651291552

Generated by fedora-review 0.5.0 (920221d) last change: 2013-08-30 Command line :/usr/bin/fedora-review --rpm-spec -n /home/wibenton/rpmbuild/SRPMS/mono-cecil-0.9.5-1.20131105git8425de4.fc19.src.rpm -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, SugarActivity, Perl, R, PHP, Ruby Disabled flags: EPEL5, EXARCH, DISTTAG

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:03 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

--- Comment #2 from Miro Hrončok mhroncok@redhat.com --- Thanks for the review.

I've pushed new spec that fixes your issues (no new SRPM yet):

https://raw.github.com/hroncok/SPECS/master/mono-cecil.spec

I tried to run the tests by nunit, but so far I have no success, could you give me a hand with it please? I have no idea, how should I invoke it in the right way.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:45 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

--- Comment #3 from Will Benton willb@redhat.com --- (One more thing: there is a bundled nunit installation in Test/; please remove this during %prep.)

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7:51 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

--- Comment #4 from Will Benton willb@redhat.com --- (In reply to Miro Hrončok from comment #2)

...

Thanks for the review.

I've pushed new spec that fixes your issues (no new SRPM yet):

https://raw.github.com/hroncok/SPECS/master/mono-cecil.spec

I tried to run the tests by nunit, but so far I have no success, could you give me a hand with it please? I have no idea, how should I invoke it in the right way.

I've taken a look at this; unfortunately, I'm not a Mono expert and can find no other packages that use nunit (or nant, which depends on nunit) in their builds! It looks like you'll need to compile the projects in Test and rocks/Test before running any tests, but actually running the tests from the given configuration file (I used "nunit-console Mono.Cecil.nunit") fails because some symbol files and libraries aren't where they are expected.

If you could reach out to upstream and ask how they run tests as part of their CI, that would probably be helpful. If it's going to be a lot of work to get the tests running, though, I won't hold up the review just because of a missing %check.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

3 Oct 3 Oct

3:50 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

Jeffrey C. Ollie jeff@ocjtech.us changed:

--- Comment #5 from Jeffrey C. Ollie jeff@ocjtech.us --- Any news on getting this finished up? Until this gets into Fedora and OpenTK gets updated RepetierHost won't work.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

7 Oct 7 Oct

11:59 a.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

Miro Hrončok mhroncok@redhat.com changed:

--- Comment #6 from Miro Hrončok mhroncok@redhat.com --- Well, I was not able to run the tests. So I would go for no %check. However, it seems a lot of commits had passed since February, so I'll check whatever version RepetierHost needs and test that again.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

25 Oct 25 Oct

8:05 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

Miro Hrončok mhroncok@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(willb@redhat.com)

--- Comment #7 from Miro Hrončok mhroncok@redhat.com --- So once again, after a long time:

Spec URL: https://raw.githubusercontent.com/hroncok/SPECS/c3a1defc8d7625aab20e36721688... SRPM URL: https://churchyard.fedorapeople.org/SRPMS/mono-cecil-0.9.5-3.20140924git6d1b...

It's updated. I definitely don't run test, because I was not bale to do that sorry.

Will, still doing the review?

Thanks

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:06 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

--- Comment #8 from Miro Hrončok mhroncok@redhat.com --- s/bale/able/

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

8:59 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

--- Comment #9 from Miro Hrončok mhroncok@redhat.com --- Spec URL: https://raw.githubusercontent.com/hroncok/SPECS/master/mono-cecil.spec SRPM URL: https://churchyard.fedorapeople.org/SRPMS/mono-cecil-0.9.5-3.20140924git6d1b...

After removing bundled nunit, I had to patch the sln file not to build the tests

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

5 Nov 5 Nov

8:16 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

Will Benton willb@redhat.com changed:

--- Comment #10 from Will Benton willb@redhat.com --- Thanks for the updates, Miro. You've addressed all of my concerns from the review and the package looks fine now. (We're still waiting on a clarification on the Mono guidelines, unfortunately!)

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6 Nov 6 Nov

9:21 a.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

--- Comment #11 from Miro Hrončok mhroncok@redhat.com --- Thanks a lot, Will.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

9:23 a.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

Miro Hrončok mhroncok@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?

--- Comment #12 from Miro Hrončok mhroncok@redhat.com --- New Package SCM Request ======================= Package Name: mono-cecil Short Description: Library to generate and inspect programs and libraries in the ECMA CIL form Upstream URL: http://www.mono-project.com/Cecil Owners: churchyard Branches: f21

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:55 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

12:55 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

--- Comment #13 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

27 Dec 27 Dec

2:05 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

2:05 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

--- Comment #14 from Fedora Update System updates@fedoraproject.org --- mono-cecil-0.9.5-3.20140924git6d1b7d0.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/mono-cecil-0.9.5-3.20140924git6d1b7d...

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

4:58 p.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

--- Comment #15 from Fedora Update System updates@fedoraproject.org --- OpenTK-1.1-1.4c.fc21,mono-cecil-0.9.5-3.20140924git6d1b7d0.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/OpenTK-1.1-1.4c.fc21,mono-cecil-0.9....

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

29 Dec 29 Dec

10:04 a.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA

--- Comment #16 from Fedora Update System updates@fedoraproject.org --- Package OpenTK-1.1-1.4c.fc21, mono-cecil-0.9.5-3.20140924git6d1b7d0.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing OpenTK-1.1-1.4c.fc21 mono-cecil-0.9.5-3.20140924git6d1b7d0.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-17689/OpenTK-1.1-1.4c.fc... then log in and leave karma (feedback).

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

Red Hat Bugzilla

6 Jan 6 Jan

6:16 a.m.

New subject: [Bug 1058765] Review Request: mono-cecil - Library to generate and inspect programs and libraries in the ECMA CIL form

https://bugzilla.redhat.com/show_bug.cgi?id=1058765

Fedora Update System updates@fedoraproject.org changed:

--- Comment #17 from Fedora Update System updates@fedoraproject.org --- OpenTK-1.1-1.4c.fc21, mono-cecil-0.9.5-3.20140924git6d1b7d0.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.

-- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

3464

Age (days ago)

3807

Last active (days ago)

package-review@lists.fedoraproject.org

21 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla