Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: gnome-valgrind-session - Run an entire GNOME session under valgrind

https://bugzilla.redhat.com/show_bug.cgi?id=444113

debarshi.ray@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |dmalcolm@redhat.com

------- Additional Comments From debarshi.ray@gmail.com 2008-04-24 23:24 EST ------- *** Bug 216517 has been marked as a duplicate of this bug. ***

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=444113

--- Comment #3 from Rakesh Pandit rakesh.pandit@gmail.com 2008-08-23 16:58:43 EDT --- APPROVED

Looks sane to me.

rpmlint output: clean

Build successfully: http://koji.fedoraproject.org/koji/taskinfo?taskID=781728

Required: [x] Name [x] License -- Public Domain [x] Spec file is in American Eng and legible [x] Build successfully [x] BuildRequires [x] Duplicate files - nil [NA] locale [x] permissions -- okay [x] source link correct [x] packaging guidlines [x] Buildroot correct [x] owns every directory it creates [x] file encoding - checked [x] package has no dependency on files in %doc [x] gui [x] No dependencies outside FHS guidelines [x] md5sum Source from site: 4988af57dc895509ce01e2742883f47b Source from srpm: 4988af57dc895509ce01e2742883f47b [x] package owns all directories it created -- 1 [x] description & summary -- okay [x] %install & %clean section have rm -rf $RPM_BUILD_ROOT

Optional suggestions: a. optional: check .desktop file [rpmbuild@rocky gnome-valgrind-session-1.1]$ desktop-file-validate gnome-valgrind-errors.desktop gnome-valgrind-errors.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated gnome-valgrind-errors.desktop: error: value "XSession" for key "Type" in group "Desktop Entry" is not a registered type value ("Application", "Link" and "Directory")

[rpmbuild@rocky gnome-valgrind-session-1.1]$ desktop-file-validate gnome-valgrind-leaks.desktop gnome-valgrind-leaks.desktop: warning: key "Encoding" in group "Desktop Entry" is deprecated gnome-valgrind-leaks.desktop: error: value "XSession" for key "Type" in group "Desktop Entry" is not a registered type value ("Application", "Link" and "Directory")

*You can ignore them*

Key NA = N/A, x = Check, ! = Problem, ? = Not evaluated

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=444113

--- Comment #5 from Debarshi Ray debarshi.ray@gmail.com 2008-09-06 05:37:21 EDT --- New Package CVS Request ======================= Package Name: gnome-valgrind-session Short Description: Run an entire GNOME session under valgrind Owners: rishi Branches: F-8 F-9 InitialCC:

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=444113

--- Comment #7 from Jason Tibbitts tibbs@math.uh.edu 2008-09-10 20:05:55 EDT --- CVS done.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=444113

Debarshi Ray debarshi.ray@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE

--- Comment #9 from Debarshi Ray debarshi.ray@gmail.com 2008-09-12 00:40:21 EDT --- Tagged and built in Rawhide.