[Bug 2097826] New: Review Request: perl-Types-ReadOnly - Type constraints and coercions for read-only data structures and locked hashes
https://bugzilla.redhat.com/show_bug.cgi?id=2097826
Bug ID: 2097826 Summary: Review Request: perl-Types-ReadOnly - Type constraints and coercions for read-only data structures and locked hashes Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: rc040203@freenet.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://corsepiu.fedorapeople.org/packages/perl-Types-ReadOnly.spec SRPM URL: https://corsepiu.fedorapeople.org/packages/perl-Types-ReadOnly-0.003-1.fc37.... Description: This is a type constraint library for write-restricted references.
This module is built with Type::Tiny, which means that you can use it with Moo, Mouse, Moose, or none of the above.
Fedora Account System Username: corsepiu
https://bugzilla.redhat.com/show_bug.cgi?id=2097826
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value
--- Comment #1 from Ralf Corsepius rc040203@freenet.de --- This package is a so far missing, optional BR: of perl-Types-Tiny.
https://bugzilla.redhat.com/show_bug.cgi?id=2097826
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? Status|NEW |ASSIGNED CC| |mspacek@redhat.com Assignee|nobody@fedoraproject.org |mspacek@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=2097826
--- Comment #2 from Michal Josef Spacek mspacek@redhat.com --- There are some issues: * I think that block with '%if !%{defined perl_bootstrap}' is bad. There are runtime dependencies (Type::Tiny, Type::Coercion, Types::Standard, and Type::Library) that are in Type::Tiny dist. We need to remove if/else (bootstrap) and we need to add this kind of bootstrap block to BuildRequire in perl-Type-Tiny (for perl-Types-ReadOnly, is used in tests only). * Rewrite license to SPDX * Remove MODULE_COMPAT line
Optional: * I am for adding comments like "Runtime:" and "Tests:" to BuildRequire list as in other Perl modules
Product: Fedora Version: rawhide Component: Package Review
Michal Josef Spacek mspacek@redhat.com has denied Package Review package-review@lists.fedoraproject.org's request for Michal Josef Spacek mspacek@redhat.com's needinfo: Bug 2097826: Review Request: perl-Types-ReadOnly - Type constraints and coercions for read-only data structures and locked hashes https://bugzilla.redhat.com/show_bug.cgi?id=2097826
https://bugzilla.redhat.com/show_bug.cgi?id=2097826
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(mspacek@redhat.co |needinfo- |m) |
https://bugzilla.redhat.com/show_bug.cgi?id=2097826
Michal Josef Spacek mspacek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(rc040203@freenet. | |de)
--- Comment #4 from Michal Josef Spacek mspacek@redhat.com --- @rc040203@freenet.de What about this ticket?
https://bugzilla.redhat.com/show_bug.cgi?id=2097826
Ralf Corsepius rc040203@freenet.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(rc040203@freenet. | |de) |
--- Comment #5 from Ralf Corsepius rc040203@freenet.de --- (In reply to Michal Josef Spacek from comment #4)
@rc040203@freenet.de What about this ticket?
It's still valid.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com