Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=532306

--- Comment #2 from Jeroen van Meeuwen kanarip@kanarip.com 2009-11-02 13:51:46 EDT --- (In reply to comment #1)

• Please create one srpm per one gem.

These gems do not distribute very well separately, they have the same upstream and one requires the other in a %{version}-%{release} specific manner.

• Also, you must not strip rebuilt binaries and create debuginfo rpm correctly. Please refer to:

https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Gem_with_extension_librar...

I don't know how to resolve the inclusion of a reference to the buildroot in the binary blob (I did know how to make it disappear in the included Makefile, but not the blob):

""" + /usr/lib/rpm/check-buildroot Binary file /home/jmeeuwen/devel/rpmbuild/BUILDROOT/rubygem-ruby-debug-0.10.3-1.fc12.x86_64/usr/lib64/ruby/site_ruby/1.8/x86_64-linux/ruby_debug.so matches Found '/home/jmeeuwen/devel/rpmbuild/BUILDROOT/rubygem-ruby-debug-0.10.3-1.fc12.x86_64' in installed files; aborting error: Bad exit status from /var/tmp/rpm-tmp.eZZmKv (%install) """

• Also unless unavoided I don't think to add || : for test results. If test fails, you should debug it first.

I've fiddled around with it a bit and it now seems OK.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=532306

--- Comment #4 from Jeroen van Meeuwen kanarip@kanarip.com 2009-11-04 07:40:05 EDT --- I modified the procedure just a little bit, as I generally want to prevent installing anything in %prep; in this case, it works out just fine (I think).

New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-ruby-debug.spec New SRPM: http://www.kanarip.com/custom/f12/SRPMS/rubygem-ruby-debug-0.10.3-2.fc12.src...

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=532306

--- Comment #6 from Jeroen van Meeuwen kanarip@kanarip.com 2009-11-08 11:36:07 EDT --- (In reply to comment #5)

Well,

• Please package linecache first. %check fails without linecache and even without %check ruby-debug-base actually needs linecache (see ruby-debug-base-0.10.3/lib/ruby-debug-base.rb) http://koji.fedoraproject.org/koji/taskinfo?taskID=1794237 ( Does your srpm actually builds for you? )

It does build on my machine locally but then again I already have a linecache package; this package is part of a bunch of packages I'm working on. I'll be submitting rubygem-linecache for review asap, and create a dependency between the two reviews.

• "head" command or so is very dangerous when binary files exist. Actually

---

61  # Fix anything executable that does not have a shebang
62  for file in `find %{buildroot}/%{geminstdir}

%{buildroot}/%{geminstdir2} -type f -perm /a+x`; do 63 [ -z "`head -n 1 $file | grep "^#!/"`" ] && chmod -v 644 $file 64 done

---

changes the permission of ruby_debug.so to 0644 and currently debuginfo rpm is not correctly created.

This should also filter on -name "*.rb", which I fixed.

• Executing %check under %buildroot is wrong for this package because "rake test" again tries to create ruby_debug.so under %buildroot%{geminstdir2}/ext/ because we move this file to %buildroot%ruby_sitearch

---

853 Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.5gRRsq 860 + rake -f ../ruby-debug-0.10.3/Rakefile test 865 gcc -shared -o ruby_debug.so breakpoint.o ruby_debug.o -L. -L/usr/lib -L. -rdynamic -Wl,-export-dynamic -lruby -lpthread -lrt -ldl -lcrypt -lm

-lc

%check must be done under %_builddir for this package.

Fixed this too.

New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-ruby-debug.spec New SRPM: http://www.kanarip.com/custom/f12/SRPMS/rubygem-ruby-debug-0.10.3-3.fc12.src...

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=532306

--- Comment #7 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-11-14 13:29:54 EDT --- (Just putting a note that I postpone reviewing this review request until bug 533725 is completed)

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=532306

--- Comment #9 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2009-12-20 15:06:52 EDT --- Created an attachment (id=379509) --> (https://bugzilla.redhat.com/attachment.cgi?id=379509) Patch for ruby-debug to use system-wide -base and test fix

Ah...

(In reply to comment #3)

(In reply to comment #2)

...

(In reply to comment #1)

...

• Please create one srpm per one gem.

These gems do not distribute very well separately, they have the same upstream and one requires the other in a %{version}-%{release} specific manner.

• Ah, I checked two gems and actually dependency is in loop...

Well, I checked these two gems' dependency again and actually ruby-debug-base does not require ruby-debug ( ruby-debug-base-0.10.3/test/base/base.rb has "require 'ruby_debug'" for example, but this is satisfied by "ruby_debug.so" in ruby-debug-base (and not by ruby-debug.rb in ruby-debug gem) ) Also "rake test" under ruby-debug-base succeeds without ruby-debug gem. So still ruby-debug-base and ruby-debug should be packaged seperately. (ruby-debug-base does not depend on ruby-debug but ruby-debug does depend on ruby-debug-base)

For ruby-debug, currently your spec file contains: --------------------------------------------------------- 99 %check 100 pushd %{_builddir}/%{name}-%{version}/%{geminstdir2} 101 rake -f ../ruby-debug-0.10.3/Rakefile test --------------------------------------------------------- This skips many tests, because ruby-debug Rakefile contains --------------------------------------------------------- 27 CLI_TEST_FILE_LIST = FileList['test/cli/commands/unit/*.rb', 28 'test/cli/commands/*_test.rb', 29 'test/cli/**/*_test.rb', 30 'test/test-*.rb'] 61 t.test_files = CLI_TEST_FILE_LIST ---------------------------------------------------------- however many of these files cannot be detected if the working directory is ./%{geminstdir2}, not ./%{geminstdir}. "rake test" for ruby-debug should be done under .%{geminstdir}. Note that when executing "rake test" correctly under ./%{geminstdir} many tests fail and patch is needed (attached). After applying patch: ----------------------------------------------------------- [tasaka1@localhost ruby-debug-0.10.3]$ rake test (in /home/tasaka1/rpmbuild/Reviewing/rubygem-related/rubygem-ruby-debug/rubygem-ruby-debug-0.10.3-4.fc12.src/TMP2/DEBUGINSTDIR/gems/ruby-debug-0.10.3) ruby_debug already installed, skipping creating shared library extension /usr/bin/ruby -I"lib:./ext:./lib" "/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb" "test/base/base.rb" "test/base/binding.rb" "test/base/catchpoint.rb" Loaded suite /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader Started ..... Finished in 0.003895 seconds.

5 tests, 30 assertions, 0 failures, 0 errors /usr/bin/ruby -I"lib:./ext:./lib:./cli" "/usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader.rb" "test/cli/commands/unit/regexp.rb" "test/cli/commands/catchpoint_test.rb" "test/cli/commands/catchpoint_test.rb" "test/test-edit.rb" "test/test-info.rb" "test/test-source.rb" "test/test-annotate.rb" "test/test-ctrl.rb" "test/test-list.rb" "test/test-catch.rb" "test/test-save.rb" "test/test-info-thread.rb" "test/test-emacs-basic.rb" "test/test-quit.rb" "test/test-init.rb" "test/test-method.rb" "test/test-info-var.rb" "test/test-output.rb" "test/test-trace.rb" "test/test-setshow.rb" "test/test-help.rb" "test/test-hist.rb" "test/test-raise.rb" "test/test-breakpoints.rb" "test/test-finish.rb" "test/test-stepping.rb" "test/test-frame.rb" "test/test-condition.rb" "test/test-enable.rb" "test/test-display.rb" "test/test-dollar-0.rb" "test/test-break-bad.rb" "test/test-pm.rb" Loaded suite /usr/lib/ruby/gems/1.8/gems/rake-0.8.7/lib/rake/rake_test_loader Started .........................Skipping method sig test .......... Finished in 18.947538 seconds.

35 tests, 46 assertions, 0 failures, 0 errors ----------------------------------------------------------- Currently only the first 5 tests are executed.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=532306

Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp changed:

What |Removed |Added ---------------------------------------------------------------------------- Flag| |needinfo?(kanarip@kanarip.c | |om)

--- Comment #13 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-01-31 07:32:07 EST --- Would you intend to package rubygem-ruby-debug-base?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=532306

--- Comment #15 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-02-18 13:35:41 EST --- (In reply to comment #14)

1. I cannot get this:

• http://www.kanarip.com/custom/SPECS/rubygem-ruby-debug.spec

http://www.kanarip.com/custom/f12/SRPMS/rubygem-ruby-debug-0.10.3-4.fc12.src... to work with this:

• http://www.kanarip.com/custom/SPECS/rubygem-ruby-debug-base.spec

http://www.kanarip.com/custom/f12/SRPMS/rubygem-ruby-debug-base-0.10.3-5.fc1...

- See my comment 9

2. I see no use for two separate packages

- It makes maintenanse much easier.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=532306

--- Comment #17 from Jeroen van Meeuwen kanarip@kanarip.com 2010-02-18 13:49:42 EST --- (In reply to comment #16)

(In reply to comment #15)

...

• See my comment 9

I don't see how rake test in rubygem-ruby-debug can succeed, when executed from the %{_builddir}/%{name}-%{version}/%{geminstdir}, without the ext/ directory from rubygem-ruby-debug-base in /usr/lib/ruby/gems/1.8/ruby-debug-0.10.3/

This should have said:

I don't see how rake test in rubygem-ruby-debug can succeed, when executed from the %{_builddir}/%{name}-%{version}/%{geminstdir}, without the ext/ directory from rubygem-ruby-debug-base in /usr/lib/ruby/gems/1.8/ruby-debug-0.10.3/ or %{_builddir}/%{name}-%{version}/%{geminstdir}

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=532306

--- Comment #18 from Mamoru Tasaka mtasaka@ioa.s.u-tokyo.ac.jp 2010-02-19 00:02:20 EST --- (In reply to comment #17)

(In reply to comment #16)

...

(In reply to comment #15)

...

• See my comment 9

I don't see how rake test in rubygem-ruby-debug can succeed, when executed from the %{_builddir}/%{name}-%{version}/%{geminstdir}, without the ext/ directory from rubygem-ruby-debug-base in /usr/lib/ruby/gems/1.8/ruby-debug-0.10.3/

This should have said:

I don't see how rake test in rubygem-ruby-debug can succeed, when executed from the %{_builddir}/%{name}-%{version}/%{geminstdir}, without the ext/ directory from rubygem-ruby-debug-base in /usr/lib/ruby/gems/1.8/ruby-debug-0.10.3/ or %{_builddir}/%{name}-%{version}/%{geminstdir}

- So please see my comment 9. Already patch attached.

(In reply to comment #16)

...

...

2. I see no use for two separate packages

• It makes maintenanse much easier.

Actually it doesn't, as we have seen with the rails packages as well.

- No. It is just on Fedora chain-build cannot be used for rails related packages other than rawhide branch. It is just Fedora's builder issue. Seperating srpm is always preferable, for example when security issue is found on actionpack, we just apply a patch against actionpack only and only release new actionpack. Recompiling rails releated packages all is just silly in such case.