https://bugzilla.redhat.com/show_bug.cgi?id=1121402
Bug ID: 1121402 Summary: Review Request: t-digest Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: jvanek@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://jvanek.fedorapeople.org/t-digets/1/t-digest.spec SRPM URL: http://jvanek.fedorapeople.org/t-digets/1/t-digest-3.0-1.fc20.src.rpm Description: A new data structure for accurate on-line accumulation of rank-based statistics such as quantiles and trimmed means Fedora Account System Username: jvanek
rpms: http://jvanek.fedorapeople.org/t-digets/1/noarch/
This is build requirment for elastic search. As there is still hope to pack elastick seacrh into f21, please count with it
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
jiri vanek jvanek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |902086 (Elasticsearch)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=902086 [Bug 902086] Review request: Elasticsearch
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
jiri vanek jvanek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Version|rawhide |21
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
--- Comment #1 from jiri vanek jvanek@redhat.com --- Fixed description lenghts to 80 chars
Spec URL: http://jvanek.fedorapeople.org/t-digets/2/t-digest.spec SRPM URL: http://jvanek.fedorapeople.org/t-digets/2/t-digest-3.0-1.fc20.src.rpm Description: A new data structure for accurate on-line accumulation of rank-based statistics such as quantiles and trimmed means Fedora Account System Username: jvanek
rpms: http://jvanek.fedorapeople.org/t-digets/2/noarch/
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |mizdebsk@redhat.com Assignee|nobody@fedoraproject.org |mizdebsk@redhat.com Flags| |fedora-review?
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
--- Comment #2 from Mikolaj Izdebski mizdebsk@redhat.com --- Package Review ==============
Key: x = Check ! = Problem
[x] rpmlint must be run on the source rpm and all binary rpms the build produces. The output should be posted in the review.
[x] The package must be named according to the Package Naming Guidelines.
[x] The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption.
[x] The package must meet the Packaging Guidelines.
[!] The package must be licensed with a Fedora approved license and meet the Licensing Guidelines.
Inorrect license tag, should be: ASL v2.0
[x] The License field in the package spec file must match the actual license.
[x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc.
[x] The spec file must be written in American English.
[x] The spec file for the package MUST be legible.
[x] The sources used to build the package must match the upstream source, as provided in the spec URL. Reviewers should use sha256sum for this task as it is used by the sources file once imported into git. If no upstream URL can be specified for this package, please see the Source URL Guidelines for how to deal with this.
[x] The package MUST successfully compile and build into binary rpms on at least one primary architecture.
[x] If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line.
[x] All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines; inclusion of those as BuildRequires is optional. Apply common sense.
[x] The spec file MUST handle locales properly. This is done by using the %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.
[x] Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun.
[x] Packages must NOT bundle copies of system libraries.
[x] If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker.
[x] A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory.
[x] A Fedora package must not list a file more than once in the spec file's %files listings. (Notable exception: license texts in specific situations.)
[x] Permissions on files must be set properly. Executables should be set with executable permissions, for example.
[x] Each package must consistently use macros.
[x] The package must contain code, or permissible content.
[x] Large documentation files must go in a -doc subpackage. (The definition of large is left up to the packager's best judgement, but is not restricted to size. Large can refer to either size or quantity).
[x] If a package includes something as %doc, it must not affect the runtime of the application. To summarize: If it is in %doc, the program must run properly if it is not present.
[x] Static libraries must be in a -static package.
[x] Development files must be in a -devel package.
[x] In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name}%{?_isa} = %{version}-%{release}
[x] Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built.
[x] Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. If you feel that your packaged GUI application does not need a .desktop file, you must put a comment in the spec file with your explanation.
[x] Packages must not own files or directories already owned by other packages. The rule of thumb here is that the first package to be installed should own the files or directories that other packages may rely upon. This means, for example, that no package in Fedora should ever share ownership with any of the files or directories owned by the filesystem or man package. If you feel that you have a good reason to own a file or directory that another package owns, then please present that at package review time.
[x] All filenames in rpm packages must be valid UTF-8.
rpmlint output --------------
t-digest.noarch: W: spelling-error %description -l en_US quantiles -> quarantines, antiquates, Antilles t-digest.noarch: E: description-line-too-long C such as quantiles and trimmed means. The t-digest algorithm is also very parallel t-digest.noarch: W: invalid-license APL-2 t-digest.src: W: spelling-error %description -l en_US quantiles -> quarantines, antiquates, Antilles t-digest.src: E: description-line-too-long C such as quantiles and trimmed means. The t-digest algorithm is also very parallel t-digest.src: W: invalid-license APL-2 t-digest.src: W: strange-permission t-digest-3.0.tar.gz 0640L t-digest.src: W: file-size-mismatch t-digest-3.0.tar.gz = 3285098, https://github.com/tdunning/t-digest/archive/t-digest-3.0.tar.gz = 3282914 t-digest-javadoc.noarch: W: invalid-license APL-2 3 packages and 0 specfiles checked; 2 errors, 7 warnings.
Other issues ------------
Description must have lines limited to 80 characters.
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
--- Comment #3 from Mikolaj Izdebski mizdebsk@redhat.com --- (In reply to Mikolaj Izdebski from comment #2)
Inorrect license tag, should be: ASL v2.0
Correction, it should be ASL 2.0
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
--- Comment #4 from jiri vanek jvanek@redhat.com ---
Spec URL: http://jvanek.fedorapeople.org/t-digets/3/t-digest.spec SRPM URL: http://jvanek.fedorapeople.org/t-digets/3/t-digest-3.0-1.fc20.src.rpm Description: A new data structure for accurate on-line accumulation of rank-based statistics such as quantiles and trimmed means Fedora Account System Username: jvanek
rpms: http://jvanek.fedorapeople.org/t-digets/3/noarch/
--- /home/jvanek/rpmbuild/SPECS/old +++ /home/jvanek/rpmbuild/SPECS/t-digest.spec @@ -1,10 +1,12 @@ +%global url https://github.com/tdunning/%%7Bname%7D + Name: t-digest Version: 3.0 Release: 1%{?dist} Summary: A new data structure for on-line accumulation of statistics -License: APL-2 -URL: https://github.com/tdunning/%%7Bname%7D/ -Source0: https://github.com/tdunning/%%7Bname%7D/archive/%%7Bname%7D-%%7Bversion%7D.t... +License: ASL 2.0 +URL: %{url} +Source0: %{url}/archive/%{name}-%{version}.tar.gz BuildArch: noarch
BuildRequires: maven-local @@ -13,7 +15,7 @@
%description A new data structure for accurate on-line accumulation of rank-based statistics -such as quantiles and trimmed means. The t-digest algorithm is also very parallel +eg. quantiles and trimmed means. The t-digest algorithm is also very parallel friendly making it useful in map-reduce and parallel streaming applications.
%package javadoc
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
Mikolaj Izdebski mizdebsk@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #5 from Mikolaj Izdebski mizdebsk@redhat.com --- Package approved.
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
jiri vanek jvanek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #6 from jiri vanek jvanek@redhat.com --- New Package SCM Request ======================= Package Name: t-digest Short Description: A new data structure for on-line accumulation of statistics Upstream URL: https://github.com/tdunning/t-digest Owners: jvanek Branches: f20 f21 InitialCC: volker27@gmx.at bjoern.esser@gmail.com pbrobinson@gmail.com lzap@redhat.com joergprante@gmx.de
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
--- Comment #7 from jiri vanek jvanek@redhat.com --- New Package SCM Request ======================= Package Name: t-digest Short Description: A new data structure for on-line accumulation of statistics Upstream URL: https://github.com/tdunning/t-digest Owners: jvanek Branches: f20 f21
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
--- Comment #8 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
jiri vanek jvanek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |CURRENTRELEASE Last Closed| |2014-07-31 10:30:27
--- Comment #9 from jiri vanek jvanek@redhat.com --- Here we are: f22 http://koji.fedoraproject.org/koji/taskinfo?taskID=7220080 f21 http://koji.fedoraproject.org/koji/taskinfo?taskID=7220108 f20 http://koji.fedoraproject.org/koji/taskinfo?taskID=7220109
and
https://admin.fedoraproject.org/updates/t-digest-3.0-1.fc20
ty all!
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- t-digest-3.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/t-digest-3.0-1.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |t-digest-3.0-1.fc20 Resolution|CURRENTRELEASE |ERRATA
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- t-digest-3.0-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=1121402
jiri vanek jvanek@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |puntogil@libero.it
--- Comment #12 from jiri vanek jvanek@redhat.com --- *** Bug 1138312 has been marked as a duplicate of this bug. ***
package-review@lists.fedoraproject.org