Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Exaile! - A music player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220775 panemade(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody(a)fedoraproject.org |panemade(a)gmail.com OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From panemade(a)gmail.com 2006-12-26 23:24 EST ------- pacakaging looks nice. as its pygtk application no need for -devel for included .so file. desktop file even worked well. But mock build failed with In file included from mmkeys.override:6: /usr/include/pygtk-2.0/pygobject.h:20: error: expected specifier-qualifier-list before 'PyObject' /usr/include/pygtk-2.0/pygobject.h:27: error: expected specifier-qualifier-list before 'PyObject_HEAD' /usr/include/pygtk-2.0/pygobject.h:38: error: expected specifier-qualifier-list before 'PyObject_HEAD' /usr/include/pygtk-2.0/pygobject.h:48: error: expected specifier-qualifier-list before 'PyObject_HEAD' /usr/include/pygtk-2.0/pygobject.h:60: error: expected specifier-qualifier-list before 'PyObject_HEAD' /usr/include/pygtk-2.0/pygobject.h:67: error: expected declaration specifiers or '...' before 'PyTypeObject' /usr/include/pygtk-2.0/pygobject.h:68: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token /usr/include/pygtk-2.0/pygobject.h:76: error: expected ')' before '*' token /usr/include/pygtk-2.0/pygobject.h:78: error: expected ';' before 'void' mmkeys.c:16: error: expected '=', ',', ';', 'asm' or '__attribute__' before '*' token mmkeys.c:21: warning: data definition has no type or storage class mmkeys.c:21: error: expected ',' or ';' before 'PyMmKeys_Type' mmkeys.c:30: error: expected declaration specifiers or '...' before 'PyObject' mmkeys.c:30: error: expected declaration specifiers or '...' before 'PyObject' mmkeys.c: In function '_wrap_mmkeys_new': mmkeys.c:34: error: 'args' undeclared (first use in this function) mmkeys.c:34: error: (Each undeclared identifier is reported only once mmkeys.c:34: error: for each function it appears in.) mmkeys.c:34: error: 'kwargs' undeclared (first use in this function) mmkeys.c:39: error: 'struct _PyGObject_Functions' has no member named 'pygobject_constructv' mmkeys.c:40: error: 'PyGObject' has no member named 'obj' mmkeys.c:42: error: 'PyExc_RuntimeError' undeclared (first use in this function) mmkeys.c: At top level: mmkeys.c:49: warning: data definition has no type or storage class mmkeys.c:49: error: expected ',' or ';' before 'PyMmKeys_Type' mmkeys.c:98: error: expected '=', ',', ';', 'asm' or '__attribute__' before 'mmkeys_functions' mmkeys.c:104: error: expected ')' before '*' token make[1]: *** [mmkeyspy.o] Error 1 make[1]: Leaving directory `/builddir/build/BUILD/exaile_0.2.6/mmkeys' make: *** [mmkeys.so] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.14826 (%install) Maybe you need to add python-devel as BR. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Exaile! - A music player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220775 ------- Additional Comments From panemade(a)gmail.com 2006-12-28 02:39 EST ------- Same mock build errors i got. Then i removed patch and it worked well in mock build -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Exaile! - A music player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220775 ------- Additional Comments From dakingun(a)gmail.com 2006-12-28 11:12 EST ------- The patch is necessary for build on fedora devel. I've reworked the patch, and tested it on FC6 so it should be o.k. now I don't think adding license.txt to %doc is necessary, it just repeating what's been already specified in the spec, that the package is under GPL license. Spec URL: ftp://czar.eas.yorku.ca/pub/exaile/exaile.spec SRPM URL: ftp://czar.eas.yorku.ca/pub/exaile/exaile-0.2.6-3.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Exaile! - A music player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220775 ------- Additional Comments From dakingun(a)gmail.com 2006-12-29 00:45 EST ------- (In reply to comment #6) one can always do 'rpm -qi exaile | grep License' Note it says 'license text'; that file, license.txt, does not contain the license text, it only expresses what the license is. Thanks. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Exaile! - A music player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220775 panemade(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163778 |163779 nThis| | ------- Additional Comments From panemade(a)gmail.com 2006-12-29 00:55 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPMS. + source files match upstream. 05f8ad394f872f24c201d51687c96890 exaile_0.2.6.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text is not included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage exists + no .la files. + no translations are available + Dose owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + Desktop file installed successfully + Desktop file is handled correctly in SPEC file. + GUI app APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: Exaile! - A music player https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220775 dakingun(a)gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE ------- Additional Comments From dakingun(a)gmail.com 2006-12-29 01:10 EST ------- Imported into CVS. Thanks Parag. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.