https://bugzilla.redhat.com/show_bug.cgi?id=1084007
Bug ID: 1084007 Summary: Review Request: google-roboto-fonts - Google Roboto fonts Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: dtardon@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: http://dtardon.fedorapeople.org/rpm/google-roboto-fonts.spec SRPM URL: http://dtardon.fedorapeople.org/rpm/google-roboto-fonts-1.2-1.fc20.src.rpm Description: Roboto is a sans-serif typeface family introduced with Android Ice Cream Sandwich operating system. Google describes the font as "modern, yet approachable" and "emotional".
Fedora Account System Username: dtardon
https://bugzilla.redhat.com/show_bug.cgi?id=1084007
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@fedoraproject.org |panemade@gmail.com
https://bugzilla.redhat.com/show_bug.cgi?id=1084007
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review?
--- Comment #1 from Parag AN(पराग) panemade@gmail.com --- Issues:
1) It's better to use subpackage name -common and not -license. See http://fedoraproject.org/wiki/Fonts_spec_template_for_multiple_fonts suggests using -common for common files needed by all other packages.
2) Requires: fontpackages-filesystem is missing for -condensed-fonts subpackage.
The other simple way is to add it to -common and let -common be required by google-roboto-fonts and google-roboto-condensed-fonts. This way -common will provide LICENSE.txt file and you can also add RobotoSpecimenBook.pdf as a %doc
If you add -common then let it alone Requires: fontpackages-filesystem
3) Group tag is no longer needed.
4) Summary can be "Google Roboto fonts"
https://bugzilla.redhat.com/show_bug.cgi?id=1084007
David Tardon dtardon@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |dtardon@redhat.com
--- Comment #2 from David Tardon dtardon@redhat.com --- Spec URL: http://dtardon.fedorapeople.org/rpm/google-roboto-fonts.spec SRPM URL: http://dtardon.fedorapeople.org/rpm/google-roboto-fonts-1.2-2.fc20.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=1084007
Parag AN(पराग) panemade@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #3 from Parag AN(पराग) panemade@gmail.com --- Review:
+ Package built fine in mock on rawhide
+ rpmlint on generated rpms gave google-roboto-condensed-fonts.noarch: W: no-documentation google-roboto-fonts.noarch: W: no-documentation google-roboto-fonts.src: W: invalid-url Source0: http://developer.android.com/downloads/design/roboto-1.2.zip HTTP Error 405: Method Not Allowed 4 packages and 0 specfiles checked; 0 errors, 3 warnings.
+ Source verified with upstream as (sha256sum) source tarball:5101b5bdb3b7b14cc922a771ba068bfcae8634467c1f446bc89bc2b4f8b4f1b5 srpm tarball:5101b5bdb3b7b14cc922a771ba068bfcae8634467c1f446bc89bc2b4f8b4f1b5
+ fontconfig rules provided and follow fonts packaging guidelines.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=1084007
David Tardon dtardon@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #4 from David Tardon dtardon@redhat.com --- New Package SCM Request ======================= Package Name: google-roboto-fonts Short Description: Google Roboto fonts Owners: dtardon Branches: f19 f20 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1084007
--- Comment #5 from Parag AN(पराग) panemade@gmail.com --- I request please re-submit above request with addition as IntialCC: fonts-sig i18n-team
https://bugzilla.redhat.com/show_bug.cgi?id=1084007
--- Comment #6 from David Tardon dtardon@redhat.com --- New Package SCM Request ======================= Package Name: google-roboto-fonts Short Description: Google Roboto fonts Owners: dtardon Branches: f19 f20 InitialCC: fonts-sig i18n-team
https://bugzilla.redhat.com/show_bug.cgi?id=1084007
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1084007
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1084007
David Tardon dtardon@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Last Closed| |2014-04-07 08:58:17
https://bugzilla.redhat.com/show_bug.cgi?id=1084007
--- Comment #8 from Fedora Update System updates@fedoraproject.org --- google-roboto-fonts-2.138-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2017-30d4a534b6
https://bugzilla.redhat.com/show_bug.cgi?id=1084007
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |ERRATA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- google-roboto-fonts-2.138-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.
package-review@lists.fedoraproject.org
-
bugzilla＠redhat.com -
Red Hat Bugzilla