[Bug 1704522] New: Review Request: zork - Public Domain source code to the original DUNGEON game (Zork I)
10:07 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
Bug ID: 1704522
Summary: Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: low
Assignee: nobody(a)fedoraproject.org
Reporter: jflory7(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Hi, I am looking for a package review.
* Description: Public Domain source code to the original DUNGEON game (Zork I).
Released to the PD by Infocom. Includes source files, headers, and information.
This version of Dungeon was modified from FORTRAN to C. The original was
written in DEC FORTRAN, translated from MDL. It was then translated to f77 for
UN*X systems, from which it was translated to C. The C translation was done
with the help of f2c, the FORTRAN to C translator written by David Gay (AT&T
Bell Labs), Stu Feldman (Bellcore), Mark Maimone (Carnegie-Mellon University),
and Norm Schryer (AT&T Bell Labs).
* Fedora Account System Username: jflory7
The package is also successfully built in COPR and Koji scratch builds.
COPR URL: https://copr.fedorainfracloud.org/coprs/jflory7/zork/build/897220/
SPEC URL:
https://pagure.io/jflory7-rpm-specs/raw/master/f/rpmbuild/SPECS/zork.spec
SRPM URL:
https://pagure.io/jflory7-rpm-specs/raw/master/f/rpmbuild/SRPMS/zork-1.0....
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:09 a.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|nobody(a)fedoraproject.org |dominik(a)greysector.net
Flags| |fedora-review?
--- Comment #1 from Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net>
---
Fedora CFLAGS are not used during compilation, you can see it in the build.log:
[...]
cc -g -c -o ballop.o ballop.c
cc -g -c -o actors.o actors.c
cc -g -c -o demons.o demons.c
cc -g -c -o clockr.o clockr.c
cc -g -c -o dmain.o dmain.c
cc -g -c dgame.c
[...]
Instead of setting environment variables before calling make, set them on make
command line:
%build
%make_build \
CFLAGS="%{optflags}" \
DATADIR="%{_datadir}/%{name}" \
LDFLAGS="%{__global_ldflags}"
%install
%make_install \
BINDIR="%{buildroot}%{_bindir}" \
DATADIR="%{buildroot}%{_datadir}/%{name}/" \
LIBDIR="%{buildroot}%{_datadir}" \
MANDIR="%{buildroot}%{_mandir}"
With that, your makefile patch can be shortened to:
diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -42,7 +45,7 @@ TERMFLAG =
# Uncomment the following line if you want to have access to the game
# debugging tool. This is invoked by typing "gdt". It is not much
# use except for debugging.
-GDTFLAG = -DALLOW_GDT
+# GDTFLAG = -DALLOW_GDT
# Compilation flags
CFLAGS = -g #-static
@@ -69,7 +72,7 @@ dungeon: $(OBJS) dtextc.dat
$(CC) $(CFLAGS) -o zork $(OBJS) $(LIBS)
install: zork dtextc.dat
- mkdir -p $(BINDIR) $(LIBDIR) $(MANDIR)/man6
+ mkdir -p $(BINDIR) $(DATADIR) $(LIBDIR) $(MANDIR)/man6
cp zork $(BINDIR)
cp dtextc.dat $(DATADIR)
cp dungeon.6 $(MANDIR)/man6/
diff --git a/dinit.c b/dinit.c
index d687cf4..cda5878 100644
--- a/dinit.c
+++ b/dinit.c
@@ -24,7 +24,7 @@ FILE *dbfile;
#define TEXTFILE "lib:dtextc.dat"
#else /* ! __AMOS__ */
#ifdef unix
-#define TEXTFILE "/usr/games/lib/dunlib/dtextc.dat"
+#define TEXTFILE "/usr/share/zork/dtextc.dat"
#else /* ! unix */
I need a definition for TEXTFILE
#endif /* ! unix */
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:11 a.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #2 from Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net>
---
Please include README.md as %doc, too.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:46 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
Justin W. Flory <jflory7(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dominik(a)greysector.net
Flags| |needinfo?(dominik@greysecto
| |r.net)
--- Comment #3 from Justin W. Flory <jflory7(a)gmail.com> ---
Hi Dominik, thank you for reviewing. I pushed a new package release that
addresses your feedback:
COPR URL: https://copr.fedorainfracloud.org/coprs/jflory7/zork/build/898454/
SPEC URL:
https://pagure.io/jflory7-rpm-specs/raw/master/f/rpmbuild/SPECS/zork.spec
SRPM URL:
https://pagure.io/jflory7-rpm-specs/raw/master/f/rpmbuild/SRPMS/zork-1.0....
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:02 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #4 from Justin W. Flory <jflory7(a)gmail.com> ---
Hi Dominik, I think this package is ready. Could you please give another look?
Thank you.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:08 a.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
|needinfo?(dominik@greysecto |
|r.net) |
--- Comment #5 from Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net>
---
1. The manpage is dungeon(6) while the binary is called "zork". This makes the
manpage not discoverable easily. Please rename or at least add a link:
%install
...
echo ".so dungeon.6" > %{buildroot}%{_mandir}/man6/zork.6
%files
...
%{_mandir}/man6/zork.6*
2. There are tons of warnings from gcc in the build log. Some of them look
serious:
https://copr-be.cloud.fedoraproject.org/results/jflory7/zork/fedora-rawhi...
...
BUILDSTDERR: np.c:176:5: warning: array subscript -1 is outside array bounds of
'integer[40]' {aka 'int[40]'} [-Warray-bounds]
BUILDSTDERR: 176 | --outbuf;
BUILDSTDERR: | ^~~~~~~~
Please work with upstream to fix these.
3. The 'history' file could also be included as %doc. I missed that last time.
Apart from that, it looks good packaging-wise and is APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:34 a.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(jflory7(a)gmail.com
| |)
--- Comment #6 from Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net>
---
Ping?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:53 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
Justin W. Flory <jflory7(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(jflory7(a)gmail.com |
|) |
--- Comment #7 from Justin W. Flory <jflory7(a)gmail.com> ---
SPEC URL:
https://raw.githubusercontent.com/jwflory/rpmbuild/b82e9c1f8069c35f26827c...
SRPM URL:
https://github.com/jwflory/rpmbuild/blob/b82e9c1f8069c35f26827cd08b9e86cf...
So I finally got around to this. I was putting it off because I misread the gcc
warnings as blocking the review. I opened the ticket, noticed the fedora-review
flag was set, and felt quite silly. :-)
Going to move on with packaging this. I pushed a new package version to address
#1 and #3 of the above. I'll work on engaging with upstream to see if anything
can be done about #2. Dropping the needsinfo and will request a dist-git repo.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:59 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
Justin W. Flory <jflory7(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review+ |fedora-review?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:01 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
Justin W. Flory <jflory7(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags| |needinfo?(dominik@greysecto
| |r.net)
--- Comment #8 from Justin W. Flory <jflory7(a)gmail.com> ---
Hi Dominik, could you please re-review or set the fedora-review flag once more?
Today I learned there is a time quota on the fedora-review flag:
$ fedpkg request-repo zork 1704522
Could not execute request_repo: The Bugzilla bug's review was approved over 60
days ago
I'll get this packaged up once I can request the dist-git repo. Sorry to be a
bother.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:34 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|needinfo?(dominik@greysecto |fedora-review?
|r.net) |
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:35 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #9 from Dominik 'Rathann' Mierzejewski <dominik(a)greysector.net>
---
Approved again.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:34 a.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #10 from Igor Gnatenko <i.gnatenko.brain(a)gmail.com> ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/zork
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:05 a.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |MODIFIED
--- Comment #11 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2020-fee0637f32 has been submitted as an update to Fedora 32.
https://bodhi.fedoraproject.org/updates/FEDORA-2020-fee0637f32
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:18 a.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #12 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-EPEL-2020-7d28ec15d7 has been submitted as an update to Fedora EPEL 8.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-7d28ec15d7
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:57 a.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #13 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-EPEL-2020-bd24cabef2 has been submitted as an update to Fedora EPEL 7.
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-bd24cabef2
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:56 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |ON_QA
--- Comment #14 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-EPEL-2020-7d28ec15d7 has been pushed to the Fedora EPEL 8 testing
repository.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-7d28ec15d7
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:44 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #15 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-EPEL-2020-29d6c63c6c has been pushed to the Fedora EPEL 6 testing
repository.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-29d6c63c6c
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:52 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #16 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2020-fee0637f32 has been pushed to the Fedora 32 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-fee0637f32 \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-fee0637f32
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:40 a.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #17 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2020-32b0d57ff1 has been pushed to the Fedora 31 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-32b0d57ff1 \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-32b0d57ff1
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:41 a.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #18 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-EPEL-2020-bd24cabef2 has been pushed to the Fedora EPEL 7 testing
repository.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2020-bd24cabef2
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
5:13 a.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #19 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2020-2fbe3fb3b6 has been pushed to the Fedora 30 testing repository.
In short time you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing
--advisory=FEDORA-2020-2fbe3fb3b6 \*`
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2020-2fbe3fb3b6
See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information
on how to test updates.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:17 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
Last Closed| |2020-04-01 00:17:05
--- Comment #20 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2020-fee0637f32 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:55 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #21 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2020-32b0d57ff1 has been pushed to the Fedora 31 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:36 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #22 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2020-2fbe3fb3b6 has been pushed to the Fedora 30 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:32 a.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #23 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2020-fee0637f32 has been pushed to the Fedora 32 stable repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:35 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #24 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-EPEL-2020-7d28ec15d7 has been pushed to the Fedora EPEL 8 stable
repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:48 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #25 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-EPEL-2020-29d6c63c6c has been pushed to the Fedora EPEL 6 stable
repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:52 p.m.
New subject: [Bug 1704522] Review Request: zork - Public Domain source code to
the original DUNGEON game (Zork I)
https://bugzilla.redhat.com/show_bug.cgi?id=1704522
--- Comment #26 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-EPEL-2020-bd24cabef2 has been pushed to the Fedora EPEL 7 stable
repository.
If problem still persists, please make note of it in this bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1472
days inactive
1816
days old
package-review@lists.fedoraproject.org
28 comments
1 participants
participants (1)
-
bugzilla＠redhat.com