[Bug 1634014] New: Review Request: python-grpcio - A high performance, open-source universal RPC framework
7:43 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1634014
Bug ID: 1634014
Summary: Review Request: python-grpcio - A high performance,
open-source universal RPC framework
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: bochecha(a)daitauha.fr
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Spec URL: https://bochecha.fedorapeople.org/packages/python-grpcio.spec
SRPM URL:
https://bochecha.fedorapeople.org/packages/python-grpcio-1.15.0-1.fc28.sr...
Description:
A high performance, open-source universal RPC framework.
This package allows using gRPC in Python applications.
Fedora Account System Username: bochecha
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:44 a.m.
New subject: [Bug 1634014] Review Request: python-grpcio - A high performance,
open-source universal RPC framework
https://bugzilla.redhat.com/show_bug.cgi?id=1634014
--- Comment #1 from Mathieu Bridon <bochecha(a)daitauha.fr> ---
The license file is missing from the package, I requested upstream adds it in
future releases: https://github.com/grpc/grpc/issues/16732
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
7:48 a.m.
New subject: [Bug 1634014] Review Request: python-grpcio - A high performance,
open-source universal RPC framework
https://bugzilla.redhat.com/show_bug.cgi?id=1634014
Igor Gnatenko <i.gnatenko.brain(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |i.gnatenko.brain(a)gmail.com
Assignee|nobody(a)fedoraproject.org |i.gnatenko.brain(a)gmail.com
Flags| |fedora-review?
--- Comment #2 from Igor Gnatenko <i.gnatenko.brain(a)gmail.com> ---
Requires: python3-six >= 1.5.2
This should be moved to python3 subpackage.
* Missing BuildRequires: python3-setuptools
%{python3_sitearch}/grpc
%{python3_sitearch}/grpcio-%{version}-py*.egg-info
Add trailing slashes to indicate that those are directories.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
11:32 a.m.
New subject: [Bug 1634014] Review Request: python-grpcio - A high performance,
open-source universal RPC framework
https://bugzilla.redhat.com/show_bug.cgi?id=1634014
--- Comment #3 from Mathieu Bridon <bochecha(a)daitauha.fr> ---
New package:
Spec URL: https://bochecha.fedorapeople.org/packages/python-grpcio.spec
SRPM URL:
https://bochecha.fedorapeople.org/packages/python-grpcio-1.15.0-2.fc28.sr...
All your points should now be fixed:
diff --git a/python-grpcio.spec b/python-grpcio.spec
index 3b6bc7a..d54d596 100644
--- a/python-grpcio.spec
+++ b/python-grpcio.spec
@@ -6,7 +6,7 @@ License: ASL 2.0
URL: https://pypi.org/project/%{srcname}
Version: 1.15.0
-Release: 1%{?dist}
+Release: 2%{?dist}
Source0: %pypi_source
BuildRequires: gcc
@@ -18,10 +18,9 @@ BuildRequires: python3-devel >= 3.4
BuildRequires: zlib-devel
BuildRequires: python3-Cython
+BuildRequires: python3-setuptools
BuildRequires: python3-six >= 1.5.2
-Requires: python3-six >= 1.5.2
-
%description
A high performance, open-source universal RPC framework.
@@ -30,6 +29,7 @@ This package allows using gRPC in Python applications.
%package -n python3-%{srcname}
Summary: %{summary}
+Requires: python3-six >= 1.5.2
%{?python_provide:%python_provide python3-%{srcname}}
%description -n python3-%{srcname}
@@ -64,11 +64,16 @@ export GRPC_PYTHON_LDFLAGS="%{build_ldflags}"
%files -n python3-%{srcname}
%doc README.md
-%{python3_sitearch}/grpc
-%{python3_sitearch}/grpcio-%{version}-py*.egg-info
+%{python3_sitearch}/grpc/
+%{python3_sitearch}/grpcio-%{version}-py*.egg-info/
%changelog
+* Fri Sep 28 2018 Mathieu Bridon <bochecha(a)daitauha.fr> - 1.15.0-2
+- Added missing build requirement on python3-setuptools.
+- Moved a requirement to the right subpackage.
+- Added trailing slashes to installed directories.
+
* Fri Sep 28 2018 Mathieu Bridon <bochecha(a)daitauha.fr> - 1.15.0-1
- Update to the latest upstream release.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:06 p.m.
New subject: [Bug 1634014] Review Request: python-grpcio - A high performance,
open-source universal RPC framework
https://bugzilla.redhat.com/show_bug.cgi?id=1634014
Mathieu Bridon <bochecha(a)daitauha.fr> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |1634449
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1634449
[Bug 1634449] Review Request: buildstream - Build/integrate software stacks
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:34 a.m.
New subject: [Bug 1634014] Review Request: python-grpcio - A high performance,
open-source universal RPC framework
https://bugzilla.redhat.com/show_bug.cgi?id=1634014
--- Comment #4 from Mathieu Bridon <bochecha(a)daitauha.fr> ---
New package:
Spec URL: https://bochecha.fedorapeople.org/packages/python-grpcio.spec
SRPM URL:
https://bochecha.fedorapeople.org/packages/python-grpcio-1.16.0-1.fc28.sr...
diff --git a/python-grpcio.spec b/python-grpcio.spec
index d54d596..5b7ad36 100644
--- a/python-grpcio.spec
+++ b/python-grpcio.spec
@@ -5,8 +5,8 @@ Summary: A high performance, open-source universal RPC
framework
License: ASL 2.0
URL: https://pypi.org/project/%{srcname}
-Version: 1.15.0
-Release: 2%{?dist}
+Version: 1.16.0
+Release: 1%{?dist}
Source0: %pypi_source
BuildRequires: gcc
@@ -69,6 +69,9 @@ export GRPC_PYTHON_LDFLAGS="%{build_ldflags}"
%changelog
+* Tue Oct 30 2018 Mathieu Bridon <bochecha(a)daitauha.fr> - 1.16.0-1
+- Update to the latest upstream release.
+
* Fri Sep 28 2018 Mathieu Bridon <bochecha(a)daitauha.fr> - 1.15.0-2
- Added missing build requirement on python3-setuptools.
- Moved a requirement to the right subpackage.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:20 p.m.
New subject: [Bug 1634014] Review Request: python-grpcio - A high performance,
open-source universal RPC framework
https://bugzilla.redhat.com/show_bug.cgi?id=1634014
--- Comment #5 from Igor Gnatenko <i.gnatenko.brain(a)gmail.com> ---
Source0: %pypi_source
Source0: %{pypi_source}
BuildRequires: python3-devel >= 3.4
BuildRequires: python3-Cython
BuildRequires: python3-setuptools
BuildRequires: python3-six >= 1.5.2
Would be good to move this under python3- subpackage.
export GRPC_PYTHON_CFLAGS="%{build_cflags}"
I see that you BR gcc-c++, you also need to export CXXFLAGS.
---
Other than this, looks good.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:50 p.m.
New subject: [Bug 1634014] Review Request: python-grpcio - A high performance,
open-source universal RPC framework
https://bugzilla.redhat.com/show_bug.cgi?id=1634014
--- Comment #6 from Mathieu Bridon <bochecha(a)daitauha.fr> ---
> export GRPC_PYTHON_CFLAGS="%{build_cflags}"
I see that you BR gcc-c++, you also need to export CXXFLAGS.
They don't seem to use that at all in their build system.
It looks like they call their variable "GRPC_PYTHON_CFLAGS" and invoke the
compiler as "gcc", even though it really is C++ code. (and as such the BR on
gcc-c++ is required)
I can add an `export CXXFLAGS=%{build_cxxflags}` line if you really want me to,
but unless I missed something it's going to be entirely ignored by the build
process.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2:03 p.m.
New subject: [Bug 1634014] Review Request: python-grpcio - A high performance,
open-source universal RPC framework
https://bugzilla.redhat.com/show_bug.cgi?id=1634014
--- Comment #7 from Mathieu Bridon <bochecha(a)daitauha.fr> ---
New package:
Spec URL: https://bochecha.fedorapeople.org/packages/python-grpcio.spec
SRPM URL:
https://bochecha.fedorapeople.org/packages/python-grpcio-1.16.1-1.fc29.sr...
diff --git a/python-grpcio.spec b/python-grpcio.spec
index 5b7ad36..45fb699 100644
--- a/python-grpcio.spec
+++ b/python-grpcio.spec
@@ -5,22 +5,17 @@ Summary: A high performance, open-source universal RPC
framework
License: ASL 2.0
URL: https://pypi.org/project/%{srcname}
-Version: 1.16.0
+Version: 1.16.1
Release: 1%{?dist}
-Source0: %pypi_source
+Source0: %{pypi_source}
BuildRequires: gcc
BuildRequires: gcc-c++
BuildRequires: c-ares-devel
BuildRequires: openssl-devel
-BuildRequires: python3-devel >= 3.4
BuildRequires: zlib-devel
-BuildRequires: python3-Cython
-BuildRequires: python3-setuptools
-BuildRequires: python3-six >= 1.5.2
-
%description
A high performance, open-source universal RPC framework.
@@ -29,6 +24,10 @@ This package allows using gRPC in Python applications.
%package -n python3-%{srcname}
Summary: %{summary}
+BuildRequires: python3-devel >= 3.4
+BuildRequires: python3-Cython
+BuildRequires: python3-setuptools
+BuildRequires: python3-six >= 1.5.2
Requires: python3-six >= 1.5.2
%{?python_provide:%python_provide python3-%{srcname}}
@@ -69,6 +68,10 @@ export GRPC_PYTHON_LDFLAGS="%{build_ldflags}"
%changelog
+* Tue Dec 04 2018 Mathieu Bridon <bochecha(a)daitauha.fr> - 1.16.1-1
+- Update to the latest upstream release.
+- Move the build requirements to the appropriate subpackage.
+
* Tue Oct 30 2018 Mathieu Bridon <bochecha(a)daitauha.fr> - 1.16.0-1
- Update to the latest upstream release.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1971
days inactive
2038
days old
package-review@lists.fedoraproject.org
8 comments
1 participants
participants (1)
-
bugzilla＠redhat.com