[Bug 1706366] New: Review Request: gnome-shell-theme-flat-remix - Pretty simple theme inspired on material design
8:09 a.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1706366
Bug ID: 1706366
Summary: Review Request: gnome-shell-theme-flat-remix - Pretty
simple theme inspired on material design
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: ego.cordatus(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL:
https://atim.fedorapeople.org/for-review/gnome-shell-theme-flat-remix.spec
SRPM URL:
https://atim.fedorapeople.org/for-review/gnome-shell-theme-flat-remix-0.0...
Description:
Flat Remix GNOME theme is a pretty simple shell theme inspired on material
design following a modern design using "flat" colors with high contrasts and
sharp borders.
Themes:
• Flat Remix
• Flat Remix Dark
• Flat Remix Darkest
• Flat Remix Miami
• Flat Remix Miami Dark
Variants:
• Full Panel: No topbar spacing
Fedora Account System Username: atim
Working COPR: https://copr.fedorainfracloud.org/coprs/atim/flat-remix-theme
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:27 a.m.
New subject: [Bug 1706366] Review Request: gnome-shell-theme-flat-remix - Pretty
simple theme inspired on material design
https://bugzilla.redhat.com/show_bug.cgi?id=1706366
Markku Korkeala <markku.korkeala(a)iki.fi> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |markku.korkeala(a)iki.fi
--- Comment #1 from Markku Korkeala <markku.korkeala(a)iki.fi> ---
This is an unofficial review as I'm not official Fedora packager.
See Issues below:
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package installs a %{name}.desktop using desktop-file-install or
desktop-file-validate if there is such a file.
See https://docs.fedoraproject.org/en-US/packaging-guidelines/#_desktop_files
- Not sure why rpmlint warns about this, the URL works in the browser:
gnome-shell-theme-flat-remix.noarch: W: invalid-url URL:
https://drasite.com/flat-remix-gnome
<urlopen error [Errno -2] Name or service not known>
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Creative Commons Attribution-
ShareAlike Public License (v4.0)", "*No copyright* Creative Commons
Attribution-ShareAlike Public License (v4.0)". 644 files have unknown
license. Detailed output of licensecheck in
reviews/gnome-shell-theme-flat-remix
/review-gnome-shell-theme-flat-remix/licensecheck.txt
[x]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/gnome-shell/modes,
/usr/share/gnome-shell/theme
[ ]: Package must own all directories that it creates.
Note: Directories without known owners: /usr/share/gnome-shell/modes,
/usr/share/gnome-shell/theme
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[x]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[ ]: Package is not known to require an ExcludeArch tag.
[ ]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[ ]: Package functions as described.
[!]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[ ]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: gnome-shell-theme-flat-remix-0.0.20190428-1.fc31.noarch.rpm
gnome-shell-theme-flat-remix-0.0.20190428-1.fc31.src.rpm
gnome-shell-theme-flat-remix.noarch: W: spelling-error %description -l en_US
topbar -> top bar, top-bar, toolbar
gnome-shell-theme-flat-remix.src: W: spelling-error %description -l en_US
topbar -> top bar, top-bar, toolbar
gnome-shell-theme-flat-remix.src: W: no-%build-section
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages)
----------------------------
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "en_GB.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "en_GB.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
LANGUAGE = (unset),
LC_ALL = (unset),
LC_CTYPE = "C.UTF-8",
LANG = "en_GB.UTF-8"
are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").
sh: /usr/bin/python: No such file or directory
/usr/share/rpmlint/Pkg.py:168: UnicodeWarning: decode() called on unicode
string, see https://bugzilla.redhat.com/show_bug.cgi?id=1693751
s.decode('UTF-8')
gnome-shell-theme-flat-remix.noarch: W: spelling-error %description -l en_US
topbar -> top bar, top-bar, toolbar
gnome-shell-theme-flat-remix.noarch: W: invalid-url URL:
https://drasite.com/flat-remix-gnome <urlopen error [Errno -2] Name or service
not known>
1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Source checksums
----------------
https://github.com/daniruiz/flat-remix-gnome/archive/20190428.tar.gz#/gno...
:
CHECKSUM(SHA256) this package :
69b96a3c03a3bd3d23e22ced28d73817141f62d0699f286eee0e5db158d27d89
CHECKSUM(SHA256) upstream package :
69b96a3c03a3bd3d23e22ced28d73817141f62d0699f286eee0e5db158d27d89
Requires
--------
gnome-shell-theme-flat-remix (rpmlib, GLIBC filtered):
gnome-shell
Provides
--------
gnome-shell-theme-flat-remix:
gnome-shell-theme-flat-remix
Generated by fedora-review 0.7.2 (65d36bb) last change: 2019-04-09
Command line :/usr/bin/fedora-review -n gnome-shell-theme-flat-remix
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Haskell, R, Java, C/C++, Ocaml, PHP, SugarActivity, Perl,
Python, fonts
Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:36 p.m.
New subject: [Bug 1706366] Review Request: gnome-shell-theme-flat-remix - Pretty
simple theme inspired on material design
https://bugzilla.redhat.com/show_bug.cgi?id=1706366
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |zebob.m(a)gmail.com
Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com
Flags| |fedora-review?
--- Comment #2 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
- Bump to latest release
- You should own these dirs:
[ ]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/gnome-shell/modes,
/usr/share/gnome-shell/theme
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
Issues:
=======
- Package installs a %{name}.desktop using desktop-file-install or desktop-
file-validate if there is such a file.
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "Creative Commons Attribution-
ShareAlike Public License (v4.0)", "*No copyright* Creative Commons
Attribution-ShareAlike Public License (v4.0)". 644 files have unknown
license. Detailed output of licensecheck in
/home/bob/packaging/review/gnome-shell-theme-flat-remix/review-gnome-
shell-theme-flat-remix/licensecheck.txt
[!]: Package requires other packages for directories it uses.
Note: No known owner of /usr/share/gnome-shell/modes,
/usr/share/gnome-shell/theme
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic:
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: gnome-shell-theme-flat-remix-0.0.20190428-1.fc31.noarch.rpm
gnome-shell-theme-flat-remix-0.0.20190428-1.fc31.src.rpm
gnome-shell-theme-flat-remix.noarch: W: spelling-error %description -l en_US
topbar -> top bar, top-bar, toolbar
gnome-shell-theme-flat-remix.src: W: spelling-error %description -l en_US
topbar -> top bar, top-bar, toolbar
gnome-shell-theme-flat-remix.src: W: no-%build-section
2 packages and 0 specfiles checked; 0 errors, 3 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:29 p.m.
New subject: [Bug 1706366] Review Request: gnome-shell-theme-flat-remix - Pretty
simple theme inspired on material design
https://bugzilla.redhat.com/show_bug.cgi?id=1706366
--- Comment #3 from Artem <ego.cordatus(a)gmail.com> ---
@Markku Korkeala, apologize i missed email. 🤷🏻♂️
- Not sure why rpmlint warns about this, the URL works in the
browser:
gnome-shell-theme-flat-remix.noarch: W: invalid-url URL:
https://drasite.com/flat-remix-gnome
<urlopen error [Errno -2] Name or service not known>
Fine for me, but i noticed some maintainers have this issue too when reviewing.
@Robert, fixed.
Spec URL:
https://atim.fedorapeople.org/for-review/gnome-shell-theme-flat-remix.spec
SRPM URL:
https://atim.fedorapeople.org/for-review/gnome-shell-theme-flat-remix-0.0...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:42 a.m.
New subject: [Bug 1706366] Review Request: gnome-shell-theme-flat-remix - Pretty
simple theme inspired on material design
https://bugzilla.redhat.com/show_bug.cgi?id=1706366
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |POST
Flags|fedora-review? |fedora-review+
--- Comment #4 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
Package approved.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
4:44 a.m.
New subject: [Bug 1706366] Review Request: gnome-shell-theme-flat-remix - Pretty
simple theme inspired on material design
https://bugzilla.redhat.com/show_bug.cgi?id=1706366
--- Comment #5 from Igor Gnatenko <i.gnatenko.brain(a)gmail.com> ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/gnome-shell-theme-flat-remix
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:19 a.m.
New subject: [Bug 1706366] Review Request: gnome-shell-theme-flat-remix - Pretty
simple theme inspired on material design
https://bugzilla.redhat.com/show_bug.cgi?id=1706366
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |MODIFIED
--- Comment #6 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2019-826f325d63 has been submitted as an update to Fedora 30.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-826f325d63
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
10:19 a.m.
New subject: [Bug 1706366] Review Request: gnome-shell-theme-flat-remix - Pretty
simple theme inspired on material design
https://bugzilla.redhat.com/show_bug.cgi?id=1706366
--- Comment #7 from Fedora Update System <updates(a)fedoraproject.org> ---
FEDORA-2019-ce77cff080 has been submitted as an update to Fedora 29.
https://bodhi.fedoraproject.org/updates/FEDORA-2019-ce77cff080
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:35 p.m.
New subject: [Bug 1706366] Review Request: gnome-shell-theme-flat-remix - Pretty
simple theme inspired on material design
https://bugzilla.redhat.com/show_bug.cgi?id=1706366
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|MODIFIED |ON_QA
--- Comment #8 from Fedora Update System <updates(a)fedoraproject.org> ---
gnome-shell-theme-flat-remix-0.0.20190530-1.fc30 has been pushed to the Fedora
30 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-826f325d63
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:12 a.m.
New subject: [Bug 1706366] Review Request: gnome-shell-theme-flat-remix - Pretty
simple theme inspired on material design
https://bugzilla.redhat.com/show_bug.cgi?id=1706366
--- Comment #9 from Fedora Update System <updates(a)fedoraproject.org> ---
gnome-shell-theme-flat-remix-0.0.20190530-1.fc29 has been pushed to the Fedora
29 testing repository. If problems still persist, please make note of it in
this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here:
https://bodhi.fedoraproject.org/updates/FEDORA-2019-ce77cff080
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1:28 p.m.
New subject: [Bug 1706366] Review Request: gnome-shell-theme-flat-remix - Pretty
simple theme inspired on material design
https://bugzilla.redhat.com/show_bug.cgi?id=1706366
Fedora Update System <updates(a)fedoraproject.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
Last Closed| |2019-06-17 18:28:04
--- Comment #10 from Fedora Update System <updates(a)fedoraproject.org> ---
gnome-shell-theme-flat-remix-0.0.20190530-1.fc30 has been pushed to the Fedora
30 stable repository. If problems still persist, please make note of it in this
bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:33 p.m.
New subject: [Bug 1706366] Review Request: gnome-shell-theme-flat-remix - Pretty
simple theme inspired on material design
https://bugzilla.redhat.com/show_bug.cgi?id=1706366
--- Comment #11 from Fedora Update System <updates(a)fedoraproject.org> ---
gnome-shell-theme-flat-remix-0.0.20190530-1.fc29 has been pushed to the Fedora
29 stable repository. If problems still persist, please make note of it in this
bug report.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1826
days inactive
1870
days old
package-review@lists.fedoraproject.org
11 comments
1 participants
participants (1)
-
bugzilla＠redhat.com