Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: rb_libtorrent - A C++ BitTorrent library aiming to be the best alternative

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221372

peter@thecodergeek.com changed:

What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |221376 nThis| |

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: rb_libtorrent - A C++ BitTorrent library aiming to be the best alternative Alias: rb_libtorrent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221372

------- Additional Comments From peter@thecodergeek.com 2007-01-06 03:03 EST ------- Additionally, the -devel subpackage installs a .pc file, so it should require pkgconfig. I've added that in release 2.

The .spec file is at the same URL; and the source RPM is at http://www.thecodergeek.com/downloads/fedora/rb_libtorrent-0.11-2.src.rpm

Thanks.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: rb_libtorrent - A C++ BitTorrent library aiming to be the best alternative Alias: rb_libtorrent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221372

------- Additional Comments From peter@thecodergeek.com 2007-01-17 15:37 EST -------

Re-check "License:" as it is _not_ GPL.

Gaah. I just copied that from the Gentoo ebuild without verifying it. Thanks for the catch.

IMO this conflict is unacceptable. Actually, "libtorrent" is libtorrent.so.9, this one is libtorrent.so.0, and "libtorrent-devel" uses /usr/include/torrent/ while this one uses /usr/include/libtorrent/. So, theoretically they could even co-exist at this point of time, provided that they got some love from upstream. But so far, the rename is half-hearted.

On further investigation, only some of the -devel files conflict (libtorrent.pc and the unsuffixed libtorrent.so symlink). I'll make only the -devel subpackage conflict with that of libtorrent, then.

For a library package and the limited /usr/bin namespace, these two file names are far too generic. They ought to be moved or renamed.

Well, these binaries are actually just examples of what can be done with this libtorrent. Would they be better suited as %doc perhaps?

The file COPYING is included in the main package already.

Perhaps; but as a matter of personal preference and to keep things explicitly clear, I prefer to package such files as %doc for every subpackage in a build.

This file is tuned for static linking, unfortunately, in that it links libraries which libtorrent.so.0 is linked against already.

Hmm. I was under the [apparently mistaken] impression that forcing the use of the system zlib would offset that from the ./configure script. A patch is underway.

...

Requires: openssl-devel

Where do you see this requirement?

Several OpenSSL headers are used via #include directives from files in the /include/libtorrent/asio/ssl directory (used for asynchronous SSL handshaking and whatnot). Thus, I have it pull in openssl-devel so that any potential build finds those headers as well.

When I home this evening, I'll bug upstream about the dump_torrent/make_torrent naming, as well as fix the issues presented in your comment.

Thanks.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: rb_libtorrent - A C++ BitTorrent library aiming to be the best alternative Alias: rb_libtorrent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221372

------- Additional Comments From bugs.michael@gmx.net 2007-01-18 08:03 EST -------

/include/libtorrent/asio/ssl

Ah, yes.

$ grep Libs /usr/lib/pkgconfig/libtorrent.pc Libs: -L${libdir} -lz -lboost_date_time -lboost_filesystem -lboost_thread -lz -ltorrent

should read:

$ grep Libs /usr/lib/pkgconfig/libtorrent.pc Libs: -L${libdir} -ltorrent

Because libtorrent is linked against zlib and boost already, see: ldd /usr/lib/libtorrent.so.0

Not a big issue, though. The pkgconfig file should tell what is necessary to compile with and link with libtorrent, not tell what libtorrent was built with. This is a mistake done by several upstream projects. They squeeze everything, which was used for building libtorrent, into the "Libs" line. The full set of -lfoo options is only needed for static linking (or special forms of linking).

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: rb_libtorrent - A C++ BitTorrent library aiming to be the best alternative Alias: rb_libtorrent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221372

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-26 04:48 EST ------- Before checking this..

Can't the conflict between libtorrent <-> this package be avoided simply by moving * /usr/lib/libtorrent.so -> /usr/lib/librb_torrent.so * /usr/lib/pkgconfig/libtorrent.pc -> /usr/lib/pkgconfig/librb_torrent.pc ?

I don't want to make use of "conflict" simply because the file entry duplicates when some seemingly-easy solution exists, because this type of file conflicts always occur on making compat version rpm.

Would you consider to aviod using conflict by renaming? I also suggest when you agree, the "real" dynamic library "/usr/lib/libtorrent.so.0.1.0" and the header directory "/usr/include/libtorrent" should be renamed as such.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: rb_libtorrent - A C++ BitTorrent library aiming to be the best alternative Alias: rb_libtorrent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221372

------- Additional Comments From mtasaka@ioa.s.u-tokyo.ac.jp 2007-01-27 12:26 EST ------- Well, for 0.11-3:

* License: - Well, some sources are not licensed under BSD.

A. Some files are under the Boost Software License (perhaps okay) [under include/libtorrent/]: asio.hpp asio/*.hpp asio/*/*.hpp invariant_check.cpp

B. Need some verification [under include/libtorrent/] utf8.hpp ------------------------------------------------------ 1. The origin of this software must not be misrepresented; you must not claim that you wrote the original software. If you use this software in a product, an acknowledgment in the product documentation would be appreciated but is not required. 2. Altered source versions must be plainly marked as such, and must not be misrepresented as being the original software. 3. This notice may not be removed or altered from any source distribution. -------------------------------------------------------

* Fedora specific documentation - Please include your name.

* Timestamps - This package try to install many text files/image files and in that case keeping on those files are preferable. For this package please: -------------------------------------------------------- %install rm -rf %{buildroot} export CPPROG="%{__cp} -p" make install DESTDIR=%{buildroot} INSTALL="%{__install} -c -p" --------------------------------------------------------

* Requires, etc /usr/lib/pkgconfig/libtorrent.pc includes: -------------------------------------------------------- Libs: -L${libdir} -lz -lboost_date_time -lboost_filesystem -lboost_thread -lz -ltorrent -------------------------------------------------------- * I doubt that addtional linkage is needed as

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: rb_libtorrent - A C++ BitTorrent library aiming to be the best alternative Alias: rb_libtorrent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221372

------- Additional Comments From peter@thecodergeek.com 2007-01-27 17:58 EST ------- I've noted the separate licenses; but AFAICT they all are very similar to the BSD license (mostly "do what you want with the code, so long as the original authors' copyrights are left intact and the license text is not altered")

• Fedora specific documentation
  • Please include your name.

Fixed in release 4.

• Timestamps
  • This package try to install many text files/image files and in that case keeping on those files are preferable. For this package please:

---

Fixed in release 4.

• Requires, etc /usr/lib/pkgconfig/libtorrent.pc includes:

---

Libs: -L${libdir} -lz -lboost_date_time -lboost_filesystem -lboost_thread -lz

-ltorrent

• I doubt that addtional linkage is needed as

Ah I see. Since we're linking against the system zlib, both the the @ZLIB@ and @LIBS@ macros in the input file are expanded to contain '-lz' in the final libtorrent.pc file. I've fixed this in release 4.

Spec: http:/thecodergeek.com/downloads/fedora/rb_libtorrent.spec SRPM: http:/thecodergeek.com/downloads/fedora/rb_libtorrent-0.11-4.src.rpm

Thanks for your time and comments!

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: rb_libtorrent - A C++ BitTorrent library aiming to be the best alternative Alias: rb_libtorrent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221372

------- Additional Comments From bugs.michael@gmx.net 2007-01-28 12:31 EST ------- Bottom of comment 6 still holds true, doesn't it?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: rb_libtorrent - A C++ BitTorrent library aiming to be the best alternative Alias: rb_libtorrent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221372

------- Additional Comments From bugs.michael@gmx.net 2007-01-28 12:55 EST -------

because Peter seemed to have some reasons,

Not documented in this ticket. What are those reasons?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: rb_libtorrent - A C++ BitTorrent library aiming to be the best alternative Alias: rb_libtorrent

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221372

------- Additional Comments From peter@thecodergeek.com 2007-01-28 14:23 EST ------- (In reply to comment #17)

Ack. I already imported it and submitted it to the build system for devel (job 26582). >_>

I will fix this in CVS and submit a new build. Thanks; and sorry for the slight misunderstanding!

Fixed in 0.11-5 (job 26587). Thanks!!