Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: <ConozcoNicaragua> - <1>
https://bugzilla.redhat.com/show_bug.cgi?id=708663
Summary: Review Request: <ConozcoNicaragua> - <1> Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: unspecified Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: germanrs@fedoraproject.org QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora Story Points: ---
Spec URL: http://germanrs.fedorapeople.org/Sugar/conozco-nicaragua.spec SRPM http://germanrs.fedorapeople.org/Sugar/ConozcoNicaragua-1-1.fc15.src.rpm
Description: A Sugar Activity for teaching geography of Nicaragua... It's an application for SoaS...
------------------------------------------------------------------------------ [makerpm@fedora-laptop SRPMS]$ rpmlint -i ConozcoNicaragua-1-1.fc15.src.rpm ConozcoNicaragua.src: W: non-standard-group Sugar/Activities The value of the Group tag in the package is not valid. Valid groups are: "Amusements/Games", "Amusements/Graphics", "Applications/Archiving", "Applications/Communications", "Applications/Databases", "Applications/Editors", "Applications/Emulators", "Applications/Engineering", "Applications/File", "Applications/Internet", "Applications/Multimedia", "Applications/Productivity", "Applications/Publishing", "Applications/System", "Applications/Text", "Development/Debug", "Development/Debuggers", "Development/Languages", "Development/Libraries", "Development/System", "Development/Tools", "Documentation", "System Environment/Base", "System Environment/Daemons", "System Environment/Kernel", "System Environment/Libraries", "System Environment/Shells", "Unspecified", "User Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".
ConozcoNicaragua.src: W: no-version-in-last-changelog The latest changelog entry doesn't contain a version. Please insert the version that is coherent with the version of the package and rebuild it.
ConozcoNicaragua.src:8: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 8) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.
1 packages and 0 specfiles checked; 0 errors, 3 warnings.
------------------------------------------------------------------------------ [makerpm@fedora-laptop SPECS]$ rpmlint -i ConozcoNicaragua.spec ConozcoNicaragua.spec:5: W: non-standard-group Sugar/Activities The value of the Group tag in the package is not valid. Valid groups are: "Amusements/Games", "Amusements/Graphics", "Applications/Archiving", "Applications/Communications", "Applications/Databases", "Applications/Editors", "Applications/Emulators", "Applications/Engineering", "Applications/File", "Applications/Internet", "Applications/Multimedia", "Applications/Productivity", "Applications/Publishing", "Applications/System", "Applications/Text", "Development/Debug", "Development/Debuggers", "Development/Languages", "Development/Libraries", "Development/System", "Development/Tools", "Documentation", "System Environment/Base", "System Environment/Daemons", "System Environment/Kernel", "System Environment/Libraries", "System Environment/Shells", "Unspecified", "User Interface/Desktops", "User Interface/X", "User Interface/X Hardware Support".
ConozcoNicaragua.spec:8: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 8) The specfile mixes use of spaces and tabs for indentation, which is a cosmetic annoyance. Use either spaces or tabs for indentation, not both.
0 packages and 1 specfiles checked; 0 errors, 2 warnings. -------------------------------------------------------------------------------
This is my firt packages, so i need to be sponsored...
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708663
German Ruiz germanrs@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841(FE-NEEDSPONSOR)
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708663
--- Comment #1 from German Ruiz germanrs@fedoraproject.org 2011-05-28 14:48:42 EDT --- New changes in ConozcoNicaragua.spec
http://germanrs.fedorapeople.org/Sugar/ConozcoNicaragua-1-2.fc15.src.rpm
http://germanrs.fedorapeople.org/Sugar/ConozcoNicaragua.spec
- Changes in Groups and fixed the warning of mixed use of spaces and tabs
[makerpm@fedora-laptop SPECS]$ rpmlint -i ConozcoNicaragua.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[makerpm@fedora-laptop SRPMS]$ rpmlint -i ConozcoNicaragua-1-2.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708663
--- Comment #2 from German Ruiz germanrs@fedoraproject.org 2011-05-28 16:21:44 EDT --- New changes in ConozcoNicaragua.spec
http://germanrs.fedorapeople.org/Sugar/ConozcoNicaragua-1-3.fc15.src.rpm
http://germanrs.fedorapeople.org/Sugar/ConozcoNicaragua.spec
- Fixed some permission files...
Here is the Output of rpmlint
[makerpm@fedora-laptop SPECS]$ rpmlint -i ConozcoNicaragua.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[makerpm@fedora-laptop SRPMS]$ rpmlint ConozcoNicaragua-1-3.fc15.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[makerpm@fedora-laptop noarch]$ rpmlint -i ConozcoNicaragua-1-3.fc15.noarch.rpm ConozcoNicaragua.noarch: E: non-executable-script /usr/share/sugar/activities/ConozcoNicaragua.activity/olpcgames/buildmanifest.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.
ConozcoNicaragua.noarch: E: non-executable-script /usr/share/sugar/activities/ConozcoNicaragua.activity/setup.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.
ConozcoNicaragua.noarch: E: non-executable-script /usr/share/sugar/activities/ConozcoNicaragua.activity/conozcouy.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.
ConozcoNicaragua.noarch: E: non-executable-script /usr/share/sugar/activities/ConozcoNicaragua.activity/run.py 0644L /usr/bin/env This text file contains a shebang or is located in a path dedicated for executables, but lacks the executable bits and cannot thus be executed. If the file is meant to be an executable script, add the executable bits, otherwise remove the shebang or move the file elsewhere.
1 packages and 0 specfiles checked; 4 errors, 0 warnings.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708663
Terje Røsten terjeros@phys.ntnu.no changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@phys.ntnu.no Summary|Review Request: |Review Request: |<ConozcoNicaragua> - <1> |ConozcoNicaragua - | |Geographycal Activity for | |Sugar
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708663
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@bernewireless.net
--- Comment #3 from Fabian Affolter fabian@bernewireless.net 2011-05-31 04:43:07 EDT --- As far as I know are all sugar activities named like sugar-[activitiy name]. Why not just remove the shebangs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708663
--- Comment #4 from Fabian Affolter fabian@bernewireless.net 2011-05-31 04:43:33 EDT --- More details about sugar packages: https://fedoraproject.org/wiki/Packaging:SugarActivityGuidelines
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708663
--- Comment #5 from German Ruiz germanrs@fedoraproject.org 2011-06-05 14:33:49 EDT --- Updated name and changed the Group to Sugar/Activities
Spec: http://germanrs.fedorapeople.org/Sugar/sugar-conozco_nicaragua.spec
SRPM: http://germanrs.fedorapeople.org/Sugar/sugar-conozco_nicaragua-1-5.fc15.src....
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=708663
Fabian Affolter fabian@bernewireless.net changed:
What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |ConozcoNicaragua - |sugar-conozco_nicaragua - |Geographycal Activity for |Geographycal Activity for |Sugar |Sugar
package-review@lists.fedoraproject.org
-
Red Hat Bugzilla