3:42 p.m.
https://bugzilla.redhat.com/show_bug.cgi?id=1836686
Bug ID: 1836686
Summary: Review Request: python-gcsfs - Convenient Filesystem
interface over GCS
Product: Fedora
Version: rawhide
Hardware: All
OS: Linux
Status: NEW
Component: Package Review
Severity: medium
Priority: medium
Assignee: nobody(a)fedoraproject.org
Reporter: mail(a)fabian-affolter.ch
QA Contact: extras-qa(a)fedoraproject.org
CC: package-review(a)lists.fedoraproject.org
Target Milestone: ---
Classification: Fedora
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-gcsfs.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-gcsfs-0.6.2-1.fc31.src...
Project URL: https://github.com/dask/gcsfs
Description:
Pythonic file-system for Google Cloud Storage.
Koji scratch build:
Missing dependency
rpmlint output:
$ rpmlint python-gcsfs-0.6.2-1.fc31.src.rpm
python-gcsfs.src: W: spelling-error %description -l en_US Pythonic -> Python
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
$ rpmlint python3-gcsfs-0.6.2-1.fc31.noarch.rpm
python3-gcsfs.noarch: W: spelling-error %description -l en_US Pythonic ->
Python
1 packages and 0 specfiles checked; 0 errors, 1 warnings.
Fedora Account System Username: fab
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:42 p.m.
New subject: [Bug 1836686] Review Request: python-gcsfs - Convenient Filesystem
interface over GCS
https://bugzilla.redhat.com/show_bug.cgi?id=1836686
Fabian Affolter <mail(a)fabian-affolter.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends On| |1836663
Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1836663
[Bug 1836663] Review Request: python-google-auth-oauthlib - Google oAuth
Authentication Library
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:06 a.m.
New subject: [Bug 1836686] Review Request: python-gcsfs - Convenient Filesystem
interface over GCS
https://bugzilla.redhat.com/show_bug.cgi?id=1836686
Robert-André Mauchin <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zebob.m(a)gmail.com
--- Comment #1 from Robert-André Mauchin <zebob.m(a)gmail.com> ---
- You need to add Sphinx-rtd-theme:
+ sphinx-build-3 docs/source html
Running Sphinx v2.2.2
Configuration error:
There is a programmable error in your configuration file:
Traceback (most recent call last):
File "/usr/lib/python3.9/site-packages/sphinx/config.py", line 361, in
eval_config_file
execfile_(filename, namespace)
File "/usr/lib/python3.9/site-packages/sphinx/util/pycompat.py", line 81, in
execfile_
exec(code, _globals)
File "/builddir/build/BUILD/gcsfs-0.6.2/docs/source/conf.py", line 124, in
<module>
import sphinx_rtd_theme
ModuleNotFoundError: No module named 'sphinx_rtd_theme'
BuildRequires: python3-sphinx
BuildRequires: python3-sphinx_rtd_theme
BuildRequires: python3-numpydoc
- Tests fail due to missing a dep:
pytest-3.9 -v gcsfs/tests -k 'not test_request_header'
============================= test session starts
==============================
platform linux -- Python 3.9.0b3, pytest-5.4.3, py-1.8.2, pluggy-0.13.1 --
/usr/bin/python3
cachedir: .pytest_cache
rootdir: /builddir/build/BUILD/gcsfs-0.6.2
collecting ... collected 0 items / 4 errors
==================================== ERRORS
====================================
__________________ ERROR collecting gcsfs/tests/test_core.py
___________________
ImportError while importing test module
'/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/tests/test_core.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
gcsfs/tests/test_core.py:23: in <module>
from gcsfs.tests.utils import (
gcsfs/tests/utils.py:20: in <module>
import vcr
E ModuleNotFoundError: No module named 'vcr'
__________________ ERROR collecting gcsfs/tests/test_fuse.py
___________________
ImportError while importing test module
'/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/tests/test_fuse.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
gcsfs/tests/test_fuse.py:8: in <module>
from gcsfs.tests.utils import gcs_maker, my_vcr
gcsfs/tests/utils.py:20: in <module>
import vcr
E ModuleNotFoundError: No module named 'vcr'
_________________ ERROR collecting gcsfs/tests/test_mapping.py
_________________
ImportError while importing test module
'/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/tests/test_mapping.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
gcsfs/tests/test_mapping.py:3: in <module>
from gcsfs.tests.utils import my_vcr, gcs_maker
gcsfs/tests/utils.py:20: in <module>
import vcr
E ModuleNotFoundError: No module named 'vcr'
__________________ ERROR collecting gcsfs/tests/test_utils.py
__________________
ImportError while importing test module
'/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/tests/test_utils.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
gcsfs/tests/test_utils.py:6: in <module>
from gcsfs.tests.utils import tmpfile
gcsfs/tests/utils.py:20: in <module>
import vcr
E ModuleNotFoundError: No module named 'vcr'
=========================== short test summary info
============================
ERROR gcsfs/tests/test_core.py
ERROR gcsfs/tests/test_fuse.py
ERROR gcsfs/tests/test_mapping.py
ERROR gcsfs/tests/test_utils.py
!!!!!!!!!!!!!!!!!!! Interrupted: 4 errors during collection
!!!!!!!!!!!!!!!!!!!!
============================== 4 errors in 0.56s
===============================
Add:
BuildRequires: python3-vcrpy
- Multiple tests then fail too:
=================================== FAILURES
===================================
_______________________________ test_map_simple
________________________________
@my_vcr.use_cassette(match=["all"])
def test_map_simple():
with gcs_maker() as gcs:
d = gcs.get_mapper(root)
assert not d
assert list(d) == list(d.keys()) == []
assert list(d.values()) == []
gcsfs/tests/test_mapping.py:25:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/usr/lib64/python3.9/_collections_abc.py:784: in __iter__
for key in self._mapping:
/usr/lib/python3.9/site-packages/fsspec/mapping.py:98: in __iter__
return (self._str_to_key(x) for x in self.fs.find(self.root))
/usr/lib/python3.9/site-packages/fsspec/spec.py:394: in find
for path, dirs, files in self.walk(path, maxdepth, detail=True, **kwargs):
/usr/lib/python3.9/site-packages/fsspec/spec.py:343: in walk
listing = self.ls(path, detail=True, **kwargs)
gcsfs/core.py:767: in ls
out = self._list_objects(path)
gcsfs/core.py:571: in _list_objects
items, prefixes = self._do_list_objects(path)
gcsfs/core.py:598: in _do_list_objects
page = self._call(
gcsfs/core.py:478: in _call
r = self.session.request(
/usr/lib/python3.9/site-packages/google/auth/transport/requests.py:444: in
request
response = super(AuthorizedSession, self).request(
/usr/lib/python3.9/site-packages/requests/sessions.py:530: in request
resp = self.send(prep, **send_kwargs)
/usr/lib/python3.9/site-packages/requests/sessions.py:643: in send
r = adapter.send(request, **kwargs)
/usr/lib/python3.9/site-packages/requests/adapters.py:439: in send
resp = conn.urlopen(
/usr/lib/python3.9/site-packages/urllib3/connectionpool.py:665: in urlopen
httplib_response = self._make_request(
/usr/lib/python3.9/site-packages/urllib3/connectionpool.py:412: in
_make_request
httplib_response = conn.getresponse(buffering=True)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self =
<vcr.patch.VCRRequestsHTTPSConnection/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/tests/recordings/test_map_simple.yaml
object at 0x7f27002e1280>
_ = False, kwargs = {'buffering': True}
def getresponse(self, _=False, **kwargs):
"""Retrieve the response"""
# Check to see if the cassette has a response for this request. If so,
# then return it
if self.cassette.can_play_response_for(self._vcr_request):
log.info("Playing response for {} from
cassette".format(self._vcr_request))
response = self.cassette.play_response(self._vcr_request)
return VCRHTTPResponse(response)
else:
if self.cassette.write_protected and
self.cassette.filter_request(self._vcr_request):
raise CannotOverwriteExistingCassetteException(
cassette=self.cassette, failed_request=self._vcr_request
)
E vcr.errors.CannotOverwriteExistingCassetteException: Can't
overwrite existing cassette
('/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/tests/recordings/test_map_simple.yaml')
in your current record mode ('none').
E No match for the request (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>)
was found.
E Found 18 similar requests with 0 different matcher(s) :
E
E 1 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 2 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 3 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 4 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 5 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 6 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 7 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 8 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 9 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 10 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 11 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 12 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 13 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 14 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 15 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 16 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 17 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 18 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
/usr/lib/python3.9/site-packages/vcr/stubs/__init__.py:231:
CannotOverwriteExistingCassetteException
------------------------------ Captured log call
-------------------------------
ERROR gcsfs.core:core.py:503 _call non-retriable exception: You already own
this bucket. Please select another name.
Traceback (most recent call last):
File "/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/core.py", line 487, in _call
validate_response(r, path)
File "/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/core.py", line 130, in
validate_response
raise HttpError(error)
gcsfs.utils.HttpError: You already own this bucket. Please select another name.
WARNING urllib3.connectionpool:connectionpool.py:443 Failed to parse headers
(url=https://www.googleapis.com:443/batch/storage/v1):
[StartBoundaryNotFoundDefect(), MultipartInvariantViolationDefect()], unparsed
data: ''
Traceback (most recent call last):
File "/usr/lib/python3.9/site-packages/urllib3/connectionpool.py", line 441,
in _make_request
assert_header_parsing(httplib_response.msg)
File "/usr/lib/python3.9/site-packages/urllib3/util/response.py", line 71, in
assert_header_parsing
raise HeaderParsingError(defects=defects, unparsed_data=unparsed_data)
urllib3.exceptions.HeaderParsingError: [StartBoundaryNotFoundDefect(),
MultipartInvariantViolationDefect()], unparsed data: ''
______________________________ test_map_with_data
______________________________
@my_vcr.use_cassette(match=["all"])
def test_map_with_data():
with gcs_maker() as gcs:
d = gcs.get_mapper(root)
d["x"] = b"123"
assert list(d) == list(d.keys()) == ["x"]
assert list(d.values()) == [b"123"]
assert list(d.items()) == [("x", b"123")]
assert d["x"] == b"123"
assert bool(d)
assert gcs.find(root) == [TEST_BUCKET + "/mapping/x"]
d["x"] = b"000"
assert d["x"] == b"000"
d["y"] = b"456"
assert d["y"] == b"456"
assert set(d) == {"x", "y"}
d.clear()
assert list(d) == []
gcsfs/tests/test_mapping.py:68:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/usr/lib/python3.9/site-packages/fsspec/mapping.py:101: in __len__
return len(self.fs.find(self.root))
/usr/lib/python3.9/site-packages/fsspec/spec.py:394: in find
for path, dirs, files in self.walk(path, maxdepth, detail=True, **kwargs):
/usr/lib/python3.9/site-packages/fsspec/spec.py:343: in walk
listing = self.ls(path, detail=True, **kwargs)
gcsfs/core.py:767: in ls
out = self._list_objects(path)
gcsfs/core.py:571: in _list_objects
items, prefixes = self._do_list_objects(path)
gcsfs/core.py:598: in _do_list_objects
page = self._call(
gcsfs/core.py:478: in _call
r = self.session.request(
/usr/lib/python3.9/site-packages/google/auth/transport/requests.py:444: in
request
response = super(AuthorizedSession, self).request(
/usr/lib/python3.9/site-packages/requests/sessions.py:530: in request
resp = self.send(prep, **send_kwargs)
/usr/lib/python3.9/site-packages/requests/sessions.py:643: in send
r = adapter.send(request, **kwargs)
/usr/lib/python3.9/site-packages/requests/adapters.py:439: in send
resp = conn.urlopen(
/usr/lib/python3.9/site-packages/urllib3/connectionpool.py:665: in urlopen
httplib_response = self._make_request(
/usr/lib/python3.9/site-packages/urllib3/connectionpool.py:412: in
_make_request
httplib_response = conn.getresponse(buffering=True)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self =
<vcr.patch.VCRRequestsHTTPSConnection/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/tests/recordings/test_map_with_data.yaml
object at 0x7f2723d3ef70>
_ = False, kwargs = {'buffering': True}
def getresponse(self, _=False, **kwargs):
"""Retrieve the response"""
# Check to see if the cassette has a response for this request. If so,
# then return it
if self.cassette.can_play_response_for(self._vcr_request):
log.info("Playing response for {} from
cassette".format(self._vcr_request))
response = self.cassette.play_response(self._vcr_request)
return VCRHTTPResponse(response)
else:
if self.cassette.write_protected and
self.cassette.filter_request(self._vcr_request):
raise CannotOverwriteExistingCassetteException(
cassette=self.cassette, failed_request=self._vcr_request
)
E vcr.errors.CannotOverwriteExistingCassetteException: Can't
overwrite existing cassette
('/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/tests/recordings/test_map_with_data.yaml')
in your current record mode ('none').
E No match for the request (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>)
was found.
E Found 6 similar requests with 0 different matcher(s) :
E
E 1 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 2 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 3 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 4 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 5 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 6 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
/usr/lib/python3.9/site-packages/vcr/stubs/__init__.py:231:
CannotOverwriteExistingCassetteException
------------------------------ Captured log call
-------------------------------
ERROR gcsfs.core:core.py:503 _call non-retriable exception: You already own
this bucket. Please select another name.
Traceback (most recent call last):
File "/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/core.py", line 487, in _call
validate_response(r, path)
File "/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/core.py", line 130, in
validate_response
raise HttpError(error)
gcsfs.utils.HttpError: You already own this bucket. Please select another name.
WARNING urllib3.connectionpool:connectionpool.py:443 Failed to parse headers
(url=https://www.googleapis.com:443/batch/storage/v1):
[StartBoundaryNotFoundDefect(), MultipartInvariantViolationDefect()], unparsed
data: ''
Traceback (most recent call last):
File "/usr/lib/python3.9/site-packages/urllib3/connectionpool.py", line 441,
in _make_request
assert_header_parsing(httplib_response.msg)
File "/usr/lib/python3.9/site-packages/urllib3/util/response.py", line 71, in
assert_header_parsing
raise HeaderParsingError(defects=defects, unparsed_data=unparsed_data)
urllib3.exceptions.HeaderParsingError: [StartBoundaryNotFoundDefect(),
MultipartInvariantViolationDefect()], unparsed data: ''
WARNING urllib3.connectionpool:connectionpool.py:443 Failed to parse headers
(url=https://www.googleapis.com:443/batch/storage/v1):
[StartBoundaryNotFoundDefect(), MultipartInvariantViolationDefect()], unparsed
data: ''
Traceback (most recent call last):
File "/usr/lib/python3.9/site-packages/urllib3/connectionpool.py", line 441,
in _make_request
assert_header_parsing(httplib_response.msg)
File "/usr/lib/python3.9/site-packages/urllib3/util/response.py", line 71, in
assert_header_parsing
raise HeaderParsingError(defects=defects, unparsed_data=unparsed_data)
urllib3.exceptions.HeaderParsingError: [StartBoundaryNotFoundDefect(),
MultipartInvariantViolationDefect()], unparsed data: ''
_____________________________ test_map_clear_empty
_____________________________
@my_vcr.use_cassette(match=["all"])
def test_map_clear_empty():
with gcs_maker() as gcs:
d = gcs.get_mapper(root)
d.clear()
assert list(d) == []
d[1] = b"1"
assert list(d) == ["1"]
gcsfs/tests/test_mapping.py:96:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
/usr/lib/python3.9/site-packages/fsspec/mapping.py:101: in __len__
return len(self.fs.find(self.root))
/usr/lib/python3.9/site-packages/fsspec/spec.py:394: in find
for path, dirs, files in self.walk(path, maxdepth, detail=True, **kwargs):
/usr/lib/python3.9/site-packages/fsspec/spec.py:343: in walk
listing = self.ls(path, detail=True, **kwargs)
gcsfs/core.py:767: in ls
out = self._list_objects(path)
gcsfs/core.py:571: in _list_objects
items, prefixes = self._do_list_objects(path)
gcsfs/core.py:598: in _do_list_objects
page = self._call(
gcsfs/core.py:478: in _call
r = self.session.request(
/usr/lib/python3.9/site-packages/google/auth/transport/requests.py:444: in
request
response = super(AuthorizedSession, self).request(
/usr/lib/python3.9/site-packages/requests/sessions.py:530: in request
resp = self.send(prep, **send_kwargs)
/usr/lib/python3.9/site-packages/requests/sessions.py:643: in send
r = adapter.send(request, **kwargs)
/usr/lib/python3.9/site-packages/requests/adapters.py:439: in send
resp = conn.urlopen(
/usr/lib/python3.9/site-packages/urllib3/connectionpool.py:665: in urlopen
httplib_response = self._make_request(
/usr/lib/python3.9/site-packages/urllib3/connectionpool.py:412: in
_make_request
httplib_response = conn.getresponse(buffering=True)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
self =
<vcr.patch.VCRRequestsHTTPSConnection/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/tests/recordings/test_map_clear_empty.yaml
object at 0x7f2700364f10>
_ = False, kwargs = {'buffering': True}
def getresponse(self, _=False, **kwargs):
"""Retrieve the response"""
# Check to see if the cassette has a response for this request. If so,
# then return it
if self.cassette.can_play_response_for(self._vcr_request):
log.info("Playing response for {} from
cassette".format(self._vcr_request))
response = self.cassette.play_response(self._vcr_request)
return VCRHTTPResponse(response)
else:
if self.cassette.write_protected and
self.cassette.filter_request(self._vcr_request):
raise CannotOverwriteExistingCassetteException(
cassette=self.cassette, failed_request=self._vcr_request
)
E vcr.errors.CannotOverwriteExistingCassetteException: Can't
overwrite existing cassette
('/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/tests/recordings/test_map_clear_empty.yaml')
in your current record mode ('none').
E No match for the request (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>)
was found.
E Found 11 similar requests with 0 different matcher(s) :
E
E 1 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 2 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 3 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 4 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 5 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 6 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 7 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 8 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 9 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 10 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
E
E 11 - (<Request (GET)
https://www.googleapis.com/storage/v1/b/gcsfs-testing/o/?delimiter=%2F&am...>).
E Matchers succeeded : ['matcher']
E Matchers failed :
/usr/lib/python3.9/site-packages/vcr/stubs/__init__.py:231:
CannotOverwriteExistingCassetteException
------------------------------ Captured log call
-------------------------------
ERROR gcsfs.core:core.py:503 _call non-retriable exception: You already own
this bucket. Please select another name.
Traceback (most recent call last):
File "/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/core.py", line 487, in _call
validate_response(r, path)
File "/builddir/build/BUILD/gcsfs-0.6.2/gcsfs/core.py", line 130, in
validate_response
raise HttpError(error)
gcsfs.utils.HttpError: You already own this bucket. Please select another name.
WARNING urllib3.connectionpool:connectionpool.py:443 Failed to parse headers
(url=https://www.googleapis.com:443/batch/storage/v1):
[StartBoundaryNotFoundDefect(), MultipartInvariantViolationDefect()], unparsed
data: ''
Traceback (most recent call last):
File "/usr/lib/python3.9/site-packages/urllib3/connectionpool.py", line 441,
in _make_request
assert_header_parsing(httplib_response.msg)
File "/usr/lib/python3.9/site-packages/urllib3/util/response.py", line 71, in
assert_header_parsing
raise HeaderParsingError(defects=defects, unparsed_data=unparsed_data)
urllib3.exceptions.HeaderParsingError: [StartBoundaryNotFoundDefect(),
MultipartInvariantViolationDefect()], unparsed data: ''
WARNING urllib3.connectionpool:connectionpool.py:443 Failed to parse headers
(url=https://www.googleapis.com:443/batch/storage/v1):
[StartBoundaryNotFoundDefect(), MultipartInvariantViolationDefect()], unparsed
data: ''
Traceback (most recent call last):
File "/usr/lib/python3.9/site-packages/urllib3/connectionpool.py", line 441,
in _make_request
assert_header_parsing(httplib_response.msg)
File "/usr/lib/python3.9/site-packages/urllib3/util/response.py", line 71, in
assert_header_parsing
raise HeaderParsingError(defects=defects, unparsed_data=unparsed_data)
urllib3.exceptions.HeaderParsingError: [StartBoundaryNotFoundDefect(),
MultipartInvariantViolationDefect()], unparsed data: ''
=========================== short test summary info
============================
FAILED gcsfs/tests/test_mapping.py::test_map_simple -
vcr.errors.CannotOverwr...
FAILED gcsfs/tests/test_mapping.py::test_map_with_data -
vcr.errors.CannotOve...
FAILED gcsfs/tests/test_mapping.py::test_map_clear_empty -
vcr.errors.CannotO...
============ 3 failed, 64 passed, 1 deselected, 2 xfailed in 22.83s
============
Seems these tests need network access.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:12 a.m.
New subject: [Bug 1836686] Review Request: python-gcsfs - Convenient Filesystem
interface over GCS
https://bugzilla.redhat.com/show_bug.cgi?id=1836686
--- Comment #2 from Fabian Affolter <mail(a)fabian-affolter.ch> ---
(In reply to Robert-André Mauchin 🐧 from comment #1)
- You need to add Sphinx-rtd-theme:
+ sphinx-build-3 docs/source html
Running Sphinx v2.2.2
Configuration error:
There is a programmable error in your configuration file:
Traceback (most recent call last):
File "/usr/lib/python3.9/site-packages/sphinx/config.py", line 361, in
eval_config_file
execfile_(filename, namespace)
File "/usr/lib/python3.9/site-packages/sphinx/util/pycompat.py", line 81,
in execfile_
exec(code, _globals)
File "/builddir/build/BUILD/gcsfs-0.6.2/docs/source/conf.py", line 124, in
<module>
import sphinx_rtd_theme
ModuleNotFoundError: No module named 'sphinx_rtd_theme'
BuildRequires: python3-sphinx
BuildRequires: python3-sphinx_rtd_theme
BuildRequires: python3-numpydoc
Added.
- Tests fail due to missing a dep:
pytest-3.9 -v gcsfs/tests -k 'not test_request_header'
============================= test session starts
[...]
============
Seems these tests need network access.
BR added and condition for tests added.
%changelog
* Wed Jun 24 2020 Fabian Affolter <mail(a)fabian-affolter.ch> - 0.6.2-2
- Condition for tests
- Update BR (rhbz#1836686)
Updated files:
Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-gcsfs.spec
SRPM URL:
https://fab.fedorapeople.org/packages/SRPMS/python-gcsfs-0.6.2-2.fc31.src...
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
9:28 a.m.
New subject: [Bug 1836686] Review Request: python-gcsfs - Convenient Filesystem
interface over GCS
https://bugzilla.redhat.com/show_bug.cgi?id=1836686
Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |POST
Assignee|nobody(a)fedoraproject.org |zebob.m(a)gmail.com
Flags| |fedora-review+
--- Comment #3 from Robert-André Mauchin 🐧 <zebob.m(a)gmail.com> ---
Package approved.
Package Review
==============
Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed
===== MUST items =====
Generic:
[x]: Package is licensed with an open-source compatible license and meets
other legal requirements as defined in the legal section of Packaging
Guidelines.
[x]: License field in the package spec file matches the actual license.
Note: Checking patched sources after %prep for licenses. Licenses
found: "Unknown or generated", "BSD 3-clause "New" or
"Revised"
License". 96 files have unknown license. Detailed output of
licensecheck in /home/bob/packaging/review/python-gcsfs/review-python-
gcsfs/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[x]: Large documentation must go in a -doc subpackage. Large could be size
(~1MB) or number of files.
Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
license(s) in its own file, then that file, containing the text of the
license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
%{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local
Python:
[x]: Python eggs must not download any dependencies during the build
process.
[x]: A package which is used by another package via an egg interface should
provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
packages named with the unversioned python- prefix unless no properly
versioned package exists. Dependencies on Python packages instead MUST
use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep
===== SHOULD items =====
Generic:
[-]: Avoid bundling fonts in non-fonts packages.
Note: Package contains font files
[-]: If the source package does not include license text(s) as a separate
file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[-]: Fully versioned dependency in subpackages if applicable.
Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in
python3-gcsfs
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
publishes signatures.
Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
$RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic:
[x]: Rpmlint is run on all installed packages.
Note: No rpmlint messages.
[x]: Spec file according to URL is the same as in SRPM.
Rpmlint
-------
Checking: python3-gcsfs-0.6.2-2.fc33.noarch.rpm
python-gcsfs-doc-0.6.2-2.fc33.noarch.rpm
python-gcsfs-0.6.2-2.fc33.src.rpm
python3-gcsfs.noarch: W: spelling-error %description -l en_US Pythonic ->
Python
python-gcsfs-doc.noarch: W: file-not-utf8
/usr/share/doc/python-gcsfs-doc/html/objects.inv
python-gcsfs.src: W: spelling-error %description -l en_US Pythonic -> Python
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
8:01 p.m.
New subject: [Bug 1836686] Review Request: python-gcsfs - Convenient Filesystem
interface over GCS
https://bugzilla.redhat.com/show_bug.cgi?id=1836686
Bug 1836686 depends on bug 1836663, which changed state.
Bug 1836663 Summary: Review Request: python-google-auth-oauthlib - Google oAuth
Authentication Library
https://bugzilla.redhat.com/show_bug.cgi?id=1836663
What |Removed |Added
----------------------------------------------------------------------------
Status|ON_QA |CLOSED
Resolution|--- |ERRATA
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:45 p.m.
New subject: [Bug 1836686] Review Request: python-gcsfs - Convenient Filesystem
interface over GCS
https://bugzilla.redhat.com/show_bug.cgi?id=1836686
--- Comment #4 from Gwyn Ciesla <gwync(a)protonmail.com> ---
(fedscm-admin): The Pagure repository was created at
https://src.fedoraproject.org/rpms/python-gcsfs
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:14 p.m.
New subject: [Bug 1836686] Review Request: python-gcsfs - Convenient Filesystem
interface over GCS
https://bugzilla.redhat.com/show_bug.cgi?id=1836686
Fabian Affolter <mail(a)fabian-affolter.ch> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|POST |CLOSED
Resolution|--- |RAWHIDE
Last Closed| |2020-08-09 20:14:51
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
1349
days inactive
1433
days old
package-review@lists.fedoraproject.org
7 comments
1 participants
participants (1)
-
bugzilla＠redhat.com