Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485159 Christian Krause <chkr(a)plauener.de&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |177841 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485159 --- Comment #2 from Christian Krause <chkr(a)plauener.de&gt; 2009-02-18 14:19:08 EDT --- Anyone wants to pick up this review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485159 --- Comment #3 from Tom "spot" Callaway <tcallawa(a)redhat.com&gt; 2009-02-27 10:13:48 EDT --- Christian, at first glance, this package looks great. I only noticed one thing when I did the review: The package is internationalized, with .mo files for libanki and libankiqt. Unfortunately, they're in a location that %find_lang (https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files) doesn't know how to find them in (%{python_sitelib}/ankiqt/locale/*/LC_MESSAGES). Since you can't use %find_lang, you're going to have to tag those files manually, like this: %lang(cs) %{python_sitelib}/ankiqt/locale/cs_*/ (rpm tags on the first half of the locale country code only) Unfortunately, this will make your %files more complicated, as you cannot simply claim the toplevel directory or these files will be listed twice. Start with something like this: %files %defattr(-,root,root,-) %doc COPYING ChangeLog CREDITS README* %dir %{python_sitelib}/ankiqt/ %{python_sitelib}/ankiqt/*.py* %{python_sitelib}/ankiqt/forms/ %{python_sitelib}/ankiqt/ui/ %dir %{python_sitelib}/ankiqt/locale/ %lang(cs) %{python_sitelib}/ankiqt/locale/cs_*/ %lang(de) %{python_sitelib}/ankiqt/locale/de_*/ ... It is also possible to script a version of find_lang that can find these files and tag them properly in a file list to use in %files, but that might be more complicated than doing what I've proposed. rpmlint caught this problem, you should run rpmlint on your packages to look for issues like this. :) Show me a new package that has this issue fixed and I'll finish out this review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485159 Tom "spot" Callaway <tcallawa(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #5 from Tom "spot" Callaway <tcallawa(a)redhat.com&gt; 2009-02-27 15:46:58 EDT --- == Review == Good: - rpmlint checks return: anki.src: W: strange-permission generate-anki-tarball.sh 0755 Safe to ignore. - package meets naming guidelines - package meets packaging guidelines - license (GPLv3+ and MIT) OK, text in %doc, matches source - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR - locales okay - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - desktop file okay APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485159 Kevin Fenzi <kevin(a)tummy.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+ --- Comment #7 from Kevin Fenzi <kevin(a)tummy.com&gt; 2009-02-28 19:28:16 EDT --- cvs done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485159 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |ON_QA --- Comment #9 from Fedora Update System <updates(a)fedoraproject.org&gt; 2009-03-04 11:26:20 EDT --- anki-0.9.9.6-4.fc10 has been pushed to the Fedora 10 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update anki'. You can provide feedback for this update here: http://admin.fedoraproject.org/updates/F10/FEDORA-2009-2322 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485159 --- Comment #11 from Christian Krause <chkr(a)plauener.de&gt; 2009-03-04 17:36:30 EDT --- (In reply to comment #10) Sure - I've just pushed it to stable 5 minutes ago. ;-) Thank you again for all the support and help! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485159 Fedora Update System <updates(a)fedoraproject.org&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |0.9.9.6-4.fc10 Resolution| |NEXTRELEASE -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485159 --- Comment #14 from Fedora Update System <updates(a)fedoraproject.org&gt; 2009-03-09 18:45:01 EDT --- anki-0.9.9.6-4.fc9 has been pushed to the Fedora 9 stable repository. If problems still persist, please make note of it in this bug report. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=485159 Jason Tibbitts <tibbs(a)math.uh.edu&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|177841(FE-NEEDSPONSOR) | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.