https://bugzilla.redhat.com/show_bug.cgi?id=846662
Bug ID: 846662 QA Contact: extras-qa@fedoraproject.org Severity: medium Version: rawhide Priority: medium CC: notting@redhat.com, package-review@lists.fedoraproject.org Assignee: nobody@fedoraproject.org Summary: Review Request: eclipse-ecf - Eclipse Communication Framework Regression: --- Story Points: --- Classification: Fedora OS: Linux Reporter: kdaniel@redhat.com Type: --- Documentation: --- Hardware: All Mount Type: --- Status: NEW Component: Package Review Product: Fedora
Spec URL: http://kdaniel.fedorapeople.org/ecj/eclipse-ecf.spec SRPM URL: http://kdaniel.fedorapeople.org/ecj/eclipse-ecf-3.5.6-1.fc17.src.rpm Description: ECF bundles required by eclipse-platform. Fedora Account System Username: kdaniel, akurtako
https://bugzilla.redhat.com/show_bug.cgi?id=846662
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |akurtako@redhat.com Flags| |fedora-review?
--- Comment #1 from Alexander Kurtakov akurtako@redhat.com --- I'll do it.
https://bugzilla.redhat.com/show_bug.cgi?id=846662
--- Comment #2 from Alexander Kurtakov akurtako@redhat.com ---
Package Review ==============
Key: - = N/A x = Pass ! = Fail ? = Not evaluated
==== C/C++ ==== [x]: MUST Package does not contain any libtool archives (.la) [x]: MUST Package does not contain kernel modules. [x]: MUST Package contains no static executables. [x]: MUST Rpath absent or only used for internal libs.
==== Generic ==== [x]: EXTRA Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: EXTRA Spec file according to URL is the same as in SRPM. [x]: MUST Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: MUST Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: MUST %build honors applicable compiler flags or justifies otherwise. [x]: MUST All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: MUST Buildroot is not present Note: Unless packager wants to package for EPEL5 this is fine [!]: MUST Package contains no bundled libraries. [x]: MUST Changelog in prescribed format. [x]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean would be needed if support for EPEL is required [x]: MUST Sources contain only permissible code or content. [x]: MUST Each %files section contains %defattr if rpm < 4.4 Note: Note: defattr macros not found. They would be needed for EPEL5 [x]: MUST Macros in Summary, %description expandable at SRPM build time. [x]: MUST Package contains desktop file if it is a GUI application. [-]: MUST Development files must be in a -devel package [x]: MUST Package requires other packages for directories it uses. [x]: MUST Package uses nothing in %doc for runtime. [x]: MUST Package is not known to require ExcludeArch. [x]: MUST Permissions on files are set properly. [x]: MUST Package does not contain duplicates in %files. [x]: MUST Package complies to the Packaging Guidelines [x]: MUST Spec file lacks Packager, Vendor, PreReq tags. [x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf would be needed if support for EPEL5 is required [-]: MUST Large documentation files are in a -doc subpackage, if required. [x]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [!]: MUST License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "UNKNOWN", "*No copyright* UNKNOWN", "Apache (v2.0) GENERATED FILE", "Apache (v2.0)" [x]: MUST License file installed when any subpackage combination is installed. [x]: MUST Package consistently uses macro is (instead of hard-coded directory names). [x]: MUST Package is named using only allowed ascii characters. [x]: MUST Package is named according to the Package Naming Guidelines. [x]: MUST Package does not generate any conflict. Note: Package contains no Conflicts: tag(s) [x]: MUST Package obeys FHS, except libexecdir and /usr/target. [x]: MUST Package must own all directories that it creates. [x]: MUST Package does not own files or directories owned by other packages. [x]: MUST Package installs properly. [x]: MUST Package is not relocatable. [x]: MUST Requires correct, justified where necessary. [x]: MUST Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. [x]: MUST Spec file is legible and written in American English. [x]: MUST Spec file name must match the spec package %{name}, in the format %{name}.spec. [-]: MUST Package contains systemd file(s) if in need. [x]: MUST File names are valid UTF-8. [x]: SHOULD Reviewer should test that the package builds in mock. [x]: SHOULD If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: SHOULD Dist tag is present. [x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q --requires). [x]: SHOULD Package functions as described. [x]: SHOULD Latest version is packaged. [x]: SHOULD Package does not include license text files separate from upstream. [x]: SHOULD SourceX / PatchY prefixed with %{name}. Note: Source0 (R-Release_HEAD-sdk_feature-77_2012-06-10_19-42-02.tar.bz2) [x]: SHOULD SourceX is a working URL. [-]: SHOULD Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: SHOULD Package should compile and build into binary rpms on all supported architectures. [-]: SHOULD %check is present and all tests pass. [-]: SHOULD Packages should try to preserve timestamps of original installed files. [x]: SHOULD Spec use %global instead of %define.
==== Java ==== [!]: MUST If source tarball includes bundled jar/class files these need to be removed prior to building [x]: MUST Packages have proper BuildRequires/Requires on jpackage-utils [x]: MUST Fully versioned dependency in subpackages, if present. [-]: MUST Javadoc documentation files are generated and included in -javadoc subpackage Note: No javadoc subpackage present [-]: MUST Javadoc subpackages have Requires: jpackage-utils [-]: MUST Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Note: No javadoc subpackage present [x]: SHOULD Package has BuildArch: noarch (if possible) [x]: SHOULD Package uses upstream build method (ant/maven/etc.)
==== Maven ==== [x]: MUST Old add_to_maven_depmap macro is not being used [-]: MUST If package contains pom.xml files install it (including depmaps) even when building with ant
Issues: [*] Rpmlint ------- Checking: eclipse-ecf-core-3.5.6-1.fc18.noarch.rpm eclipse-ecf-3.5.6-1.fc18.src.rpm eclipse-ecf-core.noarch: W: summary-ended-with-dot C ECF core bundles. 2 packages and 0 specfiles checked; 0 errors, 1 warnings.
[*] Please remove jars in prep. There are: providers/bundles/org.eclipse.ecf.provider.irc/lib/irclib.jar providers/bundles/org.eclipse.ecf.provider.rss/lib/rss-sse.jar protocols/bundles/org.jivesoftware.smack/jars/xpp.jar server-side/features/org.eclipse.ecf.server.feature/lib/org.eclipse.equinox.registry_3.2.100.v20061023.jar server-side/features/org.eclipse.ecf.server.feature/lib/org.eclipse.core.runtime_3.2.100.v20061030.jar server-side/features/org.eclipse.ecf.server.feature/lib/org.eclipse.equinox.common_3.3.0.v20061023.jar server-side/features/org.eclipse.ecf.server.feature/lib/org.eclipse.osgi_3.3.0.v20061101.jar
[*] Please move core subpackage to the top (prior to prep) it's common standard to have all package definitions first.
[*] use %{_javadir}/ecf instead of /usr/share/java/ecf files section
https://bugzilla.redhat.com/show_bug.cgi?id=846662
--- Comment #3 from Krzysztof Daniel kdaniel@redhat.com --- Spec URL: http://kdaniel.fedorapeople.org/ecj/v2/eclipse-ecf.spec SRPM URL: http://kdaniel.fedorapeople.org/ecj/v2/eclipse-ecf-3.5.6-2.fc17.src.rpm
https://bugzilla.redhat.com/show_bug.cgi?id=846662
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+
--- Comment #4 from Alexander Kurtakov akurtako@redhat.com --- Looks good.
APPROVED.
https://bugzilla.redhat.com/show_bug.cgi?id=846662
Alexander Kurtakov akurtako@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@fedoraproject.org |akurtako@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=846662
Krzysztof Daniel kdaniel@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
--- Comment #5 from Krzysztof Daniel kdaniel@redhat.com --- New Package SCM Request ======================= Package Name: eclipse-ecf Short Description: Eclipse Communication Framework Owners: kdaniel akurtako Branches: f19 InitialCC: kdaniel
https://bugzilla.redhat.com/show_bug.cgi?id=846662
--- Comment #6 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Fixed branches, FAS name.
https://bugzilla.redhat.com/show_bug.cgi?id=846662
Krzysztof Daniel kdaniel@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |RAWHIDE Flags|fedora-cvs+ |fedora-cvs? Last Closed| |2012-08-09 03:47:09
https://bugzilla.redhat.com/show_bug.cgi?id=846662
Krzysztof Daniel kdaniel@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Resolution|RAWHIDE |NEXTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=846662
--- Comment #7 from Jon Ciesla limburgher@gmail.com --- Already done.
https://bugzilla.redhat.com/show_bug.cgi?id=846662
Krzysztof Daniel kdaniel@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |ASSIGNED Resolution|NEXTRELEASE |--- Flags| |fedora-cvs? Keywords| |Reopened
--- Comment #8 from Krzysztof Daniel kdaniel@redhat.com --- This package is also needed in f18.
New Package SCM Request ======================= Package Name: eclipse-ecf Short Description: Eclipse Communication Framework Owners: kdaniel akurtako Branches: f18 f19 InitialCC: kdaniel
https://bugzilla.redhat.com/show_bug.cgi?id=846662
--- Comment #9 from Jon Ciesla limburgher@gmail.com --- Use a Package Change Request, not a New Package Request.
https://bugzilla.redhat.com/show_bug.cgi?id=846662
--- Comment #10 from Krzysztof Daniel kdaniel@redhat.com --- Package Change Request ====================== Package Name: eclipse-ecf New Branches: f18 f19 Owners: kdaniel akurtako InitialCC: kdaniel
(This package is also needed in f18 because new eclispe packaging in rawhide is successful)
https://bugzilla.redhat.com/show_bug.cgi?id=846662
Krzysztof Daniel kdaniel@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-cvs?
https://bugzilla.redhat.com/show_bug.cgi?id=846662
--- Comment #11 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
Product: Fedora https://bugzilla.redhat.com/show_bug.cgi?id=846662
Krzysztof Daniel kdaniel@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed|2012-08-09 03:47:09 |2012-12-11 05:53:29
package-review@lists.fedoraproject.org