Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pdns-recursor - Modern, advanced and high performance recursing/non authoritative nameserver

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221188

josef@toxicpanda.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: pdns- |Review Request: pdns- |recursor - Modern, advanced |recursor - Modern, advanced |and high performance |and high performance |recursing/non authoritative |recursing/non authoritative |nameserver |nameserver

------- Additional Comments From josef@toxicpanda.com 2007-01-02 16:56 EST ------- Here is my review, everything looks good, it built and such. I haven't yet been sponsored and stuff, I'm doing reviews in order to get sponsored.

Must:

-rpmlint ran without errors [josef@dhcp59-136 ~]$ rpmlint pdns-recursor-3.1.4-1.src.rpm [josef@dhcp59-136 ~]$ -package conforms to package naming guidlines -spec file name matches basename -the package is licensed with an open source compatible license -package includes license in %doc -spec file is written in american english -spec file is legible -sources match upstream (sha1sum) d1fa344ec5f2feb12397361f92b011a0cb726d48 pdns-recursor-3.1.4.tar.bz2 -package successfully built on my test box (x86_64) -no need for exclude arch -BR are present and make sense -no libraries, no need to run ldconfig -not relocatable -package owns everything it creates -package does not duplicate files it owns -file attributes are set appropriatly -%clean section present and removes buildroot -consistently uses macros -contains code -no large documentation -files in %doc does not affect runtime of application -does not contain a pkgconfig file -does not contain any libraries -does not have a devel package -does not contain any .la files -package does not have a gui -package does not own files/directories owned by other packages.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pdns-recursor - Modern, advanced and high performance recursing/non authoritative nameserver

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221188

------- Additional Comments From kevin@tummy.com 2007-01-23 22:54 EST -------

OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: 439a10639f53def0ba47c0851e4a2671 pdns-recursor-3.1.4.tar.bz2 439a10639f53def0ba47c0851e4a2671 pdns-recursor-3.1.4.tar.bz2.1 d1fa344ec5f2feb12397361f92b011a0cb726d48 pdns-recursor-3.1.4.tar.bz2 d1fa344ec5f2feb12397361f92b011a0cb726d48 pdns-recursor-3.1.4.tar.bz2.1 OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime.

OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. See below - final provides and requires are sane:

SHOULD Items:

OK - Should build in mock. OK - Should build on all supported archs OK - Should have dist tag OK - Should package latest version

Issues:

1. The Source URL doesn't seem to work for me.

Should be: http://downloads.powerdns.com/releases/pdns-recursor-3.1.4.tar.bz2

(note: releases, not release)

2. Your debuginfo files are all empty. Not sure why that is, but I think it deserves some investigation.

3. I assume the Provides: powerdns-recursor = %{version}-%{release} is for upstream or other project released rpms?

4. Is it ok for this package to run as user 'pdns', which is the same as the 'pdns' package. If they are both on the same machine could there be security implications? Perhaps this package should use a 'pdns-recursor' user instead?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pdns-recursor - Modern, advanced and high performance recursing/non authoritative nameserver

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221188

------- Additional Comments From ruben@rubenkerkhof.com 2007-01-24 15:14 EST ------- Ok, fixed all the things above, and more. I added a nicer initscript as well.

New files: http://rubenkerkhof.com/packages/pdns-recursor.spec http://rubenkerkhof.com/packages/pdns-recursor-3.1.4-2.src.rpm

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pdns-recursor - Modern, advanced and high performance recursing/non authoritative nameserver

https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=221188

ruben@rubenkerkhof.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE

------- Additional Comments From ruben@rubenkerkhof.com 2007-01-27 18:03 EST ------- Hi Kevin,

Fixed, and build successfully on -devel.

...

Also, consider reviewing some other waiting packages to help spread out the reviewing load. :)

Working on that :-)

Thanks for your review.