https://bugzilla.redhat.com/show_bug.cgi?id=1528008

Randy Barlow randy@electronsweatshop.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |python-cornice_sphinx - |python-cornice-sphinx - |Cornice extension to |Cornice extension to |generate Sphinx docs |generate Sphinx docs

https://bugzilla.redhat.com/show_bug.cgi?id=1528008

--- Comment #1 from Randy Barlow randy@electronsweatshop.com --- After reading the naming guidelines[0] closer, I'm renaming it to use only dashes:

Spec URL: https://bowlofeggs.fedorapeople.org/python-cornice-sphinx.spec SRPM URL: https://bowlofeggs.fedorapeople.org/python-cornice-sphinx-0.3-1.fc27.src.rpm

[0]https://fedoraproject.org/wiki/Packaging:Naming?rd=Packaging:NamingGuideline...

https://bugzilla.redhat.com/show_bug.cgi?id=1528008

--- Comment #3 from Jeremy Cline jeremy@jcline.org --- Several files have the Mozilla Public License header, so I think you need to use "ASL 2.0 and MPLv2.0" for the license.

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "*No copyright* Apache", "*No copyright* MPL (v2.0)", "Unknown or generated", "*No copyright* Apache (v2.0)". 7 files have unknown license. Detailed output of licensecheck in /home/vagrant/1528008 -python-cornice-sphinx/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python2 -cornice-sphinx , python3-cornice-sphinx [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: python2-cornice-sphinx-0.3-1.fc28.noarch.rpm python3-cornice-sphinx-0.3-1.fc28.noarch.rpm python-cornice-sphinx-0.3-1.fc28.src.rpm 3 packages and 0 specfiles checked; 0 errors, 0 warnings.

Rpmlint (installed packages) ---------------------------- python2-cornice-sphinx.noarch: W: invalid-url URL: https://github.com/Cornices/cornice.ext.sphinx <urlopen error [Errno -2] Name or service not known> python3-cornice-sphinx.noarch: W: invalid-url URL: https://github.com/Cornices/cornice.ext.sphinx <urlopen error [Errno -2] Name or service not known> 2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Requires -------- python2-cornice-sphinx (rpmlib, GLIBC filtered): python(abi) python2-cornice python2-docutils python2-sphinx

python3-cornice-sphinx (rpmlib, GLIBC filtered): python(abi) python3-cornice python3-docutils python3-sphinx

Provides -------- python2-cornice-sphinx: python-cornice-sphinx python2-cornice-sphinx python2.7dist(cornice-sphinx) python2dist(cornice-sphinx)

python3-cornice-sphinx: python3-cornice-sphinx python3.6dist(cornice-sphinx) python3dist(cornice-sphinx)

Source checksums ---------------- https://github.com/Cornices/cornice.ext.sphinx/archive/0.3/cornice_sphinx-0.... : CHECKSUM(SHA256) this package : 82756eef2431190b88e4f2070acf5f9e7ddf3a4ae13b8d83a053582be77d1083 CHECKSUM(SHA256) upstream package : 82756eef2431190b88e4f2070acf5f9e7ddf3a4ae13b8d83a053582be77d1083

Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1528008 -L cornice/ Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6

Built with local dependencies: /home/vagrant/cornice/python3-cornice-3.0.0-1.fc28.noarch.rpm /home/vagrant/cornice/python2-cornice-3.0.0-1.fc28.noarch.rpm

https://bugzilla.redhat.com/show_bug.cgi?id=1528008

Jeremy Cline jeremy@jcline.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review+

--- Comment #5 from Jeremy Cline jeremy@jcline.org --- Approved.

One thing you might want to do is use the nifty new Python requirement macros to require the upstream package name rather than the RPM name. For example:

Requires: %{py3_dist cornice docutils sphinx}

Just a neat little thing to make your specfile a little shorter.

https://bugzilla.redhat.com/show_bug.cgi?id=1528008

--- Comment #6 from Gwyn Ciesla limburgher@gmail.com --- (fedrepo-req-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cornice-sphinx