Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 alexl(a)users.sourceforge.net changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody(a)fedoraproject.org |alexl(a)users.sourceforge.net Flag| |fedora-review? ------- Additional Comments From alexl(a)users.sourceforge.net 2007-11-12 04:23 EST ------- Full review to come, but this is a blocker, according to configure.ac need at least 2.11.7 of gtk-engines-2 which means that BuildRequires needs to be upped to: gtk2-engines >= 2.11.7 This will also mean that it must be build on F-8 and above (F-7 only has gtk2-engines-2.10.2). -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 ------- Additional Comments From alexl(a)users.sourceforge.net 2007-11-12 05:02 EST ------- Full review follows: the first section are all MUST fix items: - MUST: rpmlint output: gnome-themes-extras.noarch: W: invalid-license LGPL gnome-themes-extras.noarch: W: obsolete-not-provided gnome-themes-extras-0.9.0 - MUST: remove Obsoletes: gnome-themes-themes, don't need to obsolete packages that have the same name, yum does that by default - MUST: don't use %makeinstall, see: http://fedoraproject.org/wiki/Packaging/Guidelines?highlight=%28%25makein... use make install DESTDIR=%{buildroot} instead - MUST: License information in the tarball is not clear because README, COPYING are empty and those that mention specific licenses, e.g Gion and Neu are GPL not LGPL, please clarify with upstream and read http://fedoraproject.org/wiki/Licensing if the package contains themes with different licenses they must each be listed in the license tag, e.g. "License: GPLv2+ and LGPLv2+" (see also http://fedoraproject.org/wiki/Packaging/LicensingGuidelines) - MUST: As above, License field is currently NOT valid, LGPL is not valid see: http://fedoraproject.org/wiki/Licensing - MUST: COPYING is empty: file bug with upstream asking to include it in package - MUST: BuildRequires: should increase gtk2-engines >= 2.11.7 The following is a checklist of all the OK items: - MUST: Meets Package Naming Guidelines.: OK - MUST: The spec file name: OK - MUST: Meets the Packaging Guidelines: OK - MUST: Spec file in American English: OK - MUST: The spec file legible: OK - MUST: MD5sum matches: 36698ee94c2281d5beab9b0a681f3350 gnome-themes-extras-2.20.tar.gz http://ftp.gnome.org/pub/GNOME/sources/gnome-themes-extras/2.20/gnome-the... 36698ee94c2281d5beab9b0a681f3350 gnome-themes-extras-2.20.tar.gz - MUST: Builds in binary RPM on F-8 i386: OK - MUST: uses %find_lang, although not yet needed: OK - MUST: ldconfig: not required (noarch): OK - MUST: not relocatable: OK - MUST: Own all directories that it creates: OK - MUST:No duplicate files: OK - MUST: %defattr(...): OK - MUST: Each package must have a %clean section: OK - MUST: Consistently use macros: OK - MUST: Contains mainly permissable content, themes: OK - MUST: No large doc: OK - MUST: %doc not critical for run-time: OK - MUST: no devel package: OK - MUST: no static libraries: OK - MUST: No pkgconfig(.pc) files: OK - MUST: no library files with suffix: OK - MUST: no .la libtool archives: OK - MUST: not a GUI app: OK - MUST: Does not own files or directories already owned by other packages: OK - MUST: Runs rm -rf %{buildroot}: OK - MUST: Filenames valid UTF-8: OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 ------- Additional Comments From alexl(a)users.sourceforge.net 2007-11-12 05:11 EST ------- The orphaning happened back at FC-6 by the looks of things. Also: do you have a sponsor? I cannot act as a sponsor, although I can act as a reviewer, I believe. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 ------- Additional Comments From marc(a)mwiriadi.id.au 2007-11-12 05:25 EST ------- No I do not have a sponsor as of yet. Another package I have submitted is getting review by Kevin Fenzi. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 ------- Additional Comments From alexl(a)users.sourceforge.net 2007-11-12 06:03 EST ------- (In reply to comment #7) Yes, perhaps they could be split out as subpackages with a separate License: tag for each one, that might work. We already have some theme packages like that, e.g. gnome-theme-clearlooks-bigpack-0.6-6.fc7 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 ------- Additional Comments From marc(a)mwiriadi.id.au 2007-11-12 07:32 EST ------- Updated the package less the license with the spec file and splitting the source into separate packages. I'm assuming the docs are going to be the same as what they are now but adjustments will be made if need to. http://www.mwiriadi.id.au/fedora-spec/gnome-themes-extras -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 ------- Additional Comments From marc(a)mwiriadi.id.au 2007-11-14 02:32 EST ------- I should have clarified I'm still waiting for feedback from gnome so I have left the files as is. I won't put the same docs in the same section when I have the different docs. While the license tag is incorrect I can't change it till gnome gets back to me. The package I have listed is just waiting for there alterations. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 ------- Additional Comments From alexl(a)users.sourceforge.net 2008-01-03 18:38 EST ------- (In reply to comment #12) Ping? Is it possible make updates to this package now? I'd like to finish up the review so you can get this into Fedora. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 ------- Additional Comments From alexl(a)users.sourceforge.net 2008-01-03 18:57 EST ------- (In reply to comment #15) Perhaps just package the theme(s) that do have licenses for the moment (and strip out the packages that don't from the tarball) and you can add them back as upstream confirms licenses. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 ------- Additional Comments From marc(a)mwiriadi.id.au 2008-01-04 20:01 EST ------- Major issues with this package. All the patches in http://mwiriadi.fedorapeople.org/packages/gnome-themes-extras/ This doesn't build. make[2]: Entering directory `/home/marc/rpmbuild/BUILD/gnome-themes-extras-2.20/icon-themes' make[2]: *** No rule to make target `all'. Stop. make[2]: Leaving directory `/home/marc/rpmbuild/BUILD/gnome-themes-extras-2.20/icon-themes' make[1]: *** [all-recursive] Error 1 make[1]: Leaving directory `/home/marc/rpmbuild/BUILD/gnome-themes-extras-2.20' make: *** [all] Error 2 error: Bad exit status from /var/tmp/rpm-tmp.18227 (%build) I didn't adjust any of the makefiles apart from the patches. I did a visual comparison of the two sections for make all and there is no difference apart from what is patched. Any suggestions? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 alexl(a)users.sourceforge.net changed: What |Removed |Added ---------------------------------------------------------------------------- External Bug| |http://bugzilla.gnome.org/sh Tracker URL| |ow_bug.cgi?id=496096 ------- Additional Comments From alexl(a)users.sourceforge.net 2008-01-07 22:28 EST ------- Here's the upstream license clarification request bug: http://bugzilla.gnome.org/show_bug.cgi?id=496096 It looks like we are go tentatively for GPLv2, but I'd like to like to check whether they mean GPLv2+ (i.e. or later version), which is the most likely. Judging from some of the comments it seems that upstream doesn't really understand the meaning of GPL versions very well. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 ------- Additional Comments From alexl(a)users.sourceforge.net 2008-01-09 07:16 EST ------- MUST FIX items: 1) OK, I think that we should go back to the monolithic package for the moment, to avoid duplication of docs and to make sure upgrades from the old gnome-themes-extras goes smoothly. The good news is that I did a koji build on rawhide that worked: http://koji.fedoraproject.org/koji/taskinfo?taskID=336678 Also there are some (mostly) small issues with running rpmlint on the packages $ rpmlint *.rpm gnome-themes-extras.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 20) gnome-themes-extras-darklooks.noarch: W: summary-not-capitalized darklooks theme gnome-themes-extras-darklooks.noarch: E: description-line-too-long Darklooks is a meta-theme that is part of the gnome-themes-extras package. This package gnome-themes-extras-foxtrot.noarch: E: description-line-too-long Foxtrot is a meta-theme that is part of the gnome-themes-extras package. This package gnome-themes-extras-gion.noarch: E: description-line-too-long Gion is a meta-theme that is part of the gnome-themes-extras package. This package gnome-themes-extras-neu.noarch: W: spelling-error-in-description pacakge package gnome-themes-extras-neu.noarch: E: description-line-too-long Neu is a meta-theme that is part of the gnome-themes-extras pacakge. This package 2) Remember, Description lines should be no longer than 80 chars, and that Summary should start with a capital letter. 3) You are also mixing tabs and spaces in the spec file which makes the spec file look odd in different editors, for example in Emacs it looks like this: %package foxtrot Requires: gnome-icon-theme, gnome-themes Group: User Interface/Desktops Summary: Foxtrot metatheme %description foxtrot Foxtrot is a meta-theme that is part of the gnome-themes-extras package. This package requires that you use a Gnome 2.2 release or newer. 4) * Mon Jan 7 2008 Marc Wiriadisastra <marc(a)mwiriadi.id.au&gt; - 2.20-3 - Added patches to remove non-licensed themes isn't true any more, so should be removed/updated. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 ------- Additional Comments From alexl(a)users.sourceforge.net 2008-01-09 07:23 EST ------- You watch to see they actually update SVN here: http://svn.gnome.org/viewvc/gnome-themes-extras/trunk/ -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 alexl(a)users.sourceforge.net changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From alexl(a)users.sourceforge.net 2008-01-10 09:51 EST ------- All looks good, so this package is: APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 marc(a)mwiriadi.id.au changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs? ------- Additional Comments From marc(a)mwiriadi.id.au 2008-01-10 15:53 EST ------- Package Change Request ====================== Package Name: gnome-themes-extras Updated Fedora Owners: mwiriadi New Branches: F-8 devel -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 ------- Additional Comments From alexl(a)users.sourceforge.net 2008-01-11 00:51 EST ------- (In reply to comment #29) But there isn't an F-8 branch there. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 alexl(a)users.sourceforge.net changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |412081 nThis| | -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 kevin(a)tummy.com changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+ ------- Additional Comments From kevin(a)tummy.com 2008-01-11 13:08 EST ------- F-8 branch added. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 ------- Additional Comments From alexl(a)users.sourceforge.net 2008-01-12 20:30 EST ------- Just sent Matthias a private e-mail (which I Cc'ed you on) to ask him to release the package. Hopefully he'll be more likely to read that than bugzilla/packagedb spam -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-themes-extras - extra themes for gnome https://bugzilla.redhat.com/show_bug.cgi?id=372161 ------- Additional Comments From marc(a)mwiriadi.id.au 2008-01-14 05:57 EST ------- It's ready now yes I can upload it now and release it for Fedora 8 and devel though it's up to you whether you want to do that. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is.