7:14 a.m.
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=956669
Bug ID: 956669
Summary: Review Request: erebus - 2D real-time Role-Playing
Game
Product: Fedora
Version: rawhide
Component: Package Review
Severity: medium
Priority: unspecified
Assignee: nobody(a)fedoraproject.org
Reporter: cickumqt(a)gmail.com
QA Contact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com,
package-review(a)lists.fedoraproject.org
Category: ---
Spec URL: http://cicku.me/erebus.spec
SRPM URL: http://cicku.me/erebus-0.7-1.fc20.src.rpm
Description: Erebus is an Open Source RPG (Role-Playing Game), for PCs,
smartphones, tablets and handhelds.
Fedora Account System Username: cicku
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=b5weJX0qvF&a=cc_unsubscribe
7:15 a.m.
New subject: [Bug 956669] Review Request: erebus - 2D real-time Role-Playing Game
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=956669
Christopher Meng <cickumqt(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |177841 (FE-NEEDSPONSOR)
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=saSnRiGFtR&a=cc_unsubscribe
1:13 a.m.
New subject: [Bug 956669] Review Request: erebus - 2D real-time Role-Playing Game
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=956669
--- Comment #1 from Christopher Meng <cickumqt(a)gmail.com> ---
Koji success:
http://koji.fedoraproject.org/koji/taskinfo?taskID=5316703
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=gjE0RwicCK&a=cc_unsubscribe
8:24 p.m.
New subject: [Bug 956669] Review Request: erebus - 2D real-time Role-Playing Game
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=956669
Christopher Meng <cickumqt(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|177841 (FE-NEEDSPONSOR) |
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=gLfh53GktP&a=cc_unsubscribe
5:06 p.m.
New subject: [Bug 956669] Review Request: erebus - 2D real-time Role-Playing Game
Product: Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=956669
Antonio Trande <anto.trande(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |anto.trande(a)gmail.com
Flags| |needinfo+
--- Comment #2 from Antonio Trande <anto.trande(a)gmail.com> ---
Hi Christopher.
Just some initial comments:
- I see some changes about FHS fixes. In my opinion, with a single modification
into 'deployment.pri' file, you can resolve all at one time ;)
- .desktop file is already in the source archive; why do you add another one as
Source1 ?
- %{_datadir}/%{name} directory must be owned by the package
- In erebus_source.txt file, the developer says:
The source code is released under the GPL v3 or later.
Please contact me if you have suggestions, bug fixes or whatever: mark dot harman >at
ntlworld dot com .
I don't see any license file included, apart from docs/gpl.txt file that is not
the GPLv3+ text file.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=eiKzw65q7Z&a=cc_unsubscribe
4:58 a.m.
New subject: [Bug 956669] Review Request: erebus - 2D real-time Role-Playing Game
https://bugzilla.redhat.com/show_bug.cgi?id=956669
--- Comment #3 from Christopher Meng <cickumqt(a)gmail.com> ---
(In reply to Antonio Trande from comment #2)
Hi Christopher.
Just some initial comments:
- I see some changes about FHS fixes. In my opinion, with a single
modification into 'deployment.pri' file, you can resolve all at one time ;)
Thanks! I'm not familiar with Qt, now I remember this~
- .desktop file is already in the source archive; why do you add
another one
as Source1 ?
Its bundled desktop file is invalid and doesn't match Fedora's standard, I
think rewriting one is better than patching.
- %{_datadir}/%{name} directory must be owned by the package
You mean I should remove the asterisk?
- In erebus_source.txt file, the developer says:
>The source code is released under the GPL v3 or later.
>Please contact me if you have suggestions, bug fixes or whatever: mark dot harman
>at ntlworld dot com .
I don't see any license file included, apart from docs/gpl.txt file that is
not the GPLv3+ text file.
Ok, I've mailed the author, hope he can fix that.
Thanks!
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=jQkpXGRuJd&a=cc_unsubscribe
11:07 a.m.
New subject: [Bug 956669] Review Request: erebus - 2D real-time Role-Playing Game
https://bugzilla.redhat.com/show_bug.cgi?id=956669
--- Comment #4 from Antonio Trande <anto.trande(a)gmail.com> ---
(In reply to Christopher Meng from comment #3)
> - .desktop file is already in the source archive; why do you add
another one
> as Source1 ?
Its bundled desktop file is invalid and doesn't match Fedora's standard, I
think rewriting one is better than patching.
See 'desktop-file-edit' manpage.
> - %{_datadir}/%{name} directory must be owned by the package
You mean I should remove the asterisk?
No.
http://fedoraproject.org/wiki/Packaging:UnownedDirectories#Forgetting_to_...
> - In erebus_source.txt file, the developer says:
>
> >The source code is released under the GPL v3 or later.
> >Please contact me if you have suggestions, bug fixes or whatever: mark dot
harman >at ntlworld dot com .
>
> I don't see any license file included, apart from docs/gpl.txt file that is
> not the GPLv3+ text file.
Ok, I've mailed the author, hope he can fix that.
Thanks!
This is very important.
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=eoezVDnDM7&a=cc_unsubscribe
9:42 a.m.
New subject: [Bug 956669] Review Request: erebus - 2D real-time Role-Playing Game
https://bugzilla.redhat.com/show_bug.cgi?id=956669
Antonio Trande <anto.trande(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Whiteboard| | NotReady
--
You are receiving this mail because:
You are on the CC list for the bug.
Unsubscribe from this bug
https://bugzilla.redhat.com/token.cgi?t=GV7Cq8usH3&a=cc_unsubscribe
7:50 a.m.
New subject: [Bug 956669] Review Request: erebus - 2D real-time Role-Playing Game
https://bugzilla.redhat.com/show_bug.cgi?id=956669
Pavel Alexeev (aka Pahan-Hubbitus) <pahan(a)hubbitus.info> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |pahan(a)hubbitus.info
--- Comment #5 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan(a)hubbitus.info> ---
$ LANG=C wget -c http://cicku.me/erebus.spec
--2014-04-25 16:50:09-- http://cicku.me/erebus.spec
Resolving cicku.me (cicku.me)... 37.59.54.136
Connecting to cicku.me (cicku.me)|37.59.54.136|:80... connected.
HTTP request sent, awaiting response... 404 Not Found
2014-04-25 16:50:09 ERROR 404: Not Found.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
6:11 p.m.
New subject: [Bug 956669] Review Request: erebus - 2D real-time Role-Playing Game
https://bugzilla.redhat.com/show_bug.cgi?id=956669
Ben Rosser <rosser.bjr(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |1364745
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1364745
[Bug 1364745] (FE-GAMESIG) Games SIG tracker bug
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:54 p.m.
New subject: [Bug 956669] Review Request: erebus - 2D real-time Role-Playing Game
https://bugzilla.redhat.com/show_bug.cgi?id=956669
Ben Rosser <rosser.bjr(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |rosser.bjr(a)gmail.com
--- Comment #6 from Ben Rosser <rosser.bjr(a)gmail.com> ---
Spec throws a 404 not found. Are you still interested in this review?
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
12:36 p.m.
New subject: [Bug 956669] Review Request: erebus - 2D real-time Role-Playing Game
https://bugzilla.redhat.com/show_bug.cgi?id=956669
Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |zbyszek(a)in.waw.pl
--- Comment #7 from Zbigniew Jędrzejewski-Szmek <zbyszek(a)in.waw.pl> ---
The answer is most likely no, cicku is MIA.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
3:45 p.m.
New subject: [Bug 956669] Review Request: erebus - 2D real-time Role-Playing Game
https://bugzilla.redhat.com/show_bug.cgi?id=956669
Ben Rosser <rosser.bjr(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |CLOSED
Blocks| |201449 (FE-DEADREVIEW)
Resolution|--- |NOTABUG
Last Closed| |2018-07-26 16:45:37
--- Comment #8 from Ben Rosser <rosser.bjr(a)gmail.com> ---
Well, there has been no response for a long time now so I think this can be
closed as FE-DEADREVIEW.
I left it open so long because I have toyed with the idea of packaging erebus
myself... however I'm not sure if/when I'll get around to it, so I may as well
just close the ticket now.
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=201449
[Bug 201449] FE-DEADREVIEW -- Reviews stalled due to lack of submitter
response should be blocking this bug.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
2094
days inactive
4012
days old
package-review@lists.fedoraproject.org
12 comments
2 participants
participants (2)
-
bugzilla＠redhat.com -
Red Hat Bugzilla