Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: librapi - Library to connect to Pocket PC devices https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=231670 bugzilla(a)redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |medium Priority|normal |medium andreas.bierfert(a)lowlatency.de changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From andreas.bierfert(a)lowlatency.de 2007-04-27 04:46 EST ------- -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 * OK: rpmlint output: W: librapi-devel no-documentation can be ignored * OK: package is named according to the guidelines * OK: spec file name matches base package name * OK: package meets packaging guidelines * OK: license * OK: license field matches actual license * OK: license is not included as own file and thus is not included in %doc * OK: Spec file seems to be in AE * OK: no obfuscated code spec * OK: sources match upstream: 1dcb43bbbb43688839c3b19de77b7b4e synce-librapi-0.9.3.tar.gz 1dcb43bbbb43688839c3b19de77b7b4e /homes/awjb/rpmbuild/SOURCES/synce-librapi-0.9.3.tar.gz * OK: Builds fine on x86_64/fc6 * OK: BR seem fine * OK: package has no locale support * OK: ldconfig is run on %post and $postun * OK: package is not explicitly designed to be relocatable * OK: package does not create any directories * OK: no duplicate files in file listing * OK: %defattr and permissions seem ok * OK: %clean section is present * OK: macros are used consistently * OK: content is ok * OK: no doc package needed * OK: %doc files do not affect runtime * OK: header files are in -devel * OK: no static libraries * OK: -devel requires pkgconfig * OK: .so file is in -devel * OK: -devel requires main package * OK: package does not contain .la archives * OK: no .desktop needed * OK: does not own files/directories from other packages * OK: buildroot is rm at beginning of install * OK: filenames seem to be valid utf8 c37a38cb27ecaa23c25f69a387c365fe librapi-0.9.3-1.src.rpm is APPROVED with this patch: - --- librapi.spec.1 2007-03-09 22:57:51.000000000 +0100 +++ librapi.spec 2007-04-27 10:45:09.000000000 +0200 @@ -10,6 +10,7 @@ BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildRequires: libsynce-devel +BuildRequires: libtool # Provide an upgrade path from the monilithic synce package Provides: synce = %{version}-%{release} @@ -39,14 +40,14 @@ %build %configure --disable-static --disable-rpath - -make %{?_smp_mflags} +make LIBTOOL=%{_bindir}/libtool %{?_smp_mflags} %install rm -rf $RPM_BUILD_ROOT make install DESTDIR=$RPM_BUILD_ROOT - -rm -f $RPM_BUILD_ROOT%{_libdir}/*.la +rm -f $RPM_BUILD_ROOT%{_libdir}/*.{la,a} %clean -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.