Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Re-Review Request: Maelstrom: space combat game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189375 ------- Additional Comments From wart(a)kobold.org 2006-04-19 13:03 EST ------- The .desktop file is also not installed using desktop-file-install. This will also require a new BuildRequires: desktop-file-utils. The icon cache isn't updated in %post and %postun like so: %post touch --no-create %{_datadir}/icons/hicolor || : if [ -x %{_bindir}/gtk-update-icon-cache ]; then %{_bindir}/gtk-update-icon-cache --quiet %{_datadir}/icons/hicolor || : fi -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Re-Review Request: Maelstrom: space combat game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189375 wart(a)kobold.org changed: What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO|163776 |163778 nThis| | -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Re-Review Request: Maelstrom: space combat game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189375 ------- Additional Comments From notting(a)redhat.com 2006-05-09 01:31 EST ------- Changes in CVS, including changing the setuid handling. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Re-Review Request: Maelstrom: space combat game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189375 ------- Additional Comments From wart(a)kobold.org 2006-05-11 15:34 EST ------- On to the full review: rpmlint output: E: Maelstrom file-in-usr-marked-as-conffile /usr/games/Maelstrom/Maelstrom-Scores - This can be ignored E: Maelstrom non-standard-executable-perm /usr/bin/Maelstrom 02755 - This is ok per the Games SIG guidelines for scoreboard files E: Maelstrom standard-dir-owned-by-package /usr/share/icons - Change the %files line to %{_datadir}/icons/hicolor/48x48/apps/* W: Maelstrom buildprereq-use SDL-devel, SDL_net-devel E: Maelstrom broken-syntax-in-scriptlet-requires BuildPrereq: SDL-devel, SDL_net-devel - Change BuildPrereq: to BuildRequires: MUST ==== * Source matches upstream * Package and spec file named appropriately * spec file legible and in Am. English. * Builds in mock on: FC4-i386 FC4-x86_64 devel-i386 devel-x86_64 * No locales * No -devel package needed * No need for -docs subpackage * No shared libs * .dekstop file installed correctly MUSTFIX ======= * See rpmlint notes above * BR: SDL-devel is redundant. It's picked up by SDL_net-devel * License is GPL, not LGPL * License file is included in upstream tarball, but not in %doc * There is a questionable clause in the COPYING file: "The artwork and sounds used by Maelstrom are copyright Ambrosia Software (http://www.ambrosiasw.com) and may not be redistributed separately from the Maelstrom public GPL release." * Makefile and Makefile.in should not be included in /usr/share/Maelstrom/Images or %{_docdir}/Docs SHOULD ====== * The following is a nice shell trick, but would be more readable if each file were removed individually, one per line. rm -f $RPM_BUILD_ROOT%{_bindir}/{Maelstrom-netd,macres,playwave,snd2wav} ...change to... rm -f $RPM_BUILD_ROOT%{_bindir}/Maelstrom-netd rm -f $RPM_BUILD_ROOT%{_bindir}/macres (and so on) * The BuildRoot tag is almost there. From http://fedoraproject.org/wiki/Packaging/Guidelines: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Re-Review Request: Maelstrom: space combat game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189375 ------- Additional Comments From notting(a)redhat.com 2006-05-16 15:49 EST ------- %{__id_u} -n? Cute. I wonder why anyone would ever want to macro override id. :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Re-Review Request: Maelstrom: space combat game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189375 ------- Additional Comments From notting(a)redhat.com 2006-05-17 15:07 EST ------- Doesn't mean it needs to be in the package. I'll hit up extras-list. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Re-Review Request: Maelstrom: space combat game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189375 ------- Additional Comments From wart(a)kobold.org 2006-06-03 21:39 EST ------- The ugly shell trick is still there, but I don't consider it a blocker. And now I'm scared to look at the filesystem spec... ;) The Release tag wasn't incremented for this latest set of changes, even though it was updated in the %changelog section. Make sure that the lateset %changelog entry matches the Release: tag before requesting a new build. I'll approve this as soon as we get clarification on the license issue. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Re-Review Request: Maelstrom: space combat game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189375 ------- Additional Comments From wart(a)kobold.org 2006-07-07 14:06 EST ------- Ping. Any response from upstream? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Re-Review Request: Maelstrom: space combat game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189375 ------- Additional Comments From kevin(a)tummy.com 2006-10-08 01:04 EST ------- Still no word from upstream on this? Is there any way to try and ask someone/somewhere else to get a response? -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Re-Review Request: Maelstrom: space combat game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189375 ------- Additional Comments From notting(a)redhat.com 2006-10-11 11:56 EST ------- Got a response: Sure. "GPL source code" is correct. :) I'll update the release, thanks! See ya! -Sam Lantinga, Senior Software Engineer, Blizzard Entertainment -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Re-Review Request: Maelstrom: space combat game https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=189375 notting(a)redhat.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE ------- Additional Comments From notting(a)redhat.com 2006-10-16 11:23 EST ------- OK, since the other changes are actually all in CVS already (and built during the rebuild for FC6), closing. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.