https://bugzilla.redhat.com/show_bug.cgi?id=1997521 Kees de Jong <kees.dejong+dev(a)neobits.nl&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Doc Type|--- |If docs needed, set a value --- Comment #1 from Kees de Jong <kees.dejong+dev(a)neobits.nl&gt; --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/tlog See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [-]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GNU General Public License, Version 2", "GNU General Public License v2.0 or later", "GNU General Public License v2.0 or later [generated file]", "Unknown or generated", "FSF Unlimited License (with Retention) GNU General Public License v2.0 or later [generated file]", "GNU General Public License v3.0 or later", "FSF Unlimited License [generated file]", "MIT License [generated file]", "GNU General Public License", "FSF Unlimited License (with Retention) GNU General Public License, Version 2", "FSF Unlimited License (with Retention)". 8 files have unknown license. Detailed output of licensecheck in /tmp/1997521-tlog/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Package uses hardened build flags if required to. Note: suid files: tlog-rec-session [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: Package contains systemd file(s) if in need. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: tlog-11-3.fc36.x86_64.rpm tlog-debuginfo-11-3.fc36.x86_64.rpm tlog-debugsource-11-3.fc36.x86_64.rpm tlog-11-3.fc36.src.rpm tlog.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/tlog-rec tlog.x86_64: E: missing-call-to-setgroups-before-setuid /usr/bin/tlog-rec-session tlog.x86_64: E: missing-call-to-setgroups-before-setuid /usr/lib64/libtlog.so.0.0.0 tlog.x86_64: W: non-standard-uid /usr/bin/tlog-rec-session tlog tlog.x86_64: W: non-standard-gid /usr/bin/tlog-rec-session tlog tlog.x86_64: E: setuid-binary /usr/bin/tlog-rec-session tlog 6755 tlog.x86_64: E: setgid-binary /usr/bin/tlog-rec-session tlog 6755 tlog.x86_64: E: non-standard-executable-perm /usr/bin/tlog-rec-session 6755 tlog.x86_64: E: postin-without-ldconfig /usr/lib64/libtlog.so.0.0.0 tlog.x86_64: W: empty-%post 4 packages and 0 specfiles checked; 7 errors, 3 warnings. Rpmlint (debuginfo) ------------------- Checking: tlog-debuginfo-11-3.fc36.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://github.com/Scribery/tlog/releases/download/v11/tlog-11.tar.gz : CHECKSUM(SHA256) this package : e22971bb2ee201b527a7e101ba02654262f09333ac802be3cebe93c6a5d397a6 CHECKSUM(SHA256) upstream package : e22971bb2ee201b527a7e101ba02654262f09333ac802be3cebe93c6a5d397a6 Requires -------- tlog (rpmlib, GLIBC filtered): /bin/sh config(tlog) libc.so.6()(64bit) libcurl.so.4()(64bit) libjson-c.so.5()(64bit) libjson-c.so.5(JSONC_0.14)(64bit) libm.so.6()(64bit) libsystemd.so.0()(64bit) libsystemd.so.0(LIBSYSTEMD_209)(64bit) libtlog.so.0()(64bit) libutempter.so.0()(64bit) libutempter.so.0(UTEMPTER_1.1)(64bit) rtld(GNU_HASH) tlog-debuginfo (rpmlib, GLIBC filtered): tlog-debugsource (rpmlib, GLIBC filtered): Provides -------- tlog: config(tlog) libtlog.so.0()(64bit) tlog tlog(x86-64) tlog-debuginfo: debuginfo(build-id) libtlog.so.0.0.0-11-3.fc36.x86_64.debug()(64bit) tlog-debuginfo tlog-debuginfo(x86-64) tlog-debugsource: tlog-debugsource tlog-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1997521 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic Disabled plugins: Perl, PHP, R, SugarActivity, Python, Haskell, Java, fonts, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug.