Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: viaideinfo - Displays information on connected VIA IDE controllers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211256 kevin(a)tummy.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody(a)fedoraproject.org |kevin(a)tummy.com OtherBugsDependingO|163776 |163779 nThis| | ------- Additional Comments From kevin(a)tummy.com 2006-10-19 00:21 EST ------- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPL) OK - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: e436a580eb8a047a0551cb996b11e6f5 viaideinfo-0.4.tar.gz e436a580eb8a047a0551cb996b11e6f5 viaideinfo-0.4.tar.gz.1 OK - Package has Exclusivearch OK - BuildRequires correct OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - No rpmlint output. OK - final provides and requires are sane: SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have dist tag OK - Should package latest version Issues: 1. Since this package has ExclusiveArch: %{ix86} I assume none of the supported VIA chipsets are shipped on x86_64? Works fine on my firewall machine with a VT82C586A/B. I don't see any blockers here at all, so this package is APPROVED. Don't forget to close this review request with NEXTRELEASE once it's been imported and built. Consider reviewing another waiting package to help spread out the reviewing load. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: viaideinfo - Displays information on connected VIA IDE controllers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211256 peter(a)thecodergeek.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE OtherBugsDependingO|163779 | nThis| | ------- Additional Comments From peter(a)thecodergeek.com 2006-10-19 03:00 EST ------- Imported, FC-5 branch requested, and devel build running on the build system. Thanks for the review! :) -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: viaideinfo - Displays information on connected VIA IDE controllers https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211256 ------- Additional Comments From peter(a)thecodergeek.com 2006-10-19 15:29 EST ------- (In reply to comment #4) Ack. Sorry about that; and thanks, Christian. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: viaideinfo - Displays information on connected VIA IDE controllers Alias: viaideinfo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=211256 peter(a)thecodergeek.com changed: What |Removed |Added ---------------------------------------------------------------------------- Alias| |viaideinfo -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.