[Bug 478743] New: Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software - package-review

List overview All Threads
Download

newer

[Bug 478743] New: Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software

older

[Bug 710203] New: Review Request:...

[Bug 613001] New: Review Request:...

Red Hat Bugzilla

4 Jan 2009 4 Jan '09

3:08 p.m.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

Summary: Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software

https://bugzilla.redhat.com/show_bug.cgi?id=478743

Summary: Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: rezso@rdsor.ro QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora

Spec URL: http://openrisc.rdsor.ro/saga.spec SRPM URL: http://openrisc.rdsor.ro/saga-2.0.3-1.fc11.src.rpm

Description: SAGA - short hand for "System for Automated Geoscientific Analyses" is a free, hybrid, cross-platform GIS software.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Show replies by date

Red Hat Bugzilla

19 Jan 19 Jan

5:09 p.m.

New subject: [Bug 478743] Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478743

Jerry James loganjerry@gmail.com changed:

--- Comment #1 from Jerry James loganjerry@gmail.com 2009-01-19 12:09:38 EDT --- I'll review this. I tried building it on F-10, and got the following output at the end of the rpmbuild run:

RPM build errors: Installed (but unpackaged) file(s) found: /usr/lib64/libsaga_api.a /usr/lib64/saga/libcontrib_a_perego.a /usr/lib64/saga/libgeostatistics_grid.a /usr/lib64/saga/libgeostatistics_kriging_variogram.a /usr/lib64/saga/libgeostatistics_points.a /usr/lib64/saga/libgrid_analysis.a /usr/lib64/saga/libgrid_calculus.a /usr/lib64/saga/libgrid_discretisation.a /usr/lib64/saga/libgrid_filter.a /usr/lib64/saga/libgrid_gridding.a /usr/lib64/saga/libgrid_spline.a /usr/lib64/saga/libgrid_tools.a /usr/lib64/saga/libgrid_visualisation.a /usr/lib64/saga/libio_esri_e00.a /usr/lib64/saga/libio_gps.a /usr/lib64/saga/libio_grid.a /usr/lib64/saga/libio_grid_gdal.a /usr/lib64/saga/libio_grid_grib2.a /usr/lib64/saga/libio_grid_image.a /usr/lib64/saga/libio_shapes.a /usr/lib64/saga/libio_shapes_dxf.a /usr/lib64/saga/liblectures_introduction.a /usr/lib64/saga/libpj_georeference.a /usr/lib64/saga/libpj_proj4.a /usr/lib64/saga/librecreations_fractals.a /usr/lib64/saga/librecreations_games.a /usr/lib64/saga/libshapes_grid.a /usr/lib64/saga/libshapes_lines.a /usr/lib64/saga/libshapes_points.a /usr/lib64/saga/libshapes_polygons.a /usr/lib64/saga/libshapes_tools.a /usr/lib64/saga/libsim_cellular_automata.a /usr/lib64/saga/libsim_ecosystems_hugget.a /usr/lib64/saga/libsim_fire_spreading.a /usr/lib64/saga/libsim_hydrology.a /usr/lib64/saga/libta_channels.a /usr/lib64/saga/libta_hydrology.a /usr/lib64/saga/libta_lighting.a /usr/lib64/saga/libta_morphometry.a /usr/lib64/saga/libta_preprocessor.a /usr/lib64/saga/libta_profiles.a /usr/lib64/saga/libtable_calculus.a /usr/lib64/saga/libtable_tools.a /usr/lib64/saga/libtin_tools.a

Since you built shared libraries, too, you probably don't want to build the static libraries. I suggest passing --disable-static to %configure. I also see that you are installing the *.la files. Normally, this should not be done; see https://fedoraproject.org/wiki/Packaging/Guidelines#StaticLibraries. Is there some reason for installing those files in this case?

I'll do a full review shortly.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5:18 p.m.

New subject: [Bug 478743] Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478743

--- Comment #2 from Jerry James loganjerry@gmail.com 2009-01-19 12:17:59 EDT --- Sorry, I read the spec file incorrectly. You are excluding the .la files. So I've added --disable-static to my copy of the spec file to get a clean build and will base a review on that.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

7:15 p.m.

New subject: [Bug 478743] Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478743

--- Comment #3 from Jerry James loganjerry@gmail.com 2009-01-19 14:15:17 EDT --- It turns out that adding --disable-static isn't enough. Your attempt to use the system libtool wasn't quite right. You need to pass the -f flag to autoreconf, and throw away the first of your two sed invocations. That it, the %build section should contain this:

autoreconf -i -f sed -i -e 's|SG_T("LD_LIBRARY_PATH")|SG_T("%{_libdir}")|g' \ src/saga_core/saga_api/module_library.cpp

%configure --enable-unicode --disable-static

make %{?_smp_mflags}

Even then, rpmlint shows that there are still some problems in this package. This is what I get:

saga.x86_64: E: standard-dir-owned-by-package /usr/bin saga.x86_64: E: library-without-ldconfig-postin /usr/lib64/libsaga_api.so.0.0.0 saga.x86_64: E: library-without-ldconfig-postun /usr/lib64/libsaga_api.so.0.0.0 saga.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/saga-2.0.3/AUTHORS saga.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/saga-2.0.3/NEWS saga.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/saga-2.0.3/ChangeLog saga.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/saga-2.0.3/README saga.x86_64: E: no-ldconfig-symlink /usr/lib64/libsaga_api.so.0.0.0 saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0 /usr/lib64/libwx_gtk2u_richtext-2.8.so.0 saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0 /usr/lib64/libwx_gtk2u_aui-2.8.so.0 saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0 /usr/lib64/libwx_gtk2u_xrc-2.8.so.0 saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0 /usr/lib64/libwx_gtk2u_qa-2.8.so.0 saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0 /usr/lib64/libwx_gtk2u_html-2.8.so.0 saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0 /usr/lib64/libwx_gtk2u_adv-2.8.so.0 saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0 /usr/lib64/libwx_baseu_xml-2.8.so.0 saga.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libsaga_api.so.0.0.0 /usr/lib64/libwx_baseu_net-2.8.so.0

Finally, I see in the build output that there are a number of incorrect printf directives in this program. They may cause no harm, but it is probably worth checking whether they will cause any trouble. Look for warnings of the form:

warning: format '%FLAG' expects type 'TYPE1' but argument N has type 'TYPE2'

Some of those look like they will print integers incorrectly on 64-bit platforms.

Can you fix all of this and roll a new package so I don't get confused as to what you have and what I changed? Thanks. If you need a hand with any of it, let me know.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

23 Feb 23 Feb

3:44 p.m.

New subject: [Bug 478743] Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478743

--- Comment #4 from Jerry James loganjerry@gmail.com 2009-02-23 10:44:23 EDT --- Ping.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

26 Feb 26 Feb

2:53 p.m.

New subject: [Bug 478743] Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478743

Jerry James loganjerry@gmail.com changed:

--- Comment #5 from Jerry James loganjerry@gmail.com 2009-02-26 09:53:17 EDT --- Let me know when you are ready to proceed with this review.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

13 May 13 May

5:47 p.m.

New subject: [Bug 478743] Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478743

--- Comment #6 from Jerry James loganjerry@gmail.com 2009-05-13 12:47:25 EDT --- This review is stalled. Please respond with one week.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

21 May 21 May

10:01 p.m.

New subject: [Bug 478743] Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478743

Jerry James loganjerry@gmail.com changed:

--- Comment #7 from Jerry James loganjerry@gmail.com 2009-05-21 17:01:06 EDT --- The submitter has not responded. I am closing this bug.

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

Red Hat Bugzilla

5 Oct 5 Oct

1:26 a.m.

New subject: [Bug 478743] Review Request: saga - SAGA is a free, hybrid, cross-platform GIS software

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.

https://bugzilla.redhat.com/show_bug.cgi?id=478743

Ken Dreyer ktdreyer@ktdreyer.com changed:

--- Comment #8 from Ken Dreyer ktdreyer@ktdreyer.com 2011-10-04 20:26:10 EDT ---

*** This bug has been marked as a duplicate of bug 737401 ***

-- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug.

4654

Age (days ago)

5658

Last active (days ago)

package-review@lists.fedoraproject.org

8 comments

1 participants

tags (0)

participants (1)

Red Hat Bugzilla