https://bugzilla.redhat.com/show_bug.cgi?id=1437937 Nicolas Chauvet (kwizart) <kwizart(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1437885 Referenced Bugs: https://bugzilla.redhat.com/show_bug.cgi?id=1437885 [Bug 1437885] libva-1.8.0 is available -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1437937 --- Comment #3 from Mattia Verga <mattia.verga(a)email.it&gt; --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [X]: Package does not contain kernel modules. [X]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [X]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 84 files have unknown license. Detailed output of licensecheck in /home/rpmbuild/1437937 -libva-utils/licensecheck.txt [X]: License file installed when any subpackage combination is installed. [X]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/.build- id/b6(kactivitymanagerd, powerdevil, kernel-devel, kde-print-manager, libkscreen-qt5, abrt-addon-xorg, valgrind, kde-runtime-libs, libevent, kwin-common, python-gobject), /usr/lib/.build-id/42(libuser, kdelibs, ImageMagick-libs, kf5-kcrash, gtk3, samba-client), /usr/lib/.build- id(webkitgtk4-jsc, abrt-python3, cups-client, efivar-libs, gc, policycoreutils-python-utils, gdbm, poppler, gpgme, rpm-plugin- selinux, abrt, kgpg, libreport-plugin-systemd-journal, libqmi-utils, gtk3, libv4l, ksysguardd, kompare-libs, rpm-build, device-mapper- persistent-data, cryptsetup-libs, plasma-breeze, plasma-nm-openvpn, libselinux-utils, libblockdev-btrfs, gnome-disk-utility, bluez-libs, mesa-libwayland-egl, libblockdev-mdraid, libinput, libxslt, libreport- cli, plasma-workspace-drkonqi, system-config-printer-udev, abrt-gui- libs, keyutils-libs, python2-cryptography, libgpg-error, audit-libs- python3, kscreen, sane-backends-libs, plasma-nm, python2-rpm, adwaita- gtk2-theme, anaconda-core, plasma-integration, kdelibs-webkit, kdeplasma-addons, libkworkspace5, vte291, sssd-krb5, kcolorchooser, plasma-pa, qt5-style-oxygen, libsss_nss_idmap, qemu-guest-agent, sssd- common-pac, libblockdev-swap, giflib, libsmbclient, python3-gobject, plasma-user-manager, pam-kwallet, krb5-workstation, apper, kdepimlibs- akonadi, harfbuzz-devel, lazarus, drpm, libblockdev-utils, network- manager-applet, kamera, anaconda-widgets, sssd-ad, dolphin, keditbookmarks-libs, gcc, fpc, alsa-lib, abrt-libs, efibootmgr, mesa- dri-drivers, baloo-libs, samba-common-libs, libreswan, libreport- plugin-logger, gvfs-archive, libblockdev-kbd, python3-rpm, qupzilla, qt5-qttools-libs-designer, openssh-clients, libuser, perl-libs, abrt- retrace-client, mbedtls, boost-date-time, python3-cryptography, kactivitymanagerd, kwrited, satyr, xorg-x11-drv-ati, policycoreutils, abrt-plugin-bodhi, libbluray, poppler-qt5, kcharselect, krb5-devel, konsole5-part, powerdevil, python3-systemd, ibus-libs, libblockdev- mpath, mesa-libxatracker, audit-libs, nss-sysinit, bluez, libgcc, gettext-libs, system-python, polkit-kde, plasma-workspace-geolocation, abrt-gui, at-spi2-core, baloo-widgets, git, qt-x11, poppler-glib, kdepimlibs-gpgme, libkscreen-qt5, openssh, atk, libblockdev-lvm, ibus- gtk3, ibus-gtk2, perl-Net-SSLeay, cryptsetup, udisks2, ImageMagick, gssproxy, harfbuzz, cups, gtk-update-icon-cache, vim-minimal, harfbuzz-icu, libgfortran, libpkgconf, libplist, python3-wrapt, gvfs- client, NetworkManager-libnm, kwin-common, NetworkManager, kf5-kipi- plugins-libs, NetworkManager-glib, kcalc, kfind, authconfig, mesa- libGL, ksysguard, kscreenlocker, abrt-addon-ccpp, kruler, sddm-kcm, plasma-nm-openconnect, pcre-utf16, python-gobject, xfce4-notifyd, plasma-nm-openswan, PackageKit-gstreamer-plugin, libblockdev, spectacle, dconf, xorg-x11-drv-wacom, mesa-libgbm, liblogging-stdlog, samba-client-libs, python-gobject-base, boost-chrono, gwenview-libs, kompare, samba-client, sssd-nfs-idmap, kinfocenter, libwbclient, kdegraphics-thumbnailers, kio-extras, gpgmepp, gwenview, libquadmath, rpm-libs, kdelibs, libreport, gcc-gdb-plugin, libreport-gtk, nss- tools, lmdb-libs, libevent, kf5-libkdcraw, kde-print-manager, iproute, xmlrpc-c-client, plasma-desktop, konsole5, kwrite, libsss_idmap, gobject-introspection, boost-atomic, keyutils, python3-hawkey, os- prober, gcc-c++, libblockdev-dm, iproute-tc, NetworkManager-wifi, qt, kernel-core, kexec-tools, PackageKit-glib, krb5-libs, kwayland- integration, pkgconf, rpcbind, kf5-plasma, pcre-cpp, rhash, openssh- askpass, sssd-ipa, kwin-libs, libsss_autofs, ark, plasma-nm-l2tp, libqmi, sssd-client, kf5-libkipi, GeoIP, llvm-libs, sssd-ldap, libreport-plugin-reportuploader, doxygen, valgrind, kdesu, nss- softokn, system-python-libs, geoclue2, cups-filters-libs, binutils, poppler-utils, kf5-libkexiv2, gnupg2-smime, webkitgtk4, libblockdev- loop, xorg-x11-server-Xorg, NetworkManager-adsl, open-vm-tools- desktop, plasma-nm-pptp, plasma-workspace-libs, gnupg2, perl-IO, newt, glib2-devel, libreport-plugin-ureport, webkitgtk4-plugin-process-gtk2, openvpn, libdnf, nfs-utils, libreport-plugin-kerneloops, abrt-addon- pstoreoops, bluez-obexd, sssd-krb5-common, libksysguard, qgpgme, plasma-nm-vpnc, nm-connection-editor, libselinux, libudisks2, konqueror-libs, cups-filters, zenity, libksysguard-common, bluez-cups, xfwm4, libnm-gtk, kf5-kcrash, kdialog, coreutils, khelpcenter, gvfs, pam, NetworkManager-bluetooth, plasma-workspace-geolocation-libs, fuse, augeas-libs, audit, cups-libs, libappstream-glib, abrt-dbus, kde-cli-tools, at-spi2-atk, NetworkManager-team, kde-print-manager- libs, kwin-wayland, plasma-workspace, boost-filesystem, libtevent, nss-pem, ibus-wayland, libipa_hbac, rpm-build-libs, libnghttp2, newt- python3, boost-system, libsolv, libuser-python, gmp, python3-gpg, libselinux-python3, NetworkManager-wwan, libdrm, kget-libs, libreport- python3, pcre2, python3, konqueror, kde-gtk-config, keybinder3, xmlrpc-c, fuse-libs, python3-gobject-base, xorg-x11-server-Xwayland, kdnssd, json-glib, libsss_sudo, libssh, boost-thread, sssd-common, rpm, newt-python, plasma-milou, dolphin-libs, btrfs-progs, plasma- systemsettings, abrt-addon-coredump-helper, mesa-libglapi, glx-utils, khotkeys, qt5-qttools, PackageKit, libreport-web, rpm-plugin-systemd- inhibit, libgomp, libkadm5, kwalletmanager5, glib2, ark-libs, ImageMagick-libs, kernel-devel, libstdc++, libgee, kde-runtime-libs, nss, pcre, mesa-libEGL, kmenuedit, libselinux-python, git-core, libobjc, libiptcdata, openssh-server, kde-style-breeze, libblockdev- crypto, keditbookmarks, info, ksshaskpass, libblockdev-part, kde- runtime, kdelibs-ktexteditor, nss-util, LibRaw, libreport-plugin- bugzilla, qt5-qdbusviewer, skychart, kwin, ibus, kdepimlibs, at, gtk3 -immodule-xim, abrt-addon-kerneloops, kdepimlibs-kxmlrpcclient, cmake, libblockdev-fs, libnma, gettext, kget, nss-softokn-freebl, open-vm- tools, bluedevil, openslp, abrt-tui, pcre-utf32, libkomparediff2, gtk3-devel, chrony, abrt-addon-xorg, sssd-proxy, cpp, kdecoration), /usr/lib/.build-id/97(sssd-common, plasma-nm-pptp, plasma-workspace- libs, kwin, powerdevil, coreutils, kde-runtime-libs, nss-softokn, libxslt, plasma-desktop), /usr/lib/.build-id/78(kio-extras, mesa-dri- drivers, kdelibs, kdnssd, kwin-wayland, libreswan), /usr/lib/.build- id/86(audit, openssh-clients, kdegraphics-thumbnailers, plasma- workspace-libs, apper, kde-runtime, nfs-utils, libinput, kscreenlocker, plasma-desktop, konsole5, newt, libreport-cli), /usr/lib/.build-id/17(fpc, PackageKit, ImageMagick-libs, coreutils, kdepimlibs, kget-libs, kde-runtime-libs, system-python-libs), /usr/lib /.build-id/09(sssd-common, libgfortran, kdegraphics-thumbnailers, konsole5-part, kdelibs, samba-client-libs, nfs-utils, coreutils, python2-rpm, libuser-python, llvm-libs, binutils), /usr/lib/.build- id/ae(konqueror, poppler-utils, kio-extras, ImageMagick-libs, valgrind, kernel-devel, plasma-breeze, kde-runtime), /usr/lib/.build- id/03(xorg-x11-server-Xorg, kf5-plasma, krb5-workstation, coreutils, kde-runtime-libs, system-python-libs, plasma-desktop) [X]: %build honors applicable compiler flags or justifies otherwise. [X]: Package contains no bundled libraries without FPC exception. [X]: Changelog in prescribed format. [X]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [X]: Package uses nothing in %doc for runtime. [X]: Package consistently uses macros (instead of hard-coded directory names). [X]: Package is named according to the Package Naming Guidelines. [X]: Package does not generate any conflict. [X]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [X]: Requires correct, justified where necessary. [X]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [X]: Useful -debuginfo package or justification otherwise. [X]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [X]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [X]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in libva- utils-debuginfo [X]: Package functions as described. [X]: Latest version is packaged. [X]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [X]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [X]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libva-utils-1.8.0-1.fc27.x86_64.rpm libva-utils-debuginfo-1.8.0-1.fc27.x86_64.rpm libva-utils-1.8.0-1.fc27.src.rpm libva-utils.x86_64: W: only-non-binary-in-usr-lib libva-utils.x86_64: W: hidden-file-or-dir /usr/lib/.build-id libva-utils.x86_64: W: hidden-file-or-dir /usr/lib/.build-id libva-utils.x86_64: W: no-manual-page-for-binary avcenc libva-utils.x86_64: W: no-manual-page-for-binary h264encode libva-utils.x86_64: W: no-manual-page-for-binary jpegenc libva-utils.x86_64: W: no-manual-page-for-binary loadjpeg libva-utils.x86_64: W: no-manual-page-for-binary mpeg2vaenc libva-utils.x86_64: W: no-manual-page-for-binary mpeg2vldemo libva-utils.x86_64: W: no-manual-page-for-binary putsurface libva-utils.x86_64: W: no-manual-page-for-binary putsurface_wayland libva-utils.x86_64: W: no-manual-page-for-binary vainfo libva-utils-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/libva-utils-1.8.0-1.fc27.x86_64/common/loadsurface.h libva-utils-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/libva-utils-1.8.0-1.fc27.x86_64/putsurface/putsurface_common.c libva-utils.src: W: spelling-error Summary(en_US) vainfo -> vain libva-utils.src: W: spelling-error %description -l en_US vainfo -> vain libva-utils.src:9: W: mixed-use-of-spaces-and-tabs (spaces: line 9, tab: line 1) 3 packages and 0 specfiles checked; 0 errors, 17 warnings. Rpmlint (debuginfo) ------------------- Checking: libva-utils-debuginfo-1.8.0-1.fc27.x86_64.rpm libva-utils-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/libva-utils-1.8.0-1.fc27.x86_64/common/loadsurface.h libva-utils-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/libva-utils-1.8.0-1.fc27.x86_64/putsurface/putsurface_common.c 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory libva-utils-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/libva-utils-1.8.0-1.fc27.x86_64/common/loadsurface.h libva-utils-debuginfo.x86_64: W: spurious-executable-perm /usr/src/debug/libva-utils-1.8.0-1.fc27.x86_64/putsurface/putsurface_common.c libva-utils.x86_64: W: only-non-binary-in-usr-lib libva-utils.x86_64: W: hidden-file-or-dir /usr/lib/.build-id libva-utils.x86_64: W: hidden-file-or-dir /usr/lib/.build-id libva-utils.x86_64: W: no-manual-page-for-binary avcenc libva-utils.x86_64: W: no-manual-page-for-binary h264encode libva-utils.x86_64: W: no-manual-page-for-binary jpegenc libva-utils.x86_64: W: no-manual-page-for-binary loadjpeg libva-utils.x86_64: W: no-manual-page-for-binary mpeg2vaenc libva-utils.x86_64: W: no-manual-page-for-binary mpeg2vldemo libva-utils.x86_64: W: no-manual-page-for-binary putsurface libva-utils.x86_64: W: no-manual-page-for-binary putsurface_wayland libva-utils.x86_64: W: no-manual-page-for-binary vainfo 2 packages and 0 specfiles checked; 0 errors, 14 warnings. Requires -------- libva-utils-debuginfo (rpmlib, GLIBC filtered): libva-utils (rpmlib, GLIBC filtered): libX11.so.6()(64bit) libc.so.6()(64bit) libdrm.so.2()(64bit) libgcc_s.so.1()(64bit) libm.so.6()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libva-drm.so.1()(64bit) libva-wayland.so.1()(64bit) libva-x11.so.1()(64bit) libva.so.1()(64bit) libva.so.1(VA_API_0.33.0)(64bit) libwayland-client.so.0()(64bit) rtld(GNU_HASH) Provides -------- libva-utils-debuginfo: libva-utils-debuginfo libva-utils-debuginfo(x86-64) libva-utils: libva-utils libva-utils(x86-64) Source checksums ---------------- https://github.com/01org/libva-utils/archive/1.8.0.tar.gz#/libva-utils-1.... : CHECKSUM(SHA256) this package : 2a7590c8428d0b453b004702c4c515669403cea27f9f17b2560b38da337ec943 CHECKSUM(SHA256) upstream package : 2a7590c8428d0b453b004702c4c515669403cea27f9f17b2560b38da337ec943 AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: libva-utils-1.8.0/configure.ac:99 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1437937 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1437937 --- Comment #5 from Nicolas Chauvet (kwizart) <kwizart(a)gmail.com&gt; --- Thanks for the review Mattia. Most of theses files from the BSD licenses are from the test suite. We don't enable the test suite as this would requires a given vaapi backend implementation to be available from the builders. Also the test suite isn't meant to be redistributed. About the old macros, I've submitted a PR upstream: https://github.com/01org/libva-utils/pull/31 (test suite still pending). -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1437937 --- Comment #7 from Nicolas Chauvet (kwizart) <kwizart(a)gmail.com&gt; --- (In reply to Mattia Verga from comment #6) ... ACk -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component

https://bugzilla.redhat.com/show_bug.cgi?id=1437937 Nicolas Chauvet (kwizart) <kwizart(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2017-04-04 15:52:41 --- Comment #9 from Nicolas Chauvet (kwizart) <kwizart(a)gmail.com&gt; --- Thx for the review. License field added. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component