Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pysol - A Python Solitaire game collection

https://bugzilla.redhat.com/show_bug.cgi?id=304301

s.adam@diffingo.com changed:

What |Removed |Added ---------------------------------------------------------------------------- OtherBugsDependingO| |304331 nThis| |

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pysol - A Python Solitaire game collection

https://bugzilla.redhat.com/show_bug.cgi?id=304301

tibbs@math.uh.edu changed:

What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Status|NEW |ASSIGNED Flag| |fedora-review?

------- Additional Comments From tibbs@math.uh.edu 2007-09-25 01:32 EST ------- This builds OK for me; rpmlint says:

pysol.x86_64: E: non-executable-script /usr/share/pysol/pysol.py 0644 This should probably be executable as the script is actually runnable, but I guess it's not the intended means of starting the game.

pysol.x86_64: E: no-binary Is there some reason this package isn't noarch?

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pysol - A Python Solitaire game collection

https://bugzilla.redhat.com/show_bug.cgi?id=304301

------- Additional Comments From tibbs@math.uh.edu 2007-09-26 16:11 EST ------- This builds fine and rpmlint is clean; I'll run through the checklist as soon as I get home this evening. But unfortunately it doesn't run:

ImportError: No module named pysolsoundserver

This happens even if I pass --nosound. It looks like there's code to detect that the module isn't there (look for warn_pysolsoundserver) but the import isn't wrapped in a try block. When I get home I'll have to see if I can't hack it a bit. Or this could grow a dependency on the sound server, except that it would have to be a circular dependency, and in that case they should probably just be bundled together in one package.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pysol - A Python Solitaire game collection

https://bugzilla.redhat.com/show_bug.cgi?id=304301

------- Additional Comments From tibbs@math.uh.edu 2007-09-27 11:44 EST ------- Hmm, yes, that hack works. A few issues cropped up in testing, though:

One, which I don't think is a blocker but is annoying, is that when you start pysol from the command line you get a bunch of spew:

Error loading plugin /usr/share/pysol/games/acesup.py: duplicate game ID 903 Error loading plugin /usr/share/pysol/games/auldlangsyne.py: duplicate game ID 172 [etc...]

I thought it was loading both the uncompiled and compiled versions of each file, but I deleted the .py[oc] files and it still happens.

Another issue is that I can't pick many of the games; for example, Baker's Dozen just gives me a dialog (that I can't paste from, damn it) containing:

Internal error. Please report this bug: <type 'exceptions.TypeError'>: unbound method startGame() must be called with CastlesInSpain instance as first argument (got BakersDozen instance instead)

Perhaps it's related to the previous issue.

There are also a couple of review issues:

Source: tags should be URLs if possible. I don't see where pysol-4.82.tar.bz2 comes from, though; upstream only has the -src tarball. Where'd you get it?

Might as well tack a period onto the end of %description.

Review: ? can't check if source files match upstream. * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK (could use a period, I guess). * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (development, x86_64). * package installs properly * rpmlint is silent. * final provides and requires are sane: pysol = 4.82-5.fc8 = /bin/sh /usr/bin/env tcl tix tk tkinter X Manual testing shows many issues. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package. * desktop file looks good.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pysol - A Python Solitaire game collection

https://bugzilla.redhat.com/show_bug.cgi?id=304301

------- Additional Comments From tibbs@math.uh.edu 2007-09-27 19:50 EST ------- Hmm, well, please do include the URL for the tarball that is still available (if it's the same as what's in this package, of course) and add a comment to the spec explaining that the other tarball is no longer available from upstream.

About the duplicate GameID thing, I don't think the spew in itself is a problem, but the fact that the game crashes (and will then crash continuously until you delete ~/.pysol) if you select a good portion of the games seems to be a significant problem to me. I can't tell if the two problems are related, though. For example, the game Cruel is broken but it doesn't show up in the complaints about duplicate IDs.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pysol - A Python Solitaire game collection

https://bugzilla.redhat.com/show_bug.cgi?id=304301

------- Additional Comments From tibbs@math.uh.edu 2007-09-27 22:12 EST ------- Well, I know I've played pysol since 2003. The source hasn't changed, so perhaps something has changed with Python which has caused this breakage.

I don't know nearly enough about Python to have any clue what might have changed, but at least it's a place to start.

Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.

Summary: Review Request: pysol - A Python Solitaire game collection

https://bugzilla.redhat.com/show_bug.cgi?id=304301

s.adam@diffingo.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |WONTFIX