https://bugzilla.redhat.com/show_bug.cgi?id=1171607

Parag pnemade@redhat.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1171608

Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1171608 [Bug 1171608] Review Request: nodejs-require-uncached - Require a module bypassing the cache

https://bugzilla.redhat.com/show_bug.cgi?id=1171607

Piotr Popieluch piotr1212@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr1212@gmail.com Assignee|nobody@fedoraproject.org |piotr1212@gmail.com Flags| |fedora-review+

--- Comment #1 from Piotr Popieluch piotr1212@gmail.com --- APPROVED

Package Review ==============

Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed

===== MUST items =====

Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/piotr/rpmbuild/1171607-nodejs-caller- path/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [.]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.

Rpmlint ------- Checking: nodejs-caller-path-0.1.0-1.fc22.noarch.rpm nodejs-caller-path-0.1.0-1.fc22.src.rpm nodejs-caller-path.noarch: W: only-non-binary-in-usr-lib nodejs-caller-path.noarch: W: dangling-symlink /usr/lib/node_modules/caller-path/node_modules/callsites /usr/lib/node_modules/callsites 2 packages and 0 specfiles checked; 0 errors, 2 warnings.

Rpmlint (installed packages) ---------------------------- ]0;<mock-chroot><mock-chroot>[root@pontifex /]# rpmlint nodejs-caller-path nodejs-caller-path.noarch: W: only-non-binary-in-usr-lib nodejs-caller-path.noarch: W: dangling-symlink /usr/lib/node_modules/caller-path/node_modules/callsites /usr/lib/node_modules/callsites 1 packages and 0 specfiles checked; 0 errors, 2 warnings. ]0;<mock-chroot><mock-chroot>[root@pontifex /]# echo 'rpmlint-done:'

Requires -------- nodejs-caller-path (rpmlib, GLIBC filtered): nodejs(engine) npm(callsites)

Provides -------- nodejs-caller-path: nodejs-caller-path npm(caller-path)

Source checksums ---------------- https://raw.githubusercontent.com/sindresorhus/caller-path/master/test.js : CHECKSUM(SHA256) this package : 0e26ee60f8cb42d4b013c2a68439e83947d76eb8fc1ac6d03bf365b482c61f05 CHECKSUM(SHA256) upstream package : 0e26ee60f8cb42d4b013c2a68439e83947d76eb8fc1ac6d03bf365b482c61f05 http://registry.npmjs.org/caller-path/-/caller-path-0.1.0.tgz : CHECKSUM(SHA256) this package : ed68cc7e1c03ff41f6dc57f857113f23ef3ef6c1e8d4615fd59e00e724dfd4eb CHECKSUM(SHA256) upstream package : ed68cc7e1c03ff41f6dc57f857113f23ef3ef6c1e8d4615fd59e00e724dfd4eb https://raw.githubusercontent.com/sindresorhus/caller-path/master/license : CHECKSUM(SHA256) this package : 6fb9754611c20f6649f68805e8c990e83261f29316e29de9e6cedae607b8634c CHECKSUM(SHA256) upstream package : 6fb9754611c20f6649f68805e8c990e83261f29316e29de9e6cedae607b8634c

Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1171607 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

https://bugzilla.redhat.com/show_bug.cgi?id=1171607

Jon Ciesla limburgher@gmail.com changed:

What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+

https://bugzilla.redhat.com/show_bug.cgi?id=1171607

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED

https://bugzilla.redhat.com/show_bug.cgi?id=1171607

--- Comment #5 from Fedora Update System updates@fedoraproject.org --- nodejs-caller-path-0.1.0-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-caller-path-0.1.0-1.fc20

https://bugzilla.redhat.com/show_bug.cgi?id=1171607

--- Comment #7 from Fedora Update System updates@fedoraproject.org --- nodejs-caller-path-0.1.0-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-caller-path-0.1.0-1.el6

https://bugzilla.redhat.com/show_bug.cgi?id=1171607

--- Comment #9 from Parag pnemade@redhat.com --- Built in rawhide, therefore closing this now.

https://bugzilla.redhat.com/show_bug.cgi?id=1171607 Bug 1171607 depends on bug 1171606, which changed state.

Bug 1171606 Summary: Review Request: nodejs-callsites - Get callsites from the V8 stack trace API https://bugzilla.redhat.com/show_bug.cgi?id=1171606

What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE

https://bugzilla.redhat.com/show_bug.cgi?id=1171607

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-caller-path-0.1.0-1. |nodejs-caller-path-0.1.0-1. |fc21 |fc20

--- Comment #11 from Fedora Update System updates@fedoraproject.org --- nodejs-caller-path-0.1.0-1.fc20 has been pushed to the Fedora 20 stable repository.

https://bugzilla.redhat.com/show_bug.cgi?id=1171607

Fedora Update System updates@fedoraproject.org changed:

What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-caller-path-0.1.0-1. |nodejs-caller-path-0.1.0-1. |el6 |el7

--- Comment #13 from Fedora Update System updates@fedoraproject.org --- nodejs-caller-path-0.1.0-1.el7 has been pushed to the Fedora EPEL 7 stable repository.