10:25 a.m.
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
Summary: sound-theme-fedora - Sound theme for Fedora
https://bugzilla.redhat.com/show_bug.cgi?id=522148
Summary: sound-theme-fedora - Sound theme for Fedora
Product: Fedora
Version: rawhide
Platform: All
OS/Version: Linux
Status: NEW
Severity: medium
Priority: low
Component: Package Review
AssignedTo: nobody(a)fedoraproject.org
ReportedBy: mclasen(a)redhat.com
QAContact: extras-qa(a)fedoraproject.org
CC: notting(a)redhat.com, fedora-package-review(a)redhat.com
Estimated Hours: 0.0
Classification: Fedora
Target Release: ---
spec: http://people.redhat.com/mclasen/sound-theme-fedora.spec
srpm: http://people.redhat.com/mclasen/sound-theme-fedora-1.0-1.fc12.src.rpm
Description:
A sound theme for Fedora. It is strongly based on the freedesktop sound
theme and just does some small tweaks to it.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:35 a.m.
New subject: [Bug 522148] sound-theme-fedora - Sound theme for Fedora
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=522148
--- Comment #1 from Matthias Clasen <mclasen(a)redhat.com> 2009-09-09 11:35:00 EDT
---
spec: http://people.redhat.com/mclasen/sound-theme-fedora.spec
srpm: http://people.redhat.com/mclasen/sound-theme-fedora-1.0-2.fc12.src.rpm
now with an 'upstream'
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11:12 a.m.
New subject: [Bug 522148] sound-theme-fedora - Sound theme for Fedora
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=522148
Adel Gadllah <adel.gadllah(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |adel.gadllah(a)gmail.com
Flag| |fedora-review?
--- Comment #2 from Adel Gadllah <adel.gadllah(a)gmail.com> 2009-09-09 12:12:25 EDT
---
==== REVIEW ===
[+] source files match upstream: 4a67db39035533d3cf17b0f31355a42d7cd49270
[+] package meets naming and versioning guidelines.
[+] specfile is properly named, is cleanly written and uses macros
consistently.
[+] dist tag is present.
[+] build root is correct.
[+] license field matches the actual license.
[+] license is open source-compatible: GPLv2+ and CC-BY
[+] license text included in package.
[+] latest version is being packaged.
[+] BuildRequires are proper.
[+] %clean is present.
[+] package builds in koji:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1665688
[+] package installs properly.
[-][1] rpmlint is silent.
[+] final provides and requires are sane:
sound-theme-fedora = 1.0-2.fc12
----
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
sound-theme-freedesktop
rpmlib(PayloadIsXz) <= 5.2-1
[+] no shared libraries are added to the regular linker search paths.
[+] owns the directories it creates.
[+] doesn't own any directories it shouldn't.
[+] no duplicates in %files.
[+] file permissions are appropriate.
[+] documentation is small, so no -docs subpackage is necessary.
[+] %docs are not necessary for the proper functioning of the package.
[+] no headers.
[+] no pkgconfig files.
[+] no libtool .la droppings.
=== COMMENTS ====
1) sound-theme-fedora.noarch: E: zero-length
/usr/share/sounds/Fedora/stereo/tooltip-popup.disabled
I suppose this is on purpose to silence the tooltip sound, correct?
2) AUTHORS not packaged and no parallel make (one might argue that both does
not make sense for this package)
Please comment on them and I will approve the package.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11:17 a.m.
New subject: [Bug 522148] sound-theme-fedora - Sound theme for Fedora
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=522148
--- Comment #3 from Matthias Clasen <mclasen(a)redhat.com> 2009-09-09 12:17:44 EDT
---
/usr/share/sounds/Fedora/stereo/tooltip-popup.disabled
I suppose this is on purpose to silence the tooltip sound, correct?
Indeed. It seems impossible to silence both tooltips and rpmlint at the same
time... rpmlint really has no business deciding if empty files are ok in my
package or not.
AUTHORS not packaged and no parallel make (one might argue that both
does
not make sense for this package)
AUTHORS is not very interesting, but I'll add it when I build the package. That
was just an oversight...
Parallel make really is a bit of a snake oil thing to begin with. I am not
going to install 3 files faster by doing it on 8 processors...
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11:41 a.m.
New subject: [Bug 522148] sound-theme-fedora - Sound theme for Fedora
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=522148
Adel Gadllah <adel.gadllah(a)gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-review? |fedora-review+
--- Comment #4 from Adel Gadllah <adel.gadllah(a)gmail.com> 2009-09-09 12:41:55 EDT
---
(In reply to comment #3)
> /usr/share/sounds/Fedora/stereo/tooltip-popup.disabled
> I suppose this is on purpose to silence the tooltip sound, correct?
Indeed. It seems impossible to silence both tooltips and rpmlint at the same
time... rpmlint really has no business deciding if empty files are ok in my
package or not.
rpmlint does not decide anything it just *helps* finding issues.
> AUTHORS not packaged and no parallel make (one might argue that
both does
> not make sense for this package)
AUTHORS is not very interesting, but I'll add it when I build the package. That
was just an oversight...
OK.
Parallel make really is a bit of a snake oil thing to begin with. I
am not
going to install 3 files faster by doing it on 8 processors...
Yeah.
=> APPROVED
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11:47 a.m.
New subject: [Bug 522148] sound-theme-fedora - Sound theme for Fedora
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=522148
--- Comment #5 from Matthias Clasen <mclasen(a)redhat.com> 2009-09-09 12:47:46 EDT
---
New Package CVS Request
=======================
Package Name: sound-theme-fedora
Short Description: Sound theme for Fedora
Owners: mclasen
Branches:
InitialCC:
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
11:48 a.m.
New subject: [Bug 522148] sound-theme-fedora - Sound theme for Fedora
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=522148
Matthias Clasen <mclasen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag| |fedora-cvs?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12:17 p.m.
New subject: [Bug 522148] Review Request: sound-theme-fedora - Sound theme for Fedora
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=522148
Jason Tibbitts <tibbs(a)math.uh.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|sound-theme-fedora - Sound |Review Request:
|theme for Fedora |sound-theme-fedora - Sound
| |theme for Fedora
--- Comment #6 from Jason Tibbitts <tibbs(a)math.uh.edu> 2009-09-10 13:17:47 EDT ---
How did this get all the way to CVS without being assigned to anyone?
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
12:35 p.m.
New subject: [Bug 522148] Review Request: sound-theme-fedora - Sound theme for Fedora
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=522148
Matthias Clasen <mclasen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flag|fedora-cvs? |
--- Comment #7 from Matthias Clasen <mclasen(a)redhat.com> 2009-09-10 13:35:30 EDT
---
Hold off on this one for now. Not sure if I'll need it or not.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
midnight
New subject: [Bug 522148] Review Request: sound-theme-fedora - Sound theme for Fedora
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=522148
Mamoru Tasaka <mtasaka(a)ioa.s.u-tokyo.ac.jp> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|nobody(a)fedoraproject.org |adel.gadllah(a)gmail.com
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
7:36 a.m.
New subject: [Bug 522148] Review Request: sound-theme-fedora - Sound theme for Fedora
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=522148
Matthias Clasen <mclasen(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |CLOSED
Resolution| |WONTFIX
--- Comment #8 from Matthias Clasen <mclasen(a)redhat.com> 2009-10-06 08:36:11 EDT
---
Ok, don't need this after all.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
10:39 a.m.
New subject: [Bug 522148] Review Request: sound-theme-fedora - Sound theme for Fedora
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=522148
udo <udovdh(a)xs4all.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |udovdh(a)xs4all.nl
--- Comment #9 from udo <udovdh(a)xs4all.nl> 2009-12-22 11:39:44 EDT ---
Another piece of nice work lost.
See https://bugzilla.redhat.com/show_bug.cgi?id=538617 for the effects of this
neglect.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
5264
days inactive
5368
days old
package-review@lists.fedoraproject.org
11 comments
1 participants
participants (1)
-
Red Hat Bugzilla