https://bugzilla.redhat.com/show_bug.cgi?id=1982618
Bug ID: 1982618 Summary: Review Request: php-christophwurst-id3parser - A pure ID3 parser based upon getID3 Product: Fedora Version: rawhide Hardware: All OS: Linux Status: NEW Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: ce@lcts.de QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org Target Milestone: --- Classification: Fedora
Spec URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-raw... SRPM URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-raw...
Description: ID3Parser is a pure ID3 parser based upon getID3. This library takes the ID3 parsing code from getID3 and strips all other functions.
Since this package is set up to use rpmautospec, rpmlint/fedora-review will complain about missing dist tags & macros in changelog. These are spurious errors/warnings.
This package is available from the lcts/nextcloud Copr, so you can also test it using 'fedora-review --copr-build 2329590'
Fedora Account System Username: lcts
https://bugzilla.redhat.com/show_bug.cgi?id=1982618
Christopher Engelhard ce@lcts.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1981857 Doc Type|--- |If docs needed, set a value
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1981857 [Bug 1981857] Unbundle 3rdparty PHP dependencies
https://bugzilla.redhat.com/show_bug.cgi?id=1982618
Tomas Korbar tkorbar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |tkorbar@redhat.com Assignee|nobody@fedoraproject.org |tkorbar@redhat.com
https://bugzilla.redhat.com/show_bug.cgi?id=1982618
Remi Collet fedora@famillecollet.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@famillecollet.com
--- Comment #1 from Remi Collet fedora@famillecollet.com --- PSR-0 conflict :(
/usr/share/php/ID3Parser is used by php-lukasreschke-id3parser, another fork of getid3
So I recommend to use a fake "vendor" directory, such as
/usr/share/php/christophwurst/ID3Parser
https://bugzilla.redhat.com/show_bug.cgi?id=1982618
--- Comment #2 from Tomas Korbar tkorbar@redhat.com --- Hi Christopher, i have a few comments, regarding this package.
[ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 10 files have unknown license. Detailed output of licensecheck in /home/tkorbar/packaging/fedora/reviews/php- christophwurst-id3parser/php-christophwurst-id3parser/licensecheck.txt
----- I do not think that license should be GPLv3+ but GPLv3 instead.
[ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/php/ID3Parser(php- lukasreschke-id3parser), /usr/share/php/ID3Parser/getID3(php- lukasreschke-id3parser), /usr/share/php/ID3Parser/getID3/Tags(php- lukasreschke-id3parser)
----- unfortunatelly this conflict will need to be resolved. You can use the solution Remi suggested.
[ ]: Package does not generate any conflict.
----- Same as before, there is a conflict with lukasreschkes project
https://bugzilla.redhat.com/show_bug.cgi?id=1982618
Christopher Engelhard ce@lcts.de changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(tkorbar@redhat.co | |m)
--- Comment #3 from Christopher Engelhard ce@lcts.de --- Spec URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-raw... SRPM URL: https://download.copr.fedorainfracloud.org/results/lcts/nextcloud/fedora-raw...
Hey, thanks for the review & sorry for the delay. $DAYJOB intervened...
(In reply to Tomas Korbar from comment #2)
----- I do not think that license should be GPLv3+ but GPLv3 instead.
Fixed.
[ ]: Package does not own files or directories owned by other packages.
----- unfortunatelly this conflict will need to be resolved. You can use the solution Remi suggested.
[ ]: Package does not generate any conflict.
----- Same as before, there is a conflict with lukasreschkes project
Fixed, the package now installs into %{phpdir}/ChristophWurst/ID3Parser as suggested.
https://bugzilla.redhat.com/show_bug.cgi?id=1982618
Tomas Korbar tkorbar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(tkorbar@redhat.co |fedora-review+ |m) |
--- Comment #4 from Tomas Korbar tkorbar@redhat.com --- The spec looks ok now.
https://bugzilla.redhat.com/show_bug.cgi?id=1982618
--- Comment #5 from Gwyn Ciesla gwync@protonmail.com --- (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/php-christophwurst-id3parser
https://bugzilla.redhat.com/show_bug.cgi?id=1982618
Maxwell G gotmax@e.email changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED CC| |gotmax@e.email Fixed In Version| |php-christophwurst-id3parse | |r-0.1.2-1.fc36 Resolution|--- |RAWHIDE Last Closed| |2021-12-04 02:38:08
package-review@lists.fedoraproject.org