Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
https://bugzilla.redhat.com/show_bug.cgi?id=427507
Summary: Review Request: hunspell-bn - Bengali hunspell dictionaries Product: Fedora Version: rawhide Platform: All OS/Version: Linux Status: NEW Severity: medium Priority: medium Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: pnemade@redhat.com QAContact: extras-qa@fedoraproject.org CC: fedora-package-review@redhat.com,notting@redhat.com
Spec URL: http://paragn.fedorapeople.org/hunspell/hunspell-bn.spec SRPM URL: http://paragn.fedorapeople.org/hunspell/hunspell-bn-20050726-1.fc8.src.rpm Description: Bengali hunspell dictionaries
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hunspell-bn - Bengali hunspell dictionaries
https://bugzilla.redhat.com/show_bug.cgi?id=427507
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@fedoraproject.org |tibbs@math.uh.edu Status|NEW |ASSIGNED Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hunspell-bn - Bengali hunspell dictionaries
https://bugzilla.redhat.com/show_bug.cgi?id=427507
------- Additional Comments From tibbs@math.uh.edu 2008-01-05 15:23 EST ------- rpmlint has one complaint: hunspell-bn.noarch: W: incoherent-version-in-changelog 1.0-1 20050726-1.fc9 Your changelog says 1.0-1 while the version is a bit different.
Also, you should include the Copyright file as %doc.
* source files match upstream: ad4f2133f7696a1d545572ab6724f2cc946a526025c6aeb84b67fdb2dd7b1bd5 bn-demo.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text included in package. * latest version is being packaged. * BuildRequires are proper (none) * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly X rpmlint has a valid complaint. * final provides and requires are sane: hunspell-bn = 20050726-1.fc9 = hunspell * %check is not present; no test suite upstream. I don't know Bengali so I'm afraid I can't test this. * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no scriptlets present. * code, not content. * documentation is small, so no -docs subpackage is necessary. * %docs are not necessary for the proper functioning of the package.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hunspell-bn - Bengali hunspell dictionaries
https://bugzilla.redhat.com/show_bug.cgi?id=427507
pnemade@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEEDINFO Flag| |needinfo?(tibbs@math.uh.edu)
------- Additional Comments From pnemade@redhat.com 2008-01-06 22:13 EST ------- updated package Spec URL: http://paragn.fedorapeople.org/hunspell/hunspell-bn.spec SRPM URL: http://paragn.fedorapeople.org/hunspell/hunspell-bn-20050726-2.fc8.src.rpm
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hunspell-bn - Bengali hunspell dictionaries
https://bugzilla.redhat.com/show_bug.cgi?id=427507
pnemade@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEEDINFO |ASSIGNED Flag|needinfo?(tibbs@math.uh.edu)|
------- Additional Comments From pnemade@redhat.com 2008-01-06 22:46 EST ------- tibbs, I am really sorry to make this bugzilla to needinfo on you. I thought may be this got removed from your priority review radar list. and thought if you are reviewed other packages then I thought better not to loose it and build it together with other reviews.
once again sorry to you.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hunspell-bn - Bengali hunspell dictionaries
https://bugzilla.redhat.com/show_bug.cgi?id=427507
tibbs@math.uh.edu changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
------- Additional Comments From tibbs@math.uh.edu 2008-01-07 01:03 EST ------- No need to apologize; it's bugzilla that makes it difficult as anything set to needinfo from me should show up at the very top of the bugzilla front page, not down near the bottom. I guess I should write up an enhancement request.
In any case, this package looks good now.
APPROVED
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hunspell-bn - Bengali hunspell dictionaries
https://bugzilla.redhat.com/show_bug.cgi?id=427507
pnemade@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
------- Additional Comments From pnemade@redhat.com 2008-01-07 01:11 EST ------- Thanks. New Package CVS Request ======================= Package Name: hunspell-bn Short Description: Bengali hunspell dictionaries Owners: pnemade Branches: F-8 InitialCC: Cvsextras Commits: yes
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hunspell-bn - Bengali hunspell dictionaries
https://bugzilla.redhat.com/show_bug.cgi?id=427507
petersen@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs? |fedora-cvs+
------- Additional Comments From petersen@redhat.com 2008-01-07 01:17 EST ------- cvs admin done
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report.
Summary: Review Request: hunspell-bn - Bengali hunspell dictionaries
https://bugzilla.redhat.com/show_bug.cgi?id=427507
pnemade@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |CLOSED Resolution| |NEXTRELEASE
------- Additional Comments From pnemade@redhat.com 2008-01-07 02:14 EST ------- Built for devel and F-8 successfully. Thanks to tibbs and Jens.
package-review@lists.fedoraproject.org