https://bugzilla.redhat.com/show_bug.cgi?id=1172972
Bug ID: 1172972 Summary: Review Request: nodejs-stream-combiner - Turn a pipeline into a single stream Product: Fedora Version: rawhide Component: Package Review Severity: medium Priority: medium Assignee: nobody@fedoraproject.org Reporter: pnemade@redhat.com QA Contact: extras-qa@fedoraproject.org CC: package-review@lists.fedoraproject.org
Spec URL: https://pnemade.fedorapeople.org/fedora-work/SPECS/nodejs-stream-combiner.sp... SRPM URL: https://pnemade.fedorapeople.org/fedora-work/SRPMS/nodejs-stream-combiner-0.... Description: Turn a pipeline into a single stream. Combine returns a stream that writes to the first stream and reads from the last stream.
Fedora Account System Username: pnemade
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
Parag pnemade@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Blocks| |1172968, 956806 | |(nodejs-reviews)
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=956806 [Bug 956806] Node.js Review Tracker https://bugzilla.redhat.com/show_bug.cgi?id=1172968 [Bug 1172968] Review Request: nodejs-event-stream - Construct pipes of streams of events
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
Piotr Popieluch piotr1212@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |piotr1212@gmail.com Depends On| |1172971 Assignee|nobody@fedoraproject.org |piotr1212@gmail.com Flags| |fedora-review+
--- Comment #1 from Piotr Popieluch piotr1212@gmail.com --- APPROVED
===== MUST items =====
Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 2 files have unknown license. Detailed output of licensecheck in /home/piotr/rpmbuild/1172972-nodejs-stream- combiner/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local
===== SHOULD items =====
Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified.
===== EXTRA items =====
Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM.
Rpmlint ------- Checking: nodejs-stream-combiner-0.2.1-1.fc22.noarch.rpm nodejs-stream-combiner-0.2.1-1.fc22.src.rpm nodejs-stream-combiner.noarch: W: only-non-binary-in-usr-lib nodejs-stream-combiner.noarch: W: dangling-symlink /usr/lib/node_modules/stream-combiner/node_modules/duplexer /usr/lib/node_modules/duplexer nodejs-stream-combiner.noarch: W: dangling-symlink /usr/lib/node_modules/stream-combiner/node_modules/through /usr/lib/node_modules/through 2 packages and 0 specfiles checked; 0 errors, 3 warnings.
Rpmlint (installed packages) ---------------------------- ]0;<mock-chroot><mock-chroot>[root@pontifex /]# rpmlint nodejs-stream-combiner nodejs-stream-combiner.noarch: W: only-non-binary-in-usr-lib nodejs-stream-combiner.noarch: W: dangling-symlink /usr/lib/node_modules/stream-combiner/node_modules/duplexer /usr/lib/node_modules/duplexer nodejs-stream-combiner.noarch: W: dangling-symlink /usr/lib/node_modules/stream-combiner/node_modules/through /usr/lib/node_modules/through 1 packages and 0 specfiles checked; 0 errors, 3 warnings. ]0;<mock-chroot><mock-chroot>[root@pontifex /]# echo 'rpmlint-done:'
Requires -------- nodejs-stream-combiner (rpmlib, GLIBC filtered): nodejs(engine) npm(duplexer) npm(through)
Provides -------- nodejs-stream-combiner: nodejs-stream-combiner npm(stream-combiner)
Source checksums ---------------- http://registry.npmjs.org/stream-combiner/-/stream-combiner-0.2.1.tgz : CHECKSUM(SHA256) this package : a2c841da53be2c7cd4c31243ba23093d68d6a32e74a70c4d69a01ff129e96ee7 CHECKSUM(SHA256) upstream package : a2c841da53be2c7cd4c31243ba23093d68d6a32e74a70c4d69a01ff129e96ee7
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -b 1172972 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Referenced Bugs:
https://bugzilla.redhat.com/show_bug.cgi?id=1172971 [Bug 1172971] Review Request: nodejs-duplexer - Creates a duplex stream
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
Parag pnemade@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Flags| |fedora-cvs?
--- Comment #2 from Parag pnemade@redhat.com --- Thank you for this package review.
New Package SCM Request ======================= Package Name: nodejs-stream-combiner Short Description: Turn a pipeline into a single stream Upstream URL: https://github.com/dominictarr/stream-combiner Owners: pnemade Branches: f20 f21 el6 epel7 InitialCC:
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
Jon Ciesla limburgher@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-cvs? |fedora-cvs+
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
--- Comment #3 from Jon Ciesla limburgher@gmail.com --- Git done (by process-git-requests).
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |MODIFIED
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
--- Comment #4 from Fedora Update System updates@fedoraproject.org --- nodejs-stream-combiner-0.2.1-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-stream-combiner-0.2.1-1.fc21
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
--- Comment #5 from Fedora Update System updates@fedoraproject.org --- nodejs-stream-combiner-0.2.1-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-stream-combiner-0.2.1-1.fc20
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
--- Comment #6 from Fedora Update System updates@fedoraproject.org --- nodejs-stream-combiner-0.2.1-1.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-stream-combiner-0.2.1-1.el7
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
--- Comment #7 from Fedora Update System updates@fedoraproject.org --- nodejs-stream-combiner-0.2.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-stream-combiner-0.2.1-1.el6
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
--- Comment #8 from Parag pnemade@redhat.com --- Built in rawhide, therefore closing this now.
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
Parag pnemade@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2014-12-20 06:29:06
https://bugzilla.redhat.com/show_bug.cgi?id=1172972 Bug 1172972 depends on bug 1172971, which changed state.
Bug 1172971 Summary: Review Request: nodejs-duplexer - Creates a duplex stream https://bugzilla.redhat.com/show_bug.cgi?id=1172971
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Resolution|--- |NEXTRELEASE
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |nodejs-stream-combiner-0.2. | |1-1.fc21 Resolution|NEXTRELEASE |ERRATA
--- Comment #9 from Fedora Update System updates@fedoraproject.org --- nodejs-stream-combiner-0.2.1-1.fc21 has been pushed to the Fedora 21 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-stream-combiner-0.2. |nodejs-stream-combiner-0.2. |1-1.fc21 |1-1.fc20
--- Comment #10 from Fedora Update System updates@fedoraproject.org --- nodejs-stream-combiner-0.2.1-1.fc20 has been pushed to the Fedora 20 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-stream-combiner-0.2. |nodejs-stream-combiner-0.2. |1-1.fc20 |1-1.el6
--- Comment #11 from Fedora Update System updates@fedoraproject.org --- nodejs-stream-combiner-0.2.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
https://bugzilla.redhat.com/show_bug.cgi?id=1172972
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version|nodejs-stream-combiner-0.2. |nodejs-stream-combiner-0.2. |1-1.el6 |1-1.el7
--- Comment #12 from Fedora Update System updates@fedoraproject.org --- nodejs-stream-combiner-0.2.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository.
package-review@lists.fedoraproject.org