https://bugzilla.redhat.com/show_bug.cgi?id=1948651
Petr Pisar <ppisar(a)redhat.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Flags|fedora-review? |fedora-review+
--- Comment #3 from Petr Pisar <ppisar(a)redhat.com> ---
Spec file changes:
--- perl-YAML-LibYAML-API.spec.old 2021-04-12 19:03:08.000000000 +0200
+++ perl-YAML-LibYAML-API.spec 2021-04-16 12:03:02.000000000 +0200
@@ -8,7 +8,6 @@
BuildRequires: coreutils
BuildRequires: findutils
BuildRequires: gcc
-BuildRequires: libyaml >= 0.2.5
BuildRequires: libyaml-devel >= 0.2.5
BuildRequires: make
BuildRequires: perl-devel
@@ -22,8 +21,7 @@
BuildRequires: perl(warnings)
# Run-time
BuildRequires: perl(XSLoader)
-BuildRequires: perl(YAML::PP) >= 0.024
-BuildRequires: perl(YAML::PP::Common)
+BuildRequires: perl(YAML::PP::Common) >= 0.024
# Tests
BuildRequires: perl(blib)
BuildRequires: perl(Encode)
@@ -31,9 +29,12 @@
BuildRequires: perl(FindBin)
BuildRequires: perl(IO::Handle)
BuildRequires: perl(IPC::Open3)
-BuildRequires: perl(Test::More)
+BuildRequires: perl(Test::More) >= 0.98
Requires: perl(:MODULE_COMPAT_%(eval "`perl -V:version`"; echo
$version))
-Requires: libyaml >= 0.2.5
+Requires: perl(YAML::PP::Common) >= 0.024
+
+# Filter unversioned require
+%global __requires_exclude
%{?__requires_exclude:%__requires_exclude|}perl\\(YAML::PP::Common\\)
%description
This module provides a thin wrapper around the C libyaml API.
@@ -59,6 +60,7 @@
%{_fixperms} $RPM_BUILD_ROOT/*
%check
+unset AUTHOR_TESTING
export HARNESS_OPTIONS=j$(perl -e 'if ($ARGV[0] =~ /.*-j([0-9][0-9]*).*/)
{print $1} else {print 1}' -- '%{?_smp_mflags}')
make test
TODO: Remove a trailing slash for the URL value.
Not
addressed.
TODO: Document in the spec file a license of the bundled ./LibYAML
files. It's a MIT license.
Not addreseed.
FIX: Do not build-require 'libyaml'. The packages only uses
libyaml-devel.
Ok.
FIX: Do not build-require 'perl(YAML::PP)'. It's used
nowhere.
Ok.
TODO: Constrain 'perl(YAML::PP::Common)' build-dependency
with '>= 0.024' (Makefile.PL:32). Upstream probably mistaken the two modules.
Ok.
TODO: Constrain 'perl(Test::More)' with '>= 0.98'
(META.json:38).
Ok.
TODO: I recommend unsetting AUTHOR_TESTING environment variable in
the %check section (t/00.compile.t:37).
Ok.
$ rpmlint perl-YAML-LibYAML-API.spec
../SRPMS/perl-YAML-LibYAML-API-0.012-1.fc35.src.rpm
../RPMS/x86_64/perl-YAML-LibYAML-API-*
4 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
FIX: Do not run-require 'libyaml'. The dependency is
automatically generated from a library SONAME (libyaml-0.so.2()(64bit)).
TODO: Constrain 'perl(YAML::PP::Common)' dependency with '>= 0.024'
(Makefile.PL:32). Upstream probably mistaken the two modules.
$ rpm -q --requires
-p
../RPMS/x86_64/perl-YAML-LibYAML-API-0.012-1.fc35.x86_64.rpm | sort -f | uniq
-c
1 libc.so.6()(64bit)
1 libc.so.6(GLIBC_2.11)(64bit)
1 libc.so.6(GLIBC_2.2.5)(64bit)
1 libc.so.6(GLIBC_2.4)(64bit)
1 libperl.so.5.32()(64bit)
1 libpthread.so.0()(64bit)
1 libpthread.so.0(GLIBC_2.2.5)(64bit)
1 libyaml-0.so.2()(64bit)
1 perl(:MODULE_COMPAT_5.32.1)
1 perl(strict)
1 perl(warnings)
1 perl(XSLoader)
1 perl(YAML::PP::Common) >= 0.024
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsZstd) <= 5.4.18-1
1 rtld(GNU_HASH)
Binary requires are Ok.
$ resolvedeps rawhide
../RPMS/x86_64/perl-YAML-LibYAML-API-0.012-1.fc35.x86_64.rpm
Binary dependencies are resolvable. Ok.
It still fails to build in F35
<
https://koji.fedoraproject.org/koji/taskinfo?taskID=66054894>. The full error
message as seen in my machine is:
Problém: problem with installed package redhat-rpm-config-183-1.fc35.noarch
- cannot install the best update candidate for package
redhat-rpm-config-183-1.fc35.noarch
- package redhat-rpm-config-183-1.fc35.noarch requires (annobin if (gcc or
clang)), but none of the providers can be installed
- cannot install the best update candidate for package
annobin-9.65-2.fc35.x86_64
- package annobin-docs-9.66-2.fc35.noarch obsoletes annobin < 9.66-2.fc35
provided by annobin-9.65-2.fc35.x86_64
- problem with installed package gcc-11.0.1-0.4.fc35.x86_64
- cannot install the best update candidate for package
gcc-11.0.1-0.4.fc35.x86_64
This seems to be an annobin bug #1949570.
Resolution: Package APPROVED.
--
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component