Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
Summary: Review Request: perl-MooseX-MultiMethods - Multi Method Dispatch based on Moose type constraints
https://bugzilla.redhat.com/show_bug.cgi?id=621037
Summary: Review Request: perl-MooseX-MultiMethods - Multi Method Dispatch based on Moose type constraints Product: Fedora Version: rawhide Platform: All URL: http://search.cpan.org/dist/MooseX-MultiMethods/ OS/Version: Linux Status: NEW Severity: medium Priority: low Component: Package Review AssignedTo: nobody@fedoraproject.org ReportedBy: iarnell@gmail.com QAContact: extras-qa@fedoraproject.org CC: notting@redhat.com, fedora-package-review@redhat.com Estimated Hours: 0.0 Classification: Fedora
Spec URL: http://fedorapeople.org/~iarnell/review/perl-MooseX-MultiMethods.spec SRPM URL: http://fedorapeople.org/~iarnell/review/perl-MooseX-MultiMethods-0.10-1.fc15...
Description: This module provides multi method dispatch based on Moose type constraints. It does so by providing a multi keyword that extends the method keyword provided by MooseX::Method::Signatures.
Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=2378452
*rt-0.10_01
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621037
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- CC| |ppisar@redhat.com AssignedTo|nobody@fedoraproject.org |ppisar@redhat.com Flag| |fedora-review?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621037
Petr Pisar ppisar@redhat.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+
--- Comment #1 from Petr Pisar ppisar@redhat.com 2010-08-04 07:45:34 EDT --- Sources match upstream. License verified from MultiMethods.pm. Homepage verified. Description verified. BuldRequires and Requiers verified. Spec file in line with generic and Perl specific packaging guidelines. All tests pass. Builds in dist-f15 buildroot.
# rpmlint perl-MooseX-MultiMethods.spec ../SRPMS/perl-MooseX-MultiMethods-0.10-1.fc14.src.rpm ../RPMS/noarch/perl-MooseX-MultiMethods-0.10-1.fc14.noarch.rpm perl-MooseX-MultiMethods.spec: W: no-cleaning-of-buildroot %clean perl-MooseX-MultiMethods.spec: W: no-buildroot-tag perl-MooseX-MultiMethods.spec: W: no-%clean-section perl-MooseX-MultiMethods.src: W: spelling-error Summary(en_US) Multi -> Mulch, Mufti perl-MooseX-MultiMethods.src: W: spelling-error %description -l en_US multi -> mulch, mufti perl-MooseX-MultiMethods.src: W: no-cleaning-of-buildroot %clean perl-MooseX-MultiMethods.src: W: no-buildroot-tag perl-MooseX-MultiMethods.src: W: no-%clean-section perl-MooseX-MultiMethods.noarch: W: spelling-error Summary(en_US) Multi -> Mulch, Mufti perl-MooseX-MultiMethods.noarch: W: spelling-error %description -l en_US multi -> mulch, mufti 2 packages and 1 specfiles checked; 0 errors, 10 warnings.
The on-%clean and no-buildroot warnings are bogus because this is post-EPEL-5 package. The spelling warnings are bogus either. rpmlint considered happy.
# rpm -pq --requires ../RPMS/noarch/perl-MooseX-MultiMethods-0.10-1.fc14.noarch.rpm |sort |uniq -d perl(aliased) perl(Devel::PartialDump) perl(Moose) perl(MooseX::Types::Moose) perl(namespace::autoclean) perl(Sub::Install)
These run-time dependencies are double-specified as they are auto-detected by rpmbuild. Packager is advised to remove corresponding explicit Requires statements from spec file.
# rpm -pq -lv ../RPMS/noarch/perl-MooseX-MultiMethods-0.10-1.fc14.noarch.rpm drwxr-xr-x 2 root root 0 srp 4 13:15 /usr/share/doc/perl-MooseX-MultiMethods-0.10 -rw-r--r-- 1 root root 1395 led 3 2010 /usr/share/doc/perl-MooseX-MultiMethods-0.10/Changes -rw-r--r-- 1 root root 18261 led 3 2010 /usr/share/doc/perl-MooseX-MultiMethods-0.10/LICENSE -rw-r--r-- 1 root root 327 led 3 2010 /usr/share/doc/perl-MooseX-MultiMethods-0.10/README -rw-r--r-- 1 root root 441 led 3 2010 /usr/share/doc/perl-MooseX-MultiMethods-0.10/dist.ini -rw-r--r-- 1 root root 2441 srp 4 13:15 /usr/share/man/man3/MooseX::MultiMethods.3pm.gz -rw-r--r-- 1 root root 1926 srp 4 13:15 /usr/share/man/man3/MooseX::MultiMethods::Meta::Method.3pm.gz drwxr-xr-x 2 root root 0 srp 4 13:15 /usr/share/perl5/MooseX drwxr-xr-x 2 root root 0 srp 4 13:15 /usr/share/perl5/MooseX/MultiMethods -rw-r--r-- 1 root root 4887 led 3 2010 /usr/share/perl5/MooseX/MultiMethods.pm drwxr-xr-x 2 root root 0 srp 4 13:15 /usr/share/perl5/MooseX/MultiMethods/Meta -rw-r--r-- 1 root root 1816 led 3 2010 /usr/share/perl5/MooseX/MultiMethods/Meta/Method.pm
File system layout and file attributes are correct.
Package APPROVED.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621037
--- Comment #2 from Iain Arnell iarnell@gmail.com 2010-08-04 10:38:52 EDT --- New Package CVS Request ======================= Package Name: perl-MooseX-MultiMethods Short Description: Multi Method Dispatch based on Moose type constraints Owners: iarnell Branches: F-13 F-14 InitialCC: perl-sig
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621037
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-cvs?
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621037
--- Comment #3 from Kevin Fenzi kevin@tummy.com 2010-08-05 13:11:28 EDT --- Git done (by process-git-requests).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621037
Iain Arnell iarnell@gmail.com changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |MODIFIED Depends on| |619332
--- Comment #4 from Iain Arnell iarnell@gmail.com 2010-08-05 23:14:36 EDT --- Imported and built in rawhide. Waiting for perl-MooseX-Types-VariantTable on branch(es).
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621037
Bug 621037 depends on bug 619332, which changed state.
Bug 619332 Summary: Review Request: perl-MooseX-Types-VariantTable - Type constraint based variant table https://bugzilla.redhat.com/show_bug.cgi?id=619332
What |Old Value |New Value ---------------------------------------------------------------------------- Resolution| |ERRATA Status|ON_QA |CLOSED
--- Comment #5 from Fedora Update System updates@fedoraproject.org 2010-08-29 23:19:01 EDT --- perl-MooseX-MultiMethods-0.10-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/perl-MooseX-MultiMethods-0.10-2.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621037
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|MODIFIED |ON_QA
--- Comment #6 from Fedora Update System updates@fedoraproject.org 2010-08-30 15:40:11 EDT --- perl-MooseX-MultiMethods-0.10-2.fc14 has been pushed to the Fedora 14 testing repository. If problems still persist, please make note of it in this bug report. If you want to test the update, you can install it with su -c 'yum --enablerepo=updates-testing update perl-MooseX-MultiMethods'. You can provide feedback for this update here: https://admin.fedoraproject.org/updates/perl-MooseX-MultiMethods-0.10-2.fc14
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621037
--- Comment #7 from Fedora Update System updates@fedoraproject.org 2010-09-08 00:29:06 EDT --- perl-MooseX-MultiMethods-0.10-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report.
Please do not reply directly to this email. All additional comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=621037
Fedora Update System updates@fedoraproject.org changed:
What |Removed |Added ---------------------------------------------------------------------------- Status|ON_QA |CLOSED Fixed In Version| |perl-MooseX-MultiMethods-0. | |10-2.fc14 Resolution| |ERRATA Last Closed| |2010-09-08 00:29:11
package-review@lists.fedoraproject.org