https://bugzilla.redhat.com/show_bug.cgi?id=2101964 Richard W.M. Jones <rjones(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rjones(a)redhat.com Assignee|nobody(a)fedoraproject.org |rjones(a)redhat.com Status|NEW |ASSIGNED Doc Type|--- |If docs needed, set a value -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2101964

https://bugzilla.redhat.com/show_bug.cgi?id=2101964 --- Comment #2 from Jerry James <loganjerry(a)gmail.com&gt; --- Okay, as long as the main dune package contains only the dune binary, I can see how that would work. When a new version of OCaml is released, for example, we could build ocaml-csexp and ocaml-pp with the old version of dune, then build a new version of dune. Currently, the main package contains more than just the dune binary, but I plan to change that along with the upgrade to 3.x. Would you like me to strip out all the manual stuff and give you a new version? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2101964

https://bugzilla.redhat.com/show_bug.cgi?id=2101964 Petr Pisar <ppisar(a)redhat.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |fedora-review? -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2101964

https://bugzilla.redhat.com/show_bug.cgi?id=2101964 --- Comment #5 from Richard W.M. Jones <rjones(a)redhat.com&gt; --- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ RWMJ: I don't think this is applicable because the application is not C/C++ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [-]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License [generated file]". 10 files have unknown license. Detailed output of licensecheck in /var/tmp/2101964-ocaml-pp/licensecheck.txt RWMJ: I checked upstream and it's MIT. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Ocaml: [x]: This should never happen RWMJ: Ignore this, bug in rpmlint. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. RWMJ: No signatures appear upstream as far as I can tell. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: RWMJ: Not sure what's wrong with rpmlint, but I manually checked the spec file myself. Source checksums ---------------- https://github.com/ocaml-dune/pp/releases/download/1.1.2/pp-1.1.2.tbz : CHECKSUM(SHA256) this package : e4a4e98d96b1bb76950fcd6da4e938c86d989df4d7e48f02f7a44595f5af1d56 CHECKSUM(SHA256) upstream package : e4a4e98d96b1bb76950fcd6da4e938c86d989df4d7e48f02f7a44595f5af1d56 Requires -------- ocaml-pp (rpmlib, GLIBC filtered): ocaml(CamlinternalFormatBasics) ocaml(Stdlib) ocaml(Stdlib__Buffer) ocaml(Stdlib__Either) ocaml(Stdlib__Format) ocaml(Stdlib__ListLabels) ocaml(Stdlib__Printf) ocaml(Stdlib__Seq) ocaml(Stdlib__Uchar) rtld(GNU_HASH) ocaml-pp-devel (rpmlib, GLIBC filtered): ocaml(CamlinternalFormatBasics) ocaml(Stdlib) ocaml(Stdlib__Buffer) ocaml(Stdlib__Either) ocaml(Stdlib__Format) ocaml(Stdlib__ListLabels) ocaml(Stdlib__Printf) ocaml(Stdlib__Seq) ocaml(Stdlib__Uchar) ocaml-pp(x86-64) ocamlx(Stdlib) ocamlx(Stdlib__Format) ocamlx(Stdlib__ListLabels) ocamlx(Stdlib__Printf) ocaml-pp-debuginfo (rpmlib, GLIBC filtered): ocaml-pp-debugsource (rpmlib, GLIBC filtered): Provides -------- ocaml-pp: ocaml(Pp) ocaml-pp ocaml-pp(x86-64) ocaml-pp-devel: ocaml(Pp) ocaml-pp-devel ocaml-pp-devel(x86-64) ocamlx(Pp) ocaml-pp-debuginfo: debuginfo(build-id) ocaml-pp-debuginfo ocaml-pp-debuginfo(x86-64) ocaml-pp-debugsource: ocaml-pp-debugsource ocaml-pp-debugsource(x86-64) Generated by fedora-review 0.8.0 (e988316) last change: 2022-04-07 Command line :/usr/bin/fedora-review -b 2101964 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Ocaml, C/C++ Disabled plugins: fonts, SugarActivity, R, PHP, Haskell, Java, Perl, Python Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2101964

https://bugzilla.redhat.com/show_bug.cgi?id=2101964 --- Comment #7 from Jerry James <loganjerry(a)gmail.com&gt; --- Thank you! I will update ocaml-dune as soon as this package is built. (In reply to Richard W.M. Jones from comment #5) The issue is that rpmlint command line options and output changed with the introduction of rpmlint 2.x, and nobody has gotten around to fixing fedora-review. See https://pagure.io/FedoraReview/issue/425. -- You are receiving this mail because: You are always notified about changes to this product and component You are on the CC list for the bug. https://bugzilla.redhat.com/show_bug.cgi?id=2101964

https://bugzilla.redhat.com/show_bug.cgi?id=2101964 Jerry James <loganjerry(a)gmail.com&gt; changed: What |Removed |Added ---------------------------------------------------------------------------- Fixed In Version| |ocaml-pp-1.1.2-2.fc37 Status|ASSIGNED |CLOSED Resolution|--- |NEXTRELEASE Last Closed| |2022-07-04 17:04:48 --- Comment #9 from Jerry James <loganjerry(a)gmail.com&gt; --- Built in Rawhide. A dune update will follow shortly. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component https://bugzilla.redhat.com/show_bug.cgi?id=2101964